Skip to contentSkip to conversation

tarballs generated by Makepkgs

DISCUSSION Christoph Hellwig 2 participants 5 messages Feb 15, 2009 – Mar 23, 2009

lore
Share & tools
lore
#0 lore raw

currently Makepkgs generats the source tarball as package-version.src.tar.gz, which is not what we used for recent releases and not what most other open source packages do. I'd like to change it to package-version.tar.gz, but that currently collides with the binary tar packages.

Does anyone still need those binary tar packages? If yes we should rename them, too or otherwise just remove them.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 8 lines · Christoph Hellwig

currently Makepkgs generats the source tarball as package-version.src.tar.gz, which is not what we used for recent releases and not what most other open source packages do. I'd like to change it to package-version.tar.gz, but that currently collides with the binary tar packages.

Does anyone still need those binary tar packages? If yes we should rename them, too or otherwise just remove them.

This would be the easiest way, renaming the binary packages to xfsprogs-$ver.bin.tar.gz and the source to the expected xfsprogs-$ver.tar.gz. Same patch would also go into xfsdump and dmapi.

build/Makefile +1 -1
Index: xfsprogs-dev/build/Makefile
===================================================================
@@ -6,7 +6,7 @@ TOPDIR = ..
 include $(TOPDIR)/include/builddefs
 
 MANIFEST=src-manifest
-SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
+SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 
 LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
 
build/tar/Makefile +1 -1
Index: xfsprogs-dev/build/tar/Makefile
===================================================================
@@ -5,7 +5,7 @@
 TOPDIR = ../..
 include $(TOPDIR)/include/builddefs
 
-BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
+BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
 LDIRT = *.gz
 
 default install install-dev install-lib:

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw

ping?

Quoted 42 lines · Christoph Hellwig
Quoted 8 lines · Christoph Hellwig

currently Makepkgs generats the source tarball as package-version.src.tar.gz, which is not what we used for recent releases and not what most other open source packages do. I'd like to change it to package-version.tar.gz, but that currently collides with the binary tar packages.

Does anyone still need those binary tar packages? If yes we should rename them, too or otherwise just remove them.

This would be the easiest way, renaming the binary packages to xfsprogs-$ver.bin.tar.gz and the source to the expected xfsprogs-$ver.tar.gz. Same patch would also go into xfsdump and dmapi.

Index: xfsprogs-dev/build/Makefile
===================================================================

build/Makefile +1 -1
@@ -6,7 +6,7 @@ TOPDIR = ..
 include $(TOPDIR)/include/builddefs
 
 MANIFEST=src-manifest
-SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
+SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 
 LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
 

Index: xfsprogs-dev/build/tar/Makefile
===================================================================

build/tar/Makefile +1 -1
@@ -5,7 +5,7 @@
 TOPDIR = ../..
 include $(TOPDIR)/include/builddefs
 
-BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
+BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
 LDIRT = *.gz
 
 default install install-dev install-lib:
Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

---end quoted text---

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by
#3 lore raw
In reply to Christoph Hellwig
Quoted 7 lines · Christoph Hellwig
Quoted 6 lines · Christoph Hellwig

currently Makepkgs generats the source tarball as package-version.src.tar.gz, which is not what we used for recent releases and not what most other open source packages do. I'd like to change it to package-version.tar.gz, but that currently collides with the binary tar packages.

Quoted 7 lines
Quoted 2 lines

Does anyone still need those binary tar packages? If yes we should rename them, too or otherwise just remove them.

This would be the easiest way, renaming the binary packages to xfsprogs-$ver.bin.tar.gz and the source to the expected xfsprogs-$ver.tar.gz. Same patch would also go into xfsdump and dmapi.

Yes, this looks good. it always bugged me the way it was ;)

Missed this for review based on no [PATCH] ;)

(same for the other packages as well)

Quoted 27 lines

Index: xfsprogs-dev/build/Makefile
===================================================================

build/Makefile +1 -1
@@ -6,7 +6,7 @@ TOPDIR = ..
 include $(TOPDIR)/include/builddefs
 
 MANIFEST=src-manifest
-SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
+SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 
 LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
 

Index: xfsprogs-dev/build/tar/Makefile
===================================================================

build/tar/Makefile +1 -1
@@ -5,7 +5,7 @@
 TOPDIR = ../..
 include $(TOPDIR)/include/builddefs
 
-BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
+BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
 LDIRT = *.gz
 
 default install install-dev install-lib:
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#4 lore raw
Quoted 7 lines · Eric Sandeen

Yes, this looks good. it always bugged me the way it was ;)

Missed this for review based on no [PATCH] ;)

(same for the other packages as well)

Thanks, I've pushed this and the equivalent changes for xfsdump and dmapi out to the kernel.org trees.

Now the only outstanding userspace patches for the 3.0.1 releases is the whole autoconf/libtool magic from Andreas. Although we might consider this reviewed enough given that it comes from the acl/attr build system.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs