Skip to contentSkip to conversation

V4L2: Add COLORFX user control

PATCH In review Mauro Carvalho Chehab 2 participants 2 messages Feb 16, 2009 – Feb 17, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 V4L2: Add COLORFX user control

Michael/Hans,

As nobody complained, and this seems to be required by some webcams, I'm committing this changeset. Please update V4L2 API to reflect this change.

Cheers,
Mauro.

Forwarded message:

Date: Tue, 20 Jan 2009 16:29:26 -0600
From: "Aguirre Rodriguez, Sergio Alberto" <[email protected]>
To: "[email protected]" <[email protected]>
Cc: "[email protected]" <[email protected]>, "Nagalla, Hari" <[email protected]>, Sakari Ailus <[email protected]>, "Tuukka.O Toivonen" <[email protected]>, "[email protected]" <[email protected]>, "Curran, Dominic" <[email protected]>
Subject: [PATCH v2] V4L2: Add COLORFX user control

Quoted 1 line

From 07396d67b39bf7bcc81440d3e72d253ad6c54f11 Mon Sep 17 00:00:00 2001

From: Sergio Aguirre <[email protected]>
Date: Tue, 20 Jan 2009 15:34:43 -0600
Subject: [PATCH v2] V4L2: Add COLORFX user control

This is a common feature on many cameras. the options are:
Default colors,
B & W,
Sepia

---
 include/linux/videodev2.h |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
include/linux/videodev2.h +8 -1
index 4669d7e..89ed395 100644
@@ -876,8 +876,15 @@ enum v4l2_power_line_frequency {
 #define V4L2_CID_BACKLIGHT_COMPENSATION 	(V4L2_CID_BASE+28)
 #define V4L2_CID_CHROMA_AGC                     (V4L2_CID_BASE+29)
 #define V4L2_CID_COLOR_KILLER                   (V4L2_CID_BASE+30)
+#define V4L2_CID_COLORFX			(V4L2_CID_BASE+31)
+enum v4l2_colorfx {
+	V4L2_COLORFX_NONE	= 0,
+	V4L2_COLORFX_BW		= 1,
+	V4L2_COLORFX_SEPIA	= 2,
+};
+
 /* last CID + 1 */
-#define V4L2_CID_LASTP1                         (V4L2_CID_BASE+31)
+#define V4L2_CID_LASTP1                         (V4L2_CID_BASE+32)
 
 /*  MPEG-class control IDs defined by V4L2 */
 #define V4L2_CID_MPEG_BASE 			(V4L2_CTRL_CLASS_MPEG | 0x900)
Signature · 12 lines
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html




Cheers,
Mauro
#1 lore raw
Quoted 4 lines · On Monday 16 February 2009 20:01:22 Mauro Carvalho Chehab wrote:

Michael/Hans,

As nobody complained, and this seems to be required by some webcams, I'm committing this changeset. Please update V4L2 API to reflect this change.

I will do that this week (and also add this control to v4l2-common.c). BTW, in the future changesets that modify or add to the v4l2 spec should only be accepted if it also includes an update for the v4l2 spec. Now that the spec is part of the repository there is no excuse for not updating it.

This change predates the merging of the spec, so it's not a problem here.

Regards,

Hans

Quoted 53 lines

Cheers,
Mauro.

Forwarded message:

Date: Tue, 20 Jan 2009 16:29:26 -0600
From: "Aguirre Rodriguez, Sergio Alberto" <[email protected]>
To: "[email protected]" <[email protected]>
Cc: "[email protected]" <[email protected]>, "Nagalla, Hari" <[email protected]>, Sakari Ailus <[email protected]>, "Tuukka.O Toivonen" <[email protected]>, "[email protected]" <[email protected]>, "Curran, Dominic" <[email protected]> Subject: [PATCH v2] V4L2: Add COLORFX user control

From 07396d67b39bf7bcc81440d3e72d253ad6c54f11 Mon Sep 17 00:00:00 2001
From: Sergio Aguirre <[email protected]>
Date: Tue, 20 Jan 2009 15:34:43 -0600
Subject: [PATCH v2] V4L2: Add COLORFX user control

This is a common feature on many cameras. the options are:
Default colors,
B & W,
Sepia

---
 include/linux/videodev2.h |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
include/linux/videodev2.h +8 -1
index 4669d7e..89ed395 100644
@@ -876,8 +876,15 @@ enum v4l2_power_line_frequency {
 #define V4L2_CID_BACKLIGHT_COMPENSATION 	(V4L2_CID_BASE+28)
 #define V4L2_CID_CHROMA_AGC                     (V4L2_CID_BASE+29)
 #define V4L2_CID_COLOR_KILLER                   (V4L2_CID_BASE+30)
+#define V4L2_CID_COLORFX			(V4L2_CID_BASE+31)
+enum v4l2_colorfx {
+	V4L2_COLORFX_NONE	= 0,
+	V4L2_COLORFX_BW		= 1,
+	V4L2_COLORFX_SEPIA	= 2,
+};
+
 /* last CID + 1 */
-#define V4L2_CID_LASTP1                         (V4L2_CID_BASE+31)
+#define V4L2_CID_LASTP1                         (V4L2_CID_BASE+32)
 
 /*  MPEG-class control IDs defined by V4L2 */
 #define V4L2_CID_MPEG_BASE 			(V4L2_CTRL_CLASS_MPEG | 0x900)
Signature · 1 line
Hans Verkuil - video4linux developer - sponsored by TANDBERG