Skip to contentSkip to conversation

Multiadapter/multibus I2C, i2c.h fix

PATCH New ksi at koi8.net 2 participants 3 messages Feb 14, 2009 – Feb 17, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Multiadapter/multibus I2C, i2c.h fix

Add missing #endif in include/i2c.h

---

include/i2c.h +1 -0
diff -purN u-boot-i2c.ORIG/include/i2c.h u-boot-i2c/include/i2c.h
@@ -226,6 +226,7 @@ void i2c_reloc_fixup(void);
 # else
 #  define I2C_SOFT_DEFS
 # endif
+#endif
 
 /*
  * Initialization, must be called once on start up, may be called
#1 lore raw

PATCH 1/1 Multiadapter/multibus I2C, i2c.h fix

Dear ksi at koi8.net,

include/i2c.h void i2c_reloc_fixup(void); · line 229

Quoted 12 lines · In message <[email protected]> you wrote:

Add missing #endif in include/i2c.h

---
diff -purN u-boot-i2c.ORIG/include/i2c.h u-boot-i2c/include/i2c.h

include/i2c.h +1 -0
@@ -226,6 +226,7 @@ void i2c_reloc_fixup(void);
 # else
 #  define I2C_SOFT_DEFS
 # endif
+#endif

Such a patch must NEVER, never ever be part of a patch series. It guarantess that we have un-bisectable code in the tree. Please rebase your branch and squash related patches before posting them here.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Of all the things I've lost, I miss my mind the most.
#2 lore raw

PATCH 1/1 Multiadapter/multibus I2C, i2c.h fix

Quoted 5 lines · Wolfgang Denk

Dear ksi at koi8.net,

Quoted 2 lines · In message <[email protected]> you wrote:

Add missing #endif in include/i2c.h

Quoted 14 lines

include/i2c.h void i2c_reloc_fixup(void); · line 229

Quoted 10 lines

---
diff -purN u-boot-i2c.ORIG/include/i2c.h u-boot-i2c/include/i2c.h

include/i2c.h +1 -0
@@ -226,6 +226,7 @@ void i2c_reloc_fixup(void);
 # else
 #  define I2C_SOFT_DEFS
 # endif
+#endif

Such a patch must NEVER, never ever be part of a patch series. It guarantess that we have un-bisectable code in the tree. Please rebase your branch and squash related patches before posting them here.

Sure.

---
******************************************************************
* KSI at home KOI8 Net < > The impossible we do immediately. *
* Las Vegas NV, USA < > Miracles require 24-hour notice. *
******************************************************************