Skip to contentSkip to conversation

ocfs2: Use the right access_* method in ctime update of xattr.

PATCH New Tao Ma 3 participants 5 messages Feb 16, 2009 – Feb 17, 2009 OCFS2

lore
Share & tools
lore

Tao Ma

author
#0 lore raw

PATCH 1/1 ocfs2: Use the right access_* method in ctime update of xattr.

In ctime updating of xattr, it use the wrong type of access for inode, so use ocfs2_journal_access_di instead.

---
 fs/ocfs2/xattr.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
fs/ocfs2/xattr.c +3 -2
index 915039f..e393315 100644
@@ -2592,8 +2592,9 @@ static int __ocfs2_xattr_set_handle(struct inode *inode,
 
 	if (!ret) {
 		/* Update inode ctime. */
-		ret = ocfs2_journal_access(ctxt->handle, inode, xis->inode_bh,
-					   OCFS2_JOURNAL_ACCESS_WRITE);
+		ret = ocfs2_journal_access_di(ctxt->handle, inode,
+					      xis->inode_bh,
+					      OCFS2_JOURNAL_ACCESS_WRITE);
 		if (ret) {
 			mlog_errno(ret);
 			goto out;
Signature · 1 line
1.5.5
#1 lore raw

PATCH 1/1 ocfs2: Use the right access_* method in ctime update of xattr.

Quoted 4 lines · Tao Ma

In ctime updating of xattr, it use the wrong type of access for inode, so use ocfs2_journal_access_di instead.

Eek! How did tristan's and my testing miss this? Mark, this is
a bugfix for .29.

Signature · 10 lines
"In the beginning, the universe was created. This has made a lot 
 of people very angry, and is generally considered to have been a 
 bad move."
        - Douglas Adams

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
author
#2 lore raw

PATCH 1/1 ocfs2: Use the right access_* method in ctime update of xattr.

Quoted 8 lines · Joel Becker
Quoted 4 lines · Tao Ma

In ctime updating of xattr, it use the wrong type of access for inode, so use ocfs2_journal_access_di instead.

Eek! How did tristan's and my testing miss this? Mark, this is
a bugfix for .29.

actually tristan's test case found this and I just don't have time to investigate on it until now.
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1065

Thank you, tristan.

Regards,
Tao

#3 lore raw

PATCH 1/1 ocfs2: Use the right access_* method in ctime update of xattr.

Quoted 7 lines · Tao Ma
Quoted 2 lines

Eek! How did tristan's and my testing miss this? Mark, this is
a bugfix for .29.

actually tristan's test case found this and I just don't have time to investigate on it until now.
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1065

Thank you, tristan.

Oh, awesome. Thank you, tristan, indeed! Perhaps the patch
needs a Reported-by: Tristan... tag.

Joel

Signature · 8 lines
"Anything that is too stupid to be spoken is sung."  
        - Voltaire

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
#4 lore raw

PATCH 1/1 ocfs2: Use the right access_* method in ctime update of xattr.

Quoted 2 lines · Joel Becker

Oh, awesome. Thank you, tristan, indeed! Perhaps the patch
needs a Reported-by: Tristan... tag

Yes. We should start adding Reported-by and Tested-by in fixes.