Skip to contentSkip to conversation

mpc8xx_pcmcia: move CONFIG_8xx out of .c file and into Makefile

PATCH New Mike Frysinger 2 participants 2 messages Jan 30, 2009 – Feb 17, 2009 Pcmcia

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpc8xx_pcmcia: move CONFIG_8xx out of .c file and into Makefile

Move the CONFIG_8xx mpc8xx_pcmcia.c protection out of the C file and into the Makefile so we avoid pointless compiling of the file.

---
 drivers/pcmcia/Makefile        |    2 +-
 drivers/pcmcia/mpc8xx_pcmcia.c |    6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)
drivers/pcmcia/Makefile +1 -1
index ba251d0..babe3ec 100644
@@ -26,7 +26,7 @@ include $(TOPDIR)/config.mk
 LIB	:= $(obj)libpcmcia.a
 
 COBJS-$(CONFIG_I82365) += i82365.o
-COBJS-y += mpc8xx_pcmcia.o
+COBJS-$(CONFIG_8xx) += mpc8xx_pcmcia.o
 COBJS-$(CONFIG_PXA_PCMCIA) += pxa_pcmcia.o
 COBJS-y += rpx_pcmcia.o
 COBJS-$(CONFIG_IDE_TI_CARDBUS) += ti_pci1410a.o
drivers/pcmcia/mpc8xx_pcmcia.c +2 -4
index 95ea5e9..7030574 100644
@@ -1,7 +1,5 @@
 #include <common.h>
-#if defined(CONFIG_8xx)
 #include <mpc8xx.h>
-#endif
 #include <pcmcia.h>
 
 #undef	CONFIG_PCMCIA
@@ -14,7 +12,7 @@
 #define	CONFIG_PCMCIA
 #endif
 
-#if defined(CONFIG_8xx)	&& defined(CONFIG_PCMCIA)
+#if defined(CONFIG_PCMCIA)
 
 #if	defined(CONFIG_IDE_8xx_PCCARD)
 extern int check_ide_device (int slot);
@@ -301,4 +299,4 @@ static u_int m8xx_get_speed(u_int ns, u_int is_io)
 }
 #endif	/* 0 */
 
-#endif	/* CONFIG_8xx && CONFIG_PCMCIA */
+#endif	/* CONFIG_PCMCIA */
Signature · 1 line
1.6.1.1
#1 lore raw

PATCH 1/1 mpc8xx_pcmcia: move CONFIG_8xx out of .c file and into Makefile

Dear Mike Frysinger,

Quoted 8 lines · In message <[email protected]> you wrote:

Move the CONFIG_8xx mpc8xx_pcmcia.c protection out of the C file and into the Makefile so we avoid pointless compiling of the file.

---
 drivers/pcmcia/Makefile        |    2 +-
 drivers/pcmcia/mpc8xx_pcmcia.c |    6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Human beings were created by water to transport it uphill.