Skip to contentSkip to conversation

V4L: missing parentheses?

PATCH In review Mauro Carvalho Chehab 2 participants 2 messages Feb 18, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 V4L: missing parentheses?

Patch resent to the proper ML, in order to be handled by patchwork.

Michael,
The patch seems ok to my eyes. Please ack if ok for you to apply it.

Forwarded message:

Date: Wed, 18 Feb 2009 10:11:10 +0100
From: Roel Kluin <[email protected]>
To: Michael Krufky <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>, [email protected], Andrew Morton <[email protected]>
Subject: [PATCH] V4L: missing parentheses?

Please review. --------------------------->8-------------8<------------------------------ Add missing parentheses

---

drivers/media/common/tuners/tda18271-common.c +3 -3
index 6fb5b45..fc76c30 100644
@@ -490,9 +490,9 @@ int tda18271_set_standby_mode(struct dvb_frontend *fe,
 		tda_dbg("sm = %d, sm_lt = %d, sm_xt = %d\n", sm, sm_lt, sm_xt);
 
 	regs[R_EP3]  &= ~0xe0; /* clear sm, sm_lt, sm_xt */
-	regs[R_EP3]  |= sm    ? (1 << 7) : 0 |
-			sm_lt ? (1 << 6) : 0 |
-			sm_xt ? (1 << 5) : 0;
+	regs[R_EP3]  |= (sm    ? (1 << 7) : 0) |
+			(sm_lt ? (1 << 6) : 0) |
+			(sm_xt ? (1 << 5) : 0);
 
 	return tda18271_write_regs(fe, R_EP3, 1);
 }

Cheers,
Mauro

Acked-by on v1 1/1
#1 lore raw

Yes, Please merge this Mauro.

Thank you :-)

Strange, I didn't get the original mail, but I got Mauro's replies... Oh well.

Cheers,

Mike

Quoted 44 lines · Mauro Carvalho Chehab

Patch resent to the proper ML, in order to be handled by patchwork.

Michael,
The patch seems ok to my eyes. Please ack if ok for you to apply it.

Forwarded message:

Date: Wed, 18 Feb 2009 10:11:10 +0100
From: Roel Kluin <[email protected]>
To: Michael Krufky <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>, [email protected], Andrew Morton <[email protected]>
Subject: [PATCH] V4L: missing parentheses?

Please review. --------------------------->8-------------8<------------------------------ Add missing parentheses

---

drivers/media/common/tuners/tda18271-common.c +3 -3
index 6fb5b45..fc76c30 100644
@@ -490,9 +490,9 @@ int tda18271_set_standby_mode(struct dvb_frontend *fe,
 		tda_dbg("sm = %d, sm_lt = %d, sm_xt = %d\n", sm, sm_lt, sm_xt);
 
 	regs[R_EP3]  &= ~0xe0; /* clear sm, sm_lt, sm_xt */
-	regs[R_EP3]  |= sm    ? (1 << 7) : 0 |
-			sm_lt ? (1 << 6) : 0 |
-			sm_xt ? (1 << 5) : 0;
+	regs[R_EP3]  |= (sm    ? (1 << 7) : 0) |
+			(sm_lt ? (1 << 6) : 0) |
+			(sm_xt ? (1 << 5) : 0);
 
 	return tda18271_write_regs(fe, R_EP3, 1);
 }

Cheers,
Mauro