net: Optimize skb_tx_hash() by eliminating a comparison
Subsystems (2)
PATCH 1/1 net: Optimize skb_tx_hash() by eliminating a comparison
From: Krishna Kumar <[email protected]>
Optimize skb_tx_hash() by eliminating a comparison that executes for every packet. skb_tx_hashrnd initialization is moved to a later part of the startup sequence, namely after the "random" driver is initialized.
Rebooted the system three times and verified that the code generates different random numbers each time.
---
net/core/dev.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
net/core/dev.c +8 -6
@@ -1745,17 +1745,11 @@ out_kfree_skb: }static u32 skb_tx_hashrnd; -static int skb_tx_hashrnd_initialized =0 ;static u16 skb_tx_hash (struct net_device *dev,struct sk_buff *skb) {u32 hash; -if (unlikely (!skb_tx_hashrnd_initialized)) { -get_random_bytes (&skb_tx_hashrnd,4 ); - skb_tx_hashrnd_initialized =1 ; - } -if (skb_rx_queue_recorded (skb)) { hash =skb_get_rx_queue (skb); }else if (skb->sk && skb->sk->sk_hash) {
@@ -5291,6 +5285,14 @@ out:subsys_initcall (net_dev_init); +static int __init initialize_hashrnd (void ) +{ +get_random_bytes (&skb_tx_hashrnd,sizeof (skb_tx_hashrnd)); +return 0 ; +} + +late_initcall_sync (initialize_hashrnd); +EXPORT_SYMBOL (__dev_get_by_index);EXPORT_SYMBOL (__dev_get_by_name);EXPORT_SYMBOL (__dev_remove_pack);
From: Krishna Kumar <[email protected]>
Date: Wed, 18 Feb 2009 14:50:16 +0530
Quoted 8 lines
Optimize
skb_tx_hash()by eliminating a comparison that executes for every packet.skb_tx_hashrndinitialization is moved to a later part of the startup sequence, namely after the "random" driver is initialized.Rebooted the system three times and verified that the code generates different random numbers each time.
Signed-off-by Krishna Kumar <[email protected]>
Applied to net-next-2.6, thank you!