Skip to contentSkip to conversation

libfc: fix printk format warnings

PATCH In review Randy Dunlap 3 participants 3 messages Feb 18, 2009 – Feb 19, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libfc: fix printk format warnings

From: Randy Dunlap <[email protected]>

Fix libfc printk format warnings:

drivers/scsi/libfc/fc_lport.c:788: warning: long long unsigned int format, u64 arg (arg 3) drivers/scsi/libfc/fc_lport.c:792: warning: long long unsigned int format, u64 arg (arg 3) drivers/scsi/libfc/fc_rport.c:968: warning: long long unsigned int format, u64 arg (arg 4)

---
 drivers/scsi/libfc/fc_lport.c |    5 +++--
 drivers/scsi/libfc/fc_rport.c |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/scsi/libfc/fc_lport.c +3 -2
@@ -786,10 +786,11 @@ static void fc_lport_recv_flogi_req(stru
 	remote_wwpn = get_unaligned_be64(&flp->fl_wwpn);
 	if (remote_wwpn == lport->wwpn) {
 		FC_DBG("FLOGI from port with same WWPN %llx "
-		       "possible configuration error\n", remote_wwpn);
+		       "possible configuration error\n",
+		       (unsigned long long)remote_wwpn);
 		goto out;
 	}
-	FC_DBG("FLOGI from port WWPN %llx\n", remote_wwpn);
+	FC_DBG("FLOGI from port WWPN %llx\n", (unsigned long long)remote_wwpn);
 
 	/*
 	 * XXX what is the right thing to do for FIDs?
drivers/scsi/libfc/fc_rport.c +1 -1
@@ -966,7 +966,7 @@ static void fc_rport_recv_plogi_req(stru
 	switch (rdata->rp_state) {
 	case RPORT_ST_INIT:
 		FC_DEBUG_RPORT("incoming PLOGI from %6x wwpn %llx state INIT "
-			       "- reject\n", sid, wwpn);
+			       "- reject\n", sid, (unsigned long long)wwpn);
 		reject = ELS_RJT_UNSUP;
 		break;
 	case RPORT_ST_PLOGI:
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix libfc printk format warnings:

drivers/scsi/libfc/fc_lport.c:788: warning: long long unsigned int format, u64 arg (arg 3) drivers/scsi/libfc/fc_lport.c:792: warning:
long long unsigned int format, u64 arg (arg 3) drivers/scsi/libfc/fc_rport.c:968: warning: long long unsigned int format, u64 arg (arg 4)

This patch will conflict with the updates I've sent and some that I plan to send since we've done an overhaul of our debugging statements. If there's anything I can do to help with this, let me know.

Quoted 33 lines
---
 drivers/scsi/libfc/fc_lport.c |    5 +++--
 drivers/scsi/libfc/fc_rport.c |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/scsi/libfc/fc_lport.c +3 -2
@@ -786,10 +786,11 @@ static void fc_lport_recv_flogi_req(stru
 	remote_wwpn = get_unaligned_be64(&flp->fl_wwpn);
 	if (remote_wwpn == lport->wwpn) {
 		FC_DBG("FLOGI from port with same WWPN %llx "
-		       "possible configuration error\n", remote_wwpn);
+		       "possible configuration error\n",
+		       (unsigned long long)remote_wwpn);
 		goto out;
 	}
-	FC_DBG("FLOGI from port WWPN %llx\n", remote_wwpn);
+	FC_DBG("FLOGI from port WWPN %llx\n", (unsigned long
 long)remote_wwpn); 
 
 	/*
drivers/scsi/libfc/fc_lport.c +0 -0
 	 * XXX what is the right thing to do for FIDs?
drivers/scsi/libfc/fc_rport.c +1 -1
@@ -966,7 +966,7 @@ static void fc_rport_recv_plogi_req(stru
 	switch (rdata->rp_state) {
 	case RPORT_ST_INIT:
 		FC_DEBUG_RPORT("incoming PLOGI from %6x wwpn %llx state INIT "
-			       "- reject\n", sid, wwpn);
+			       "- reject\n", sid, (unsigned long long)wwpn);
 		reject = ELS_RJT_UNSUP;
 		break;
 	case RPORT_ST_PLOGI:
#2 lore raw
In reply to Randy Dunlap
Quoted 8 lines · On Wed, 18 Feb 2009 13:12:38 -0800 Randy Dunlap <[email protected]> wrote:

From: Randy Dunlap <[email protected]>

Fix libfc printk format warnings:

drivers/scsi/libfc/fc_lport.c:788: warning: long long unsigned int format, u64 arg (arg 3) drivers/scsi/libfc/fc_lport.c:792: warning: long long unsigned int format, u64 arg (arg 3) drivers/scsi/libfc/fc_rport.c:968: warning: long long unsigned int format, u64 arg (arg 4)

Quoted 5 lines
---
 drivers/scsi/libfc/fc_lport.c |    5 +++--
 drivers/scsi/libfc/fc_rport.c |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

The identical patch is in scsi-misc?

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commitdiff;h=e109928f140e3cbd5bfeacb5c0d2b2e820b11be5

Quoted 31 lines
drivers/scsi/libfc/fc_lport.c +3 -2
@@ -786,10 +786,11 @@ static void fc_lport_recv_flogi_req(stru
 	remote_wwpn = get_unaligned_be64(&flp->fl_wwpn);
 	if (remote_wwpn == lport->wwpn) {
 		FC_DBG("FLOGI from port with same WWPN %llx "
-		       "possible configuration error\n", remote_wwpn);
+		       "possible configuration error\n",
+		       (unsigned long long)remote_wwpn);
 		goto out;
 	}
-	FC_DBG("FLOGI from port WWPN %llx\n", remote_wwpn);
+	FC_DBG("FLOGI from port WWPN %llx\n", (unsigned long long)remote_wwpn);
 
 	/*
 	 * XXX what is the right thing to do for FIDs?
drivers/scsi/libfc/fc_rport.c +1 -2
@@ -966,7 +966,7 @@ static void fc_rport_recv_plogi_req(stru
 	switch (rdata->rp_state) {
 	case RPORT_ST_INIT:
 		FC_DEBUG_RPORT("incoming PLOGI from %6x wwpn %llx state INIT "
-			       "- reject\n", sid, wwpn);
+			       "- reject\n", sid, (unsigned long long)wwpn);
 		reject = ELS_RJT_UNSUP;
 		break;
 	case RPORT_ST_PLOGI:
--

To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html