Skip to contentSkip to conversation

qla2x: fix printk format warnings

PATCH In review Randy Dunlap 4 participants 5 messages Feb 18, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qla2x: fix printk format warnings

From: Randy Dunlap <[email protected]>

Fix qla2xxx printk format warnings:

drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5) drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 6) drivers/scsi/qla2xxx/qla_sup.c:923: warning: long long unsigned int format, u64 arg (arg 5) drivers/scsi/qla2xxx/qla_sup.c:923: warning: long long unsigned int format, u64 arg (arg 6)

---
 drivers/scsi/qla2xxx/qla_sup.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_sup.c +5 -2
@@ -914,7 +914,9 @@ qla2xxx_flash_npiv_conf(scsi_qla_host_t 
 
 		DEBUG2(qla_printk(KERN_DEBUG, ha, "NPIV[%02x]: wwpn=%llx "
 			"wwnn=%llx vf_id=0x%x Q_qos=0x%x F_qos=0x%x.\n", cnt,
-			vid.port_name, vid.node_name, le16_to_cpu(entry->vf_id),
+			(unsigned long long)vid.port_name,
+			(unsigned long long)vid.node_name,
+			le16_to_cpu(entry->vf_id),
 			entry->q_qos, entry->f_qos));
 
 		if (i < QLA_PRECONFIG_VPORTS) {
@@ -923,7 +925,8 @@ qla2xxx_flash_npiv_conf(scsi_qla_host_t 
 				qla_printk(KERN_INFO, ha,
 				"NPIV-Config: Failed to create vport [%02x]: "
 				"wwpn=%llx wwnn=%llx.\n", cnt,
-				vid.port_name, vid.node_name);
+				(unsigned long long)vid.port_name,
+				(unsigned long long)vid.node_name);
 		}
 	}
 done:
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix qla2xxx printk format warnings:

Thanks for the patch.

Quoted 8 lines

drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5) drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 6) drivers/scsi/qla2xxx/qla_sup.c:923: warning: long long unsigned int format, u64 arg (arg 5) drivers/scsi/qla2xxx/qla_sup.c:923: warning: long long unsigned int format, u64 arg (arg 6)

Quoted 28 lines

---
drivers/scsi/qla2xxx/qla_sup.c | 7 +++++--

1 file changed, 5 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_sup.c +5 -2
@@ -914,7 +914,9 @@ qla2xxx_flash_npiv_conf(scsi_qla_host_t
 
 		DEBUG2(qla_printk(KERN_DEBUG, ha, "NPIV[%02x]: wwpn=%llx "
 			"wwnn=%llx vf_id=0x%x Q_qos=0x%x F_qos=0x%x.\n", cnt,
-			vid.port_name, vid.node_name, le16_to_cpu(entry->vf_id),
+			(unsigned long long)vid.port_name,
+			(unsigned long long)vid.node_name,
+			le16_to_cpu(entry->vf_id),
 			entry->q_qos, entry->f_qos));
 
 		if (i < QLA_PRECONFIG_VPORTS) {
@@ -923,7 +925,8 @@ qla2xxx_flash_npiv_conf(scsi_qla_host_t
 				qla_printk(KERN_INFO, ha,
 				"NPIV-Config: Failed to create vport [%02x]: "
 				"wwpn=%llx wwnn=%llx.\n", cnt,
-				vid.port_name, vid.node_name);
+				(unsigned long long)vid.port_name,
+				(unsigned long long)vid.node_name);
 		}
 	}

done:

#2 lore raw
In reply to Randy Dunlap
Quoted 1 line · Randy Dunlap

drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5)

I thought we were going to fix all these by making u64 an unsigned long long on all 64-bit architectures? I know benh is working on it for powerpc, and I sent a patch to do it for ia64. Don't think Tony's merged it yet ...

Signature · 4 lines
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
#3 lore raw
Quoted 7 lines · On Wed, 18 Feb 2009 14:22:50 -0700 Matthew Wilcox <[email protected]> wrote:
Quoted 1 line · Randy Dunlap

drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5)

I thought we were going to fix all these by making u64 an unsigned long long on all 64-bit architectures? I know benh is working on it for powerpc, and I sent a patch to do it for ia64. Don't think Tony's merged it yet ...

Yes, we should do this. But momentum seems to have faded again.

#4 lore raw
Quoted 11 lines · Andrew Morton
Quoted 6 lines · On Wed, 18 Feb 2009 14:22:50 -0700 Matthew Wilcox <[email protected]> wrote:
Quoted 1 line · Randy Dunlap

drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5)

I thought we were going to fix all these by making u64 an unsigned long long on all 64-bit architectures? I know benh is working on it for powerpc, and I sent a patch to do it for ia64. Don't think Tony's merged it yet ...

Yes, we should do this. But momentum seems to have faded again.

OK. I can help with that then.

Signature · 1 line
~Randy