Skip to contentSkip to conversation

x86: use dev_printk in quirk message

PATCH In review Bjorn Helgaas 2 participants 2 messages Feb 18, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: use dev_printk in quirk message

This patch changes a VIA PCI quirk to use dev_info() rather than printk().

---
 arch/x86/kernel/pci-dma.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
arch/x86/kernel/pci-dma.c +1 -2
index b254285..022833b 100644
@@ -290,8 +290,7 @@ fs_initcall(pci_iommu_init);
 static __devinit void via_no_dac(struct pci_dev *dev)
 {
 	if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI && forbid_dac == 0) {
-		printk(KERN_INFO
-			"PCI: VIA PCI bridge detected. Disabling DAC.\n");
+		dev_info(&dev->dev, "disabling DAC on VIA PCI bridge\n");
 		forbid_dac = 1;
 	}
 }
#1 lore raw
Quoted 12 lines · Bjorn Helgaas

This patch changes a VIA PCI quirk to use dev_info() rather than printk().

---
 arch/x86/kernel/pci-dma.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
arch/x86/kernel/pci-dma.c +0 -0
index b254285..022833b 100644

arch/x86/kernel/pci-dma.c fs_initcall(pci_iommu_init); · line 296

Quoted 9 lines
arch/x86/kernel/pci-dma.c +1 -2
@@ -290,8 +290,7 @@ fs_initcall(pci_iommu_init);
 static __devinit void via_no_dac(struct pci_dev *dev)
 {
 	if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI && forbid_dac == 0) {
-		printk(KERN_INFO
-			"PCI: VIA PCI bridge detected. Disabling DAC.\n");
+		dev_info(&dev->dev, "disabling DAC on VIA PCI bridge\n");
 		forbid_dac = 1;
 	}
 }

that's one for Jesse i think - Cc:-ed him.

Ingo