Skip to contentSkip to conversation

Blackfin: bf537-stamp: fix I2C board defines

PATCH New Mike Frysinger 3 participants 6 messages Feb 19, 2009 – Feb 20, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Blackfin: bf537-stamp: fix I2C board defines

The previous merge for cleaning up the I2C driver incorrectly reverted the CFG_xxx rename for some of the I2C defines.

---
 include/configs/bf537-stamp.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/bf537-stamp.h +2 -2
index 27567fa..f6399a9 100644
@@ -308,8 +308,8 @@
  */
 #define CONFIG_HARD_I2C		1
 #define CONFIG_BFIN_TWI_I2C	1
-#define CFG_I2C_SPEED		50000
-#define CFG_I2C_SLAVE		0
+#define CONFIG_SYS_I2C_SPEED	50000
+#define CONFIG_SYS_I2C_SLAVE	0
 
 #define CONFIG_EBIU_SDRRC_VAL  0x306
 #define CONFIG_EBIU_SDGCTL_VAL 0x91114d
Signature · 1 line
1.6.1.3
#1 lore raw

PATCH 1/1 Blackfin: bf537-stamp: fix I2C board defines

Hello Mike,

Quoted 14 lines · Mike Frysinger

The previous merge for cleaning up the I2C driver incorrectly reverted the CFG_xxx rename for some of the I2C defines.

---
 include/configs/bf537-stamp.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/bf537-stamp.h +0 -0
index 27567fa..f6399a9 100644

include/configs/bf537-stamp.h line 315

Quoted 10 lines
include/configs/bf537-stamp.h +2 -2
@@ -308,8 +308,8 @@
  */
 #define CONFIG_HARD_I2C		1
 #define CONFIG_BFIN_TWI_I2C	1
-#define CFG_I2C_SPEED		50000
-#define CFG_I2C_SLAVE		0
+#define CONFIG_SYS_I2C_SPEED	50000
+#define CONFIG_SYS_I2C_SLAVE	0
 
 #define CONFIG_EBIU_SDRRC_VAL  0x306
 #define CONFIG_EBIU_SDGCTL_VAL 0x91114d

This go through your tree, right? If so you have my

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany 
#2 lore raw

PATCH 1/1 Blackfin: bf537-stamp: fix I2C board defines

Quoted 22 lines · On Thursday 19 February 2009 03:35:28 Heiko Schocher wrote:
Quoted 21 lines · Mike Frysinger

The previous merge for cleaning up the I2C driver incorrectly reverted the CFG_xxx rename for some of the I2C defines.

---
 include/configs/bf537-stamp.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/include/configs/bf537-stamp.h index 27567fa..f6399a9 100644

include/configs/bf537-stamp.h +2 -2
@@ -308,8 +308,8 @@
  */
 #define CONFIG_HARD_I2C		1
 #define CONFIG_BFIN_TWI_I2C	1
-#define CFG_I2C_SPEED		50000
-#define CFG_I2C_SLAVE		0
+#define CONFIG_SYS_I2C_SPEED	50000
+#define CONFIG_SYS_I2C_SLAVE	0
 
Quoted 6 lines

include/configs/bf537-stamp.h line 315

Quoted 2 lines
include/configs/bf537-stamp.h +0 -0
 #define CONFIG_EBIU_SDRRC_VAL  0x306
 #define CONFIG_EBIU_SDGCTL_VAL 0x91114d

This go through your tree, right? If so you have my

doesnt matter to me. if it doesnt get merged, i'll post a pull request. -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090219/96c9ba47/attachment.pgp

#3 lore raw

PATCH 1/1 Blackfin: bf537-stamp: fix I2C board defines

Dear Mike Frysinger,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 4 lines

This go through your tree, right? If so you have my

doesnt matter to me. if it doesnt get merged, i'll post a pull request.

Ummm... Heiko is the I2C custodian, so his "Acked-By:" (Heiko, that should have been an "Acked-By:", I think) is pretty important to you. You should not include this patc into your repo without Heiko's ACK...

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
NOTE: The  Most  Fundamental  Particles  in  This  Product  Are  Held
Together  by  a  "Gluing" Force About Which Little is Currently Known
and Whose Adhesive Power Can Therefore Not Be Permanently Guaranteed.
#4 lore raw

PATCH 1/1 Blackfin: bf537-stamp: fix I2C board defines

Quoted 11 lines · On Thursday 19 February 2009 15:08:33 Wolfgang Denk wrote:
Quoted 5 lines · In message Mike Frysinger
Quoted 3 lines

This go through your tree, right? If so you have my

doesnt matter to me. if it doesnt get merged, i'll post a pull request.

Ummm... Heiko is the I2C custodian, so his "Acked-By:" (Heiko, that should have been an "Acked-By:", I think) is pretty important to you. You should not include this patc into your repo without Heiko's ACK...

i wasnt talking about his tag, i was talking about him merging it through the i2c tree or me through the Blackfin tree
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090219/61952b88/attachment.pgp

#5 lore raw

PATCH 1/1 Blackfin: bf537-stamp: fix I2C board defines

In reply to Wolfgang Denk

Hello Wolfgang,

Quoted 10 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 3 lines

This go through your tree, right? If so you have my

doesnt matter to me. if it doesnt get merged, i'll post a pull request.

Ummm... Heiko is the I2C custodian, so his "Acked-By:" (Heiko, that should have been an "Acked-By:", I think) is pretty important to you. You should not include this patc into your repo without Heiko's ACK...

OK, I am learning. So I give this patch a

and this patch can go through the Blackfin tree now, right?

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany