b43: Add slot count compiletime assertion

PATCH New Michael Buesch 1 participant 1 message Feb 20, 2009 Networking drivers (wireless)

Share & tools

Michael Buesch

author

2009-02-20 11:25 UTC #0 lore raw

PATCH v2 1/1 b43: Add slot count compiletime assertion

This adds a compiletime assertion for a recently introduced assumption on the slot counts.
The tx header cache handling code assumes that the TX slot count can be divided evenly by the number of TX slots per frame.

Signed-off-by Michael Buesch <[email protected]>

---

Coded with a brown paper bad on the head.
Please queue on top of the DMA optimizations.

drivers/net/wireless/b43/dma.c +3 -0

Index: wireless-testing/drivers/net/wireless/b43/dma.c
===================================================================
@@ -839,12 +839,15 @@ struct b43_dmaring *b43_setup_dmaring(st
 	spin_lock_init(&ring->lock);
 #ifdef CONFIG_B43_DEBUG
 	ring->last_injected_overflow = jiffies;
 #endif
 
 	if (for_tx) {
+		/* Assumption: B43_TXRING_SLOTS can be divided by TX_SLOTS_PER_FRAME */
+		BUILD_BUG_ON(B43_TXRING_SLOTS % TX_SLOTS_PER_FRAME != 0);
+
 		ring->txhdr_cache = kcalloc(ring->nr_slots / TX_SLOTS_PER_FRAME,
 					    b43_txhdr_size(dev),
 					    GFP_KERNEL);
 		if (!ring->txhdr_cache)
 			goto err_kfree_meta;

Signature · 1 line

Greetings, Michael.