Skip to contentSkip to conversation

oqo: depends on INPUT_POLLDEV

PATCH In review Randy Dunlap 2 participants 2 messages Feb 20, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 oqo: depends on INPUT_POLLDEV

This patch (from 2009-feb-10) is still needed in today's linux-next.

Begin forwarded message:

Date: Tue, 10 Feb 2009 09:53:19 -0800
From: Randy Dunlap <[email protected]>
To: lkml <[email protected]>, akpm <[email protected]>
Cc: [email protected], Matthew Garrett <[email protected]>
Subject: [PATCH] oqo: depends on INPUT_POLLDEV

From: Randy Dunlap <[email protected]>

oqo driver uses polled input functions, so make it depend on INPUT_POLLDEV.

ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!

cc Matthew Garrett <[email protected]>
---
 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -137,7 +137,7 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT
+       depends on INPUT && INPUT_POLLDEV
        depends on RFKILL
        depends on BACKLIGHT_CLASS_DEVICE
        help
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

oqo driver uses polled input functions, so make it depend on INPUT_POLLDEV.

Quoted 7 lines

ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!

cc Matthew Garrett <[email protected]>

I've got a cleaned up version of this written now - I'll push it to Len later today.

Signature · 1 line
Matthew Garrett | [email protected]