Skip to contentSkip to conversation

MTP FUSION: resending patch to disable MSI interrupt by defualt.

PATCH In review Kashyap, Desai 2 participants 3 messages Feb 22, 2009 – Feb 23, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MTP FUSION: resending patch to disable MSI interrupt by defualt.

This Patch is submitted to with reference to MSI issue with some of LSI controller. Disabling it by default when module is loaded.
---

---

drivers/message/fusion/mptbase.c +2 -2
index 96ac883..ea3aafb 100644
@@ -91,9 +91,9 @@ MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \
 		controllers (default=0)");
 
 static int mpt_msi_enable_sas;
-module_param(mpt_msi_enable_sas, int, 1);
+module_param(mpt_msi_enable_sas, int, 0);
 MODULE_PARM_DESC(mpt_msi_enable_sas, " Enable MSI Support for SAS \
-		controllers (default=1)");
+		controllers (default=0)");
 
 
 static int mpt_channel_mapping;
maintainer
#1 lore raw
Quoted 2 lines · Desai

This Patch is submitted to with reference to MSI issue with some of LSI controller. Disabling it by default when module is loaded.

Point of order here: this is *not* a resend of a previous patch. This is a bug fix of a previously sent patch (With a change in intended behaviour).

drivers/message/fusion/mptbase.c MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \ · line 94

Quoted 12 lines

---

drivers/message/fusion/mptbase.c +1 -1
index 96ac883..ea3aafb 100644
@@ -91,9 +91,9 @@ MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \
 		controllers (default=0)");
 
 static int mpt_msi_enable_sas;
-module_param(mpt_msi_enable_sas, int, 1);
+module_param(mpt_msi_enable_sas, int, 0);

This is the actual bug fix, which isn't mentioned anywhere in the change log

drivers/message/fusion/mptbase.c MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \ · line 96

Quoted 3 lines
drivers/message/fusion/mptbase.c +1 -1
 MODULE_PARM_DESC(mpt_msi_enable_sas, " Enable MSI Support for SAS \
-		controllers (default=1)");
+		controllers (default=0)");

This entire patch is also functionally identical to the second patch in this email from Yinghai Lu:

http://marc.info/?l=linux-scsi&m=123498532419609

Open Source is a co-operative effort: The only thing you get at the end of the day is kudos for finding (and possibly fixing) a bug, so since Yinghai Lu did all the heavy lifting in this regard, I'll take this as an ack of his patch.

James

#2 lore raw

James,

Sorry for mail id problem. It is [email protected] I used alias instead of SMTP mail id. I will make sure I use SMTP mail id in future.

Patch by Yinghai at http://marc.info/?l=linux-scsi&m=123498532419609
and which I have sent is similar. It is ACK for Yinghai's patch.

Thanks
Kashyap

-----Original Message-----
From: James Bottomley [mailto:[email protected]]
Sent: Sunday, February 22, 2009 8:18 PM
To: Desai, Kashyap
Cc: [email protected]; Moore, Eric; Prakash, Sathya
Subject: Re: [PATCH] MTP FUSION: resending patch to disable MSI interrupt by defualt.

Quoted 2 lines · Desai

This Patch is submitted to with reference to MSI issue with some of LSI controller. Disabling it by default when module is loaded.

Point of order here: this is *not* a resend of a previous patch. This is a bug fix of a previously sent patch (With a change in intended behaviour).

drivers/message/fusion/mptbase.c MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \ · line 94

Quoted 12 lines

---

drivers/message/fusion/mptbase.c +1 -1
index 96ac883..ea3aafb 100644
@@ -91,9 +91,9 @@ MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \
 		controllers (default=0)");
 
 static int mpt_msi_enable_sas;
-module_param(mpt_msi_enable_sas, int, 1);
+module_param(mpt_msi_enable_sas, int, 0);

This is the actual bug fix, which isn't mentioned anywhere in the change log

drivers/message/fusion/mptbase.c MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \ · line 96

Quoted 3 lines
drivers/message/fusion/mptbase.c +1 -1
 MODULE_PARM_DESC(mpt_msi_enable_sas, " Enable MSI Support for SAS \
-		controllers (default=1)");
+		controllers (default=0)");

This entire patch is also functionally identical to the second patch in this email from Yinghai Lu:

http://marc.info/?l=linux-scsi&m=123498532419609

Open Source is a co-operative effort: The only thing you get at the end of the day is kudos for finding (and possibly fixing) a bug, so since Yinghai Lu did all the heavy lifting in this regard, I'll take this as an ack of his patch.

James

Internal Virus Database is out of date.
Checked by AVG - http://www.avg.com
Version: 8.0.233 / Virus Database: 270.6.6/1631 - Release Date: 8/24/2008 12:15 PM