Skip to contentSkip to conversation

fix tolower issue in xfsprogs

PATCH In review Mike Frysinger 2 participants 3 messages Feb 22, 2009 – Feb 23, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix tolower issue in xfsprogs

the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for the definition
-mike

xfs_dir2.c +1 -0
@@ -22,6 +22,7 @@
  */
 
 #include <xfs.h>
+#include <ctype.h>	/* for tolower() */
 
 extern const struct xfs_nameops xfs_default_nameops;
 

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 2 lines · Mike Frysinger

the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for the definition

In 3.0.0 and current git <ctype.h> is include in platform_defs.h, so it should also be around in xfs_dir2.c.

What xfsprogs tree and what glibc/gcc combination do you see this with?

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 8 lines · On Monday 23 February 2009 08:31:09 Christoph Hellwig wrote:
Quoted 2 lines · Mike Frysinger

the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for the definition

In 3.0.0 and current git <ctype.h> is include in platform_defs.h, so it should also be around in xfs_dir2.c.

What xfsprogs tree and what glibc/gcc combination do you see this with?

i forward ported it from the last version. i didnt expect it to be fixed in a different way ;). so disregard.
-mike

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs