Skip to contentSkip to conversation

mac80211: Give it some time to do the TSF sync

PATCH In review Alina Friedrichsen 2 participants 2 messages Feb 22, 2009 – Feb 23, 2009 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 mac80211: Give it some time to do the TSF sync

Give slow hardware some time to do the TSF sync, to not run into an IBS= S merging endless loop in some rarely situations.

Version 2 adds a comment.
Version 3: I had forgotten to change the bracket.
Version 4: No magic number.

---

net/mac80211/ibss.c +0 -0
index 1bbfc70..367d2cf 100644
@@ -29,6 +29,7 @@
 #define IEEE80211_IBSS_JOIN_TIMEOUT (7 * HZ)

=20
#define IEEE80211_IBSS_MERGE_INTERVAL (30 * HZ)
+#define IEEE80211_IBSS_MERGE_DELAY 0x400000
#define IEEE80211_IBSS_INACTIVITY_LIMIT (60 * HZ)
=20
#define IEEE80211_IBSS_MAX_STA_ENTRIES 128
@@ -332,6 +333,10 @@ static void ieee80211_rx_bss_info(struct ieee80211= _sub_if_data *sdata,
jiffies);
#endif
=20
+ /* give slow hardware some time to do the TSF sync */
+ if (rx_timestamp < IEEE80211_IBSS_MERGE_DELAY)
+ goto put_bss;
+
if (beacon_timestamp > rx_timestamp) {
#ifdef CONFIG_MAC80211_IBSS_DEBUG
printk(KERN_DEBUG "%s: beacon TSF higher than "

--=20
Psssst! Schon vom neuen GMX MultiMessenger geh=F6rt? Der kann`s mit all=
en: http://www.gmx.net/de/go/multimessenger01
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Reviewed-by on v3 1/1
#1 lore raw
Quoted 6 lines · Alina Friedrichsen

Give slow hardware some time to do the TSF sync, to not run into an IBSS merging endless loop in some rarely situations.

Version 2 adds a comment.
Version 3: I had forgotten to change the bracket.
Version 4: No magic number.

Much better now, thanks. In the future, please write the patch history...

Quoted 2 lines

---

... to here (ie after the '---' line) so that they are ignored when the patch applied. This is easier for John.

Disclaimer: I know very little about mac80211 ibss implementation :)

Signature · 1 line
Kalle Valo