Skip to contentSkip to conversation

fix missing brace in macaddr changes in u-boot.git/next in smc911x.c

PATCH New Mike Frysinger 2 participants 2 messages Feb 22, 2009 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix missing brace in macaddr changes in u-boot.git/next in smc911x.c

i was going through the macaddr patchset to see if there was something else i missed and noticed that the changes to smc911x are missing a brace.

you'll probably want to squash this into the changeset:

	lan91c96/smc91111/smc911x: get mac address from environment

-mike

drivers/net/smc911x.c +1 -1
@@ -437,7 +437,7 @@ static int smx911x_handle_mac_address(bd_t *bd)
 	uchar m[6];
 
 	/* if the environment has a valid mac address then use it */
-	if (!eth_getenv_enetaddr("ethaddr", m))
+	if (!eth_getenv_enetaddr("ethaddr", m)) {
 		/* if not, try to get one from the eeprom */
 		addrh = smc911x_get_mac_csr(ADDRH);
 		addrl = smc911x_get_mac_csr(ADDRL);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090222/8187aa49/attachment-0001.pgp

#1 lore raw

PATCH 1/1 fix missing brace in macaddr changes in u-boot.git/next in smc911x.c

Dear Mike Frysinger,

Quoted 3 lines · In message <[email protected]> you wrote:

i was going through the macaddr patchset to see if there was something else i missed and noticed that the changes to smc911x are missing a brace.

Ah. thanks for pointing out.

Quoted 2 lines

you'll probably want to squash this into the changeset:

	lan91c96/smc91111/smc911x: get mac address from environment

Will do exactly that.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something  done:  do  it  yourself,  hire
someone, or forbid your kids to do it.