mxc: move serial driver init()/exit() to platform_device
Subsystems (2)
RFC PATCH 2/3 mxc: move serial driver init()/exit() to platform_device
---
arch/arm/mach-mx1/devices.c | 43 ++++++++++++++ arch/arm/mach-mx1/mx1ads.c | 45 --------------- arch/arm/mach-mx2/mx27ads.c | 131 ------------------------------------------- arch/arm/mach-mx2/pcm038.c | 64 --------------------- arch/arm/mach-mx2/serial.c | 127 ++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 170 insertions(+), 240 deletions(-)
arch/arm/mach-mx1/devices.c +43 -0
@@ -26,6 +26,7 @@#include <mach/irqs.h> #include <mach/hardware.h> +#include <mach/iomux-mx1-mx2.h> static struct resource imx_csi_resources[] = { [0 ] = {
@@ -96,11 +97,32 @@ static struct resource imx_uart1_resources[] = { }, }; +static int mxc_uart1_pins[] = { +PC9_PF_UART1_CTS , +PC10_PF_UART1_RTS , +PC11_PF_UART1_TXD , +PC12_PF_UART1_RXD , +}; + +static int uart1_mxc_init (struct platform_device *pdev) +{ +return mxc_gpio_setup_multiple_pins (mxc_uart1_pins, +ARRAY_SIZE (mxc_uart1_pins),"UART1" ); +} + +static void uart1_mxc_exit (struct platform_device *pdev) +{ +mxc_gpio_release_multiple_pins (mxc_uart1_pins, +ARRAY_SIZE (mxc_uart1_pins)); +} +struct platform_device imx_uart1_device = { .name ="imx-uart" , .id =0 , .num_resources =ARRAY_SIZE (imx_uart1_resources), .resource = imx_uart1_resources, + .init = uart1_mxc_init, + .exit = uart1_mxc_exit, };static struct resource imx_uart2_resources[] = {
@@ -126,11 +148,32 @@ static struct resource imx_uart2_resources[] = { }, }; +static int mxc_uart2_pins[] = { +PB28_PF_UART2_CTS , +PB29_PF_UART2_RTS , +PB30_PF_UART2_TXD , +PB31_PF_UART2_RXD , +}; + +static int uart2_mxc_init (struct platform_device *pdev) +{ +return mxc_gpio_setup_multiple_pins (mxc_uart2_pins, +ARRAY_SIZE (mxc_uart2_pins),"UART2" ); +} + +static void uart2_mxc_exit (struct platform_device *pdev) +{ +mxc_gpio_release_multiple_pins (mxc_uart2_pins, +ARRAY_SIZE (mxc_uart2_pins)); +} +struct platform_device imx_uart2_device = { .name ="imx-uart" , .id =1 , .num_resources =ARRAY_SIZE (imx_uart2_resources), .resource = imx_uart2_resources, + .init = uart2_mxc_init, + .exit = uart2_mxc_exit, };static struct resource imx_rtc_resources[] = {
arch/arm/mach-mx1/mx1ads.c +0 -45
60 lines not on this page · raw message
arch/arm/mach-mx2/mx27ads.c +0 -131
153 lines not on this page · raw message
arch/arm/mach-mx2/pcm038.c +0 -64
76 lines not on this page · raw message
arch/arm/mach-mx2/serial.c +127 -0
197 lines not on this page · raw message
Quoted 43 lines · Paulius Zaleckas
Signed-off-by Paulius Zaleckas <[email protected]>---
arch/arm/mach-mx1/devices.c | 43 ++++++++++++++ arch/arm/mach-mx1/mx1ads.c | 45 --------------- arch/arm/mach-mx2/mx27ads.c | 131 ------------------------------------------- arch/arm/mach-mx2/pcm038.c | 64 --------------------- arch/arm/mach-mx2/serial.c | 127 ++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 170 insertions(+), 240 deletions(-)arch/arm/mach-mx1/devices.c +17
-0@@ -26,6 +26,7 @@#include <mach/irqs.h> #include <mach/hardware.h> +#include <mach/iomux-mx1-mx2.h> static struct resource imx_csi_resources[] = { [0 ] = {@@ -96,11 +97,32 @@ static struct resource imx_uart1_resources[] = { }, }; +static int mxc_uart1_pins[] = { +PC9_PF_UART1_CTS , +PC10_PF_UART1_RTS , +PC11_PF_UART1_TXD , +PC12_PF_UART1_RXD , +}; + +static int uart1_mxc_init (struct platform_device *pdev) +{ +return mxc_gpio_setup_multiple_pins (mxc_uart1_pins, +ARRAY_SIZE (mxc_uart1_pins),"UART1" ); +} + +static void uart1_mxc_exit (struct platform_device *pdev) +{ + mxc_gpio_release_multiple_pins(mxc_uart1_pins,
arch/arm/mach-mx1/devices.c static struct resource imx_uart1_resources[] = { · line 125
Quoted 10 lines
arch/arm/mach-mx1/devices.c +5
-0+ ARRAY_SIZE(mxc_uart1_pins)); +} +struct platform_device imx_uart1_device = { .name ="imx-uart" , .id =0 , .num_resources =ARRAY_SIZE (imx_uart1_resources), .resource = imx_uart1_resources, + .init = uart1_mxc_init, + .exit = uart1_mxc_exit,
I really don't like this approach to controlling multiplex pins, which is to setup the SoC pin configuration when the driver is being bound and to remove it when the driver is unbound.
Let's take the issue of a serial driver.
The outputs of a serial port have defined inactive levels - for TXD, RTS and DTR, that's logic one. If a driver is not loaded and you have a peripheral connected to this port, you probably don't want them to see a break level on TXD, or active RTS or DTR signal.
However, by hooking the SoC pin configuration into the binding and unbinding of the driver, the state of the pins are indeterminent until the driver is initialised.
I can think of other cases in hardware I've dealt with which required careful handling of SSP signals to ensure that a flip-flop in a FPGA is correctly set to ensure that left/right channels aren't swapped.
Basically, my point is that for 99.9% of the time, SoC pin configuration is determined by the platform board layout, and the right place to set this configuration up is in the board support file, just like we do on PXA platforms.
For the 0.1% of cases where a board needs to manipulate the SoC pin configuration depending on which drivers are loaded, doing so at driver probe time _may_ make sense, but it feels all together cumbersome, especially as unloading drivers has historically had question marks over it.
Surely, for this 0.1% of cases, the right solution would be to have an interface which allows a platform device to be unregistered, the SoC pin mux settings changed by platform code, and the new device registered?
Finally, note that the approach of putting init/exit into struct platform_device doesn't cater for all cases - we're still going to need to have init/exit pointers in platform data for some platform devices, such as MMC drivers, which have to pass parameters to those hooks.
Quoted 3 lines · Russell King - ARM Linux
I really don't like this approach to controlling multiplex pins, which is to setup the SoC pin configuration when the driver is being bound and to remove it when the driver is unbound.
What do you think about the reasoning given by Sascha here:
http://marc.info/?l=linux-arm-kernel&m=123453175927569&w=2 which is power saving?
Quoted 27 lines
Let's take the issue of a serial driver.
The outputs of a serial port have defined inactive levels - for TXD, RTS and DTR, that's logic one. If a driver is not loaded and you have a peripheral connected to this port, you probably don't want them to see a break level on TXD, or active RTS or DTR signal.
However, by hooking the SoC pin configuration into the binding and unbinding of the driver, the state of the pins are indeterminent until the driver is initialised.
I can think of other cases in hardware I've dealt with which required careful handling of SSP signals to ensure that a flip-flop in a FPGA is correctly set to ensure that left/right channels aren't swapped.
Basically, my point is that for 99.9% of the time, SoC pin configuration is determined by the platform board layout, and the right place to set this configuration up is in the board support file, just like we do on PXA platforms.
For the 0.1% of cases where a board needs to manipulate the SoC pin configuration depending on which drivers are loaded, doing so at driver probe time _may_ make sense, but it feels all together cumbersome, especially as unloading drivers has historically had question marks over it.
Quoted 8 lines
Surely, for this 0.1% of cases, the right solution would be to have an interface which allows a platform device to be unregistered, the SoC pin mux settings changed by platform code, and the new device registered?
Finally, note that the approach of putting init/exit into struct
platform_devicedoesn't cater for all cases - we're still going to need to have init/exit pointers in platform data for some platform devices, such as MMC drivers, which have to pass parameters to those hooks.
Thanks
Guennadi
---
Guennadi Liakhovetski
Quoted 9 lines · Guennadi Liakhovetski
Quoted 3 lines · Russell King - ARM Linux
I really don't like this approach to controlling multiplex pins, which is to setup the SoC pin configuration when the driver is being bound and to remove it when the driver is unbound.
What do you think about the reasoning given by Sascha here:
http://marc.info/?l=linux-arm-kernel&m=123453175927569&w=2 which is power saving?
That kind of power saving methodology is far better being triggered from the use of the driver, not whether it is loaded or not if and only if it is appropriate and necessary for the hardware.
For example, if you do this with a serial port which is connected to the external world, and you're monitoring it, you don't want your monitoring to see a break condition every time the port is closed and re-opened.
If you talk about an I2S codec, you'd want to configure the SoCs outputs to the codec to be logic 0 when powering it down because it isn't being used.
That's all unrelated to whether the driver is loaded or not, or bound to a device or not.
Quoted 70 lines · Russell King - ARM Linux
Quoted 43 lines · Paulius Zaleckas
Signed-off-by Paulius Zaleckas <[email protected]>---
arch/arm/mach-mx1/devices.c | 43 ++++++++++++++ arch/arm/mach-mx1/mx1ads.c | 45 --------------- arch/arm/mach-mx2/mx27ads.c | 131 ------------------------------------------- arch/arm/mach-mx2/pcm038.c | 64 --------------------- arch/arm/mach-mx2/serial.c | 127 ++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 170 insertions(+), 240 deletions(-)arch/arm/mach-mx1/devices.c +17
-0@@ -26,6 +26,7 @@#include <mach/irqs.h> #include <mach/hardware.h> +#include <mach/iomux-mx1-mx2.h> static struct resource imx_csi_resources[] = { [0 ] = {@@ -96,11 +97,32 @@ static struct resource imx_uart1_resources[] = { }, }; +static int mxc_uart1_pins[] = { +PC9_PF_UART1_CTS , +PC10_PF_UART1_RTS , +PC11_PF_UART1_TXD , +PC12_PF_UART1_RXD , +}; + +static int uart1_mxc_init (struct platform_device *pdev) +{ +return mxc_gpio_setup_multiple_pins (mxc_uart1_pins, +ARRAY_SIZE (mxc_uart1_pins),"UART1" ); +} + +static void uart1_mxc_exit (struct platform_device *pdev) +{ + mxc_gpio_release_multiple_pins(mxc_uart1_pins,arch/arm/mach-mx1/devices.c static struct resource imx_uart1_resources[] = { · line 125
Quoted 10 lines
arch/arm/mach-mx1/devices.c +5
-0+ ARRAY_SIZE(mxc_uart1_pins)); +} +struct platform_device imx_uart1_device = { .name ="imx-uart" , .id =0 , .num_resources =ARRAY_SIZE (imx_uart1_resources), .resource = imx_uart1_resources, + .init = uart1_mxc_init, + .exit = uart1_mxc_exit,I really don't like this approach to controlling multiplex pins, which is to setup the SoC pin configuration when the driver is being bound and to remove it when the driver is unbound.
Let's take the issue of a serial driver.
The outputs of a serial port have defined inactive levels - for TXD, RTS and DTR, that's logic one. If a driver is not loaded and you have a peripheral connected to this port, you probably don't want them to see a break level on TXD, or active RTS or DTR signal.
However, by hooking the SoC pin configuration into the binding and unbinding of the driver, the state of the pins are indeterminent until the driver is initialised.
Quoted 8 lines
I can think of other cases in hardware I've dealt with which required careful handling of SSP signals to ensure that a flip-flop in a FPGA is correctly set to ensure that left/right channels aren't swapped.
Basically, my point is that for 99.9% of the time, SoC pin configuration is determined by the platform board layout, and the right place to set this configuration up is in the board support file, just like we do on PXA platforms.
I see your point and have to agree with you.
After all that is why it was RFC!
It was quick idea by looking at MXC drivers and amount of platform_data with init()/exit()...
Now it seems for me, like this was just bad approach.
Thanks for comments!
Quoted 14 lines
For the 0.1% of cases where a board needs to manipulate the SoC pin configuration depending on which drivers are loaded, doing so at driver probe time _may_ make sense, but it feels all together cumbersome, especially as unloading drivers has historically had question marks over it.
Surely, for this 0.1% of cases, the right solution would be to have an interface which allows a platform device to be unregistered, the SoC pin mux settings changed by platform code, and the new device registered?
Finally, note that the approach of putting init/exit into struct
platform_devicedoesn't cater for all cases - we're still going to need to have init/exit pointers in platform data for some platform devices, such as MMC drivers, which have to pass parameters to those hooks.