make most exported headers use strict integer types
A message that is not in the archive (sent off-list or not yet received): [email protected]
At Thu, 26 Feb 2009 01:31:04 GMT,
Quoted 15 lines · Arnd Bergmann
include/sound/emu10k1.h +2
-0@@ -1,6 +1,8 @@#ifndef __SOUND_EMU10K1_H#define __SOUND_EMU10K1_H +#include <linux/types.h> +/* * Copyright (c) by Jaroslav Kysela <[email protected]>, * Creative Labs, Inc.
include/sound/emu10k1.h line 40
Quoted 5 lines
include/sound/emu10k1.h +2
-0@@ -34,6 +36,8 @@#include <sound/timer.h> #include <linux/interrupt.h> #include <linux/mutex.h> +#include <linux/types.h> +
Isn't the second inclusion superfluous?
thanks,
Takashi
PATCH 1/1 fix duplicate include in emu10k1.h
The earlier patch 'make most exported headers use strict integer types' accidentally includes <types.h> both from the common and from the kernel-only parts.
---
Quoted 9 lines · you
Review line 40
Quoted 6 lines
(quoted diff) +2
-0@@ -34,6 +36,8 @@ #include <sound/timer.h> #include <linux/interrupt.h> #include <linux/mutex.h> +#include <linux/types.h> +Isn't the second inclusion superfluous?
Yes, I must have introduced the second one first, but in the wrong section (kernel only), and then didn't notice it when introducing it again to fix headers_check.
include/sound/emu10k1.h +0 -1
@@ -36,7 +36,6 @@#include <sound/timer.h> #include <linux/interrupt.h> #include <linux/mutex.h> -#include <linux/types.h> #include <asm/io.h>
Re: [PATCH] fix duplicate include in emu10k1.h
At Thu, 26 Feb 2009 09:57:27 +0100,
Quoted 6 lines · Arnd Bergmann
The earlier patch 'make most exported headers use strict integer types' accidentally includes <
types.h> both from the common and from the kernel-only parts.Signed-off-by Arnd Bergmann <[email protected]>
To both patches (better merged, though),
Thanks!
Takashi
Quoted 28 lines
---
Quoted 9 lines · you
include/sound/emu10k1.h line 40
Quoted 6 lines
include/sound/emu10k1.h +2
-0@@ -34,6 +36,8 @@#include <sound/timer.h> #include <linux/interrupt.h> #include <linux/mutex.h> +#include <linux/types.h> +Isn't the second inclusion superfluous?
Yes, I must have introduced the second one first, but in the wrong section (kernel only), and then didn't notice it when introducing it again to fix
headers_check.include/sound/emu10k1.h +0
-1@@ -36,7 +36,6 @@#include <sound/timer.h> #include <linux/interrupt.h> #include <linux/mutex.h> -#include <linux/types.h> #include <asm/io.h>