net headers: export dcbnl.h
Subsystems (2)
PATCH 1/1 net headers: export dcbnl.h
The DCB netlink interface is required for building the userspace tools available at e1000.sourceforge.net
---
include/linux/Kbuild | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/Kbuild +1 -0
@@ -52,6 +52,7 @@ header-y += const.h header-y += cgroupstats.h header-y += cramfs_fs.h header-y += cycx_cfm.h +header-y += dcbnl.h header-y += dlmconstants.h header-y += dlm_device.h header-y += dlm_netlink.h
Quoted 2 lines · Chris Leech
The DCB netlink interface is required for building the userspace tools available at e1000.sourceforge.net
Hmmm, is that file ready for export....
Quoted 1 line
From
dcbnl.h:
#ifndef __LINUX_DCBNL_H__
#define __LINUX_DCBNL_H__
#define DCB_PROTO_VERSION 1
struct dcbmsg {
unsigned char dcb_family;
__u8 cmd;
__u16 dcb_pad;
};1) It uses __u8/__u16 so it would be nice it is included <linux/types.h> so these are actually defined.
2) Why does it use "unsigned char" for one member and __u8 for another. It looks inconsistent.
We export headers that are much worse but we better raise the bar a little.
Sam
Quoted 25 lines
Signed-off-by Chris Leech <[email protected]>---
include/linux/Kbuild | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/linux/Kbuild +1
-1@@ -52,6 +52,7 @@ header-y += const.h header-y += cgroupstats.h header-y += cramfs_fs.h header-y += cycx_cfm.h +header-y += dcbnl.h header-y += dlmconstants.h header-y += dlm_device.h header-y += dlm_netlink.h --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
David Miller
maintainerFrom: Sam Ravnborg <[email protected]>
Date: Fri, 27 Feb 2009 06:55:06 +0100
Quoted 18 lines · Chris Leech
Quoted 2 lines
The DCB netlink interface is required for building the userspace tools available at e1000.sourceforge.net
Hmmm, is that file ready for export....
Quoted 1 line
From
dcbnl.h:#ifndef
__LINUX_DCBNL_H__
#define__LINUX_DCBNL_H__#define
DCB_PROTO_VERSION1struct dcbmsg { unsigned char dcb_family; __u8 cmd; __u16 dcb_pad; };
Quoted 6 lines
1) It uses __u8/__u16 so it would be nice it is included <
linux/types.h> so these are actually defined.
2) Why does it use "unsigned char" for one member and__u8for another. It looks inconsistent.We export headers that are much worse but we better raise the bar a little.
Agreed, we should sort out these issues before exporting.
Quoted 23 lines · David Miller
From: Sam Ravnborg <[email protected]>
Date: Fri, 27 Feb 2009 06:55:06 +0100Quoted 20 lines · Chris Leech
Quoted 2 lines
The DCB netlink interface is required for building the userspace tools available at e1000.sourceforge.net
Hmmm, is that file ready for export....
Quoted 1 line
From
dcbnl.h:#ifndef
__LINUX_DCBNL_H__
#define__LINUX_DCBNL_H__#define
DCB_PROTO_VERSION1struct dcbmsg { unsigned char dcb_family; __u8 cmd; __u16 dcb_pad; };1) It uses __u8/__u16 so it would be nice it is included <
linux/types.h> so these are actually defined.
OK, I'll send again with a patch to add <linux/types.h>
Quoted 2 lines
Quoted 2 lines
2) Why does it use "unsigned char" for one member and
__u8for another. It looks inconsistent.
My guess is that the first member was made to be unsigned char to match struct rtgenmsg, but other rtnetlink users define family as __u8 (fib_rule_hdr, ndmsg, ndtmsg) so it should be OK to change it.
Quoted 3 lines
Quoted 1 line
We export headers that are much worse but we better raise the bar a little.
Agreed, we should sort out these issues before exporting.