Command line parameter not passed to module in linux-next
The linux-next kernel does not pass charp parameters from the kernel command line to modules:
# cat /proc/cmdline dasd=4d70-4d73 root=/dev/dasdc1 zfcp.device=0.0.181d,0x500507630310c562,0x401040C300000000 zfcp.dbfsize=4096 BOOT_IMAGE=0
# cat /sys/module/zfcp/parameters/device <NULL>
It seems that this patches introduces the problem:
commit 9f229de63cf02297c0e0fbaa8d74b962cceff435 Author: Rusty Russell <[email protected]> Date: Fri Feb 20 10:31:19 2009 +1100 param:fix-charp-sysfs-write
Reverting the patch on linux-next fixes the problem:
# cat /sys/module/zfcp/parameters/device 0.0.181d,0x500507630310c562,0x401040C300000000
--
Christof Schmitt
Quoted 8 lines · On Saturday 28 February 2009 03:31:05 Christof Schmitt wrote:
The linux-next kernel does not pass charp parameters from the kernel command line to modules:
# cat /proc/cmdline dasd=4d70-4d73 root=/dev/dasdc1 zfcp.device=0.0.181d,0x500507630310c562,0x401040C300000000 zfcp.dbfsize=4096 BOOT_IMAGE=0# cat /sys/module/zfcp/parameters/device <NULL>
Thanks:
param: fix charp parameters set via sysfs: FIX
We can't kmalloc at early cmdline parsing.
kernel/params.c +10 -4
@@ -223,10 +223,16 @@ int param_set_charp(const char *val, strif (kp->perm &KPARAM_KMALLOCED )kfree (*(char **)kp->arg); - kp->perm |=KPARAM_KMALLOCED ; - *(char **)kp->arg =kstrdup (val,GFP_KERNEL ); -if (!kp->arg) -return -ENOMEM ; +/* This is a hack. We can't need to strdup in early boot, and we +* don't need to; this mangled commandline is preserved. */ +if (slab_is_available ()) { + kp->perm |=KPARAM_KMALLOCED ; + *(char **)kp->arg =kstrdup (val,GFP_KERNEL ); +if (!kp->arg) +return -ENOMEM ; + }else + *(const char **)kp->arg = val; +return 0 ; }
Christof Schmitt
Tested-byRusty Russell <[email protected]> wrote on 03/02/2009 01:45:23 AM:
Quoted 33 lines · On Saturday 28 February 2009 03:31:05 Christof Schmitt wrote:
Quoted 5 lines
The linux-next kernel does not pass charp parameters from the kernel command line to modules:
# cat /proc/cmdline dasd=4d70-4d73 root=/dev/dasdc1 zfcp.device=0.0.181d,0x500507630310c562,0x401040C300000000 zfcp.dbfsize=4096 BOOT_IMAGE=0
Quoted 3 lines
# cat /sys/module/zfcp/parameters/device <NULL>Thanks:
param: fix charp parameters set via sysfs: FIX
We can't kmalloc at early cmdline parsing.
Reported-by Christof Schmitt <[email protected]>Signed-off-by Rusty Russell <[email protected]>kernel/params.c +2
-4@@ -223,10 +223,16 @@ int param_set_charp(const char *val, strif (kp->perm &KPARAM_KMALLOCED )kfree (*(char **)kp->arg); - kp->perm |=KPARAM_KMALLOCED ; - *(char **)kp->arg =kstrdup (val,GFP_KERNEL ); -if (!kp->arg) -return -ENOMEM ; +/* This is a hack. We can't need to strdup in early boot, and we +* don't need to; this mangled commandline is preserved. */
kernel/params.c int param_set_charp(const char *val, str · line 237
Quoted 10 lines
kernel/params.c +8
-0+if (slab_is_available ()) { + kp->perm |=KPARAM_KMALLOCED ; + *(char **)kp->arg =kstrdup (val,GFP_KERNEL ); +if (!kp->arg) +return -ENOMEM ; + }else + *(const char **)kp->arg = val; +return 0 ; }
Thanks, the patch works for me.
--
Christof Schmitt