Skip to contentSkip to conversation

Fix correct reset value for ARM CP15 c1 auxiliary control register

PATCH Applied Riku Voipio 3 participants 3 messages Feb 27, 2009 – Mar 7, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Fix correct reset value for ARM CP15 c1 auxiliary control register

From: Juha Riihimäki <[email protected]>

According to ARM Cortex A8 Technical Reference Manual, the reset value for CP15 c1 auxiliary control register is 2, not zero (page 3.12).

---
 target-arm/helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
target-arm/helper.c +1 -1
index 3250fb8..883f8ee 100644
@@ -1694,7 +1694,7 @@ uint32_t HELPER(get_cp15)(CPUState *env, uint32_t insn)
             case ARM_CPUID_ARM11MPCORE:
                 return 1;
             case ARM_CPUID_CORTEXA8:
-                return 0;
+                return 2;
             default:
                 goto bad_reg;
             }
Signature · 5 lines
1.6.1.3


-- 
"rm -rf" only sounds scary if you don't have backups
Acked-by on v1 1/3
#1 lore raw
Quoted 4 lines · Riku Voipio

From: Juha Riihimäki <[email protected]>

According to ARM Cortex A8 Technical Reference Manual, the reset value for CP15 c1 auxiliary control register is 2, not zero (page 3.12).

Out of curiosity does that change anything for your tests?

Laurent

Quoted 27 lines
---
 target-arm/helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
target-arm/helper.c +1 -2
index 3250fb8..883f8ee 100644
@@ -1694,7 +1694,7 @@ uint32_t HELPER(get_cp15)(CPUState *env, uint32_t insn)
            case ARM_CPUID_ARM11MPCORE:
                return 1;
            case ARM_CPUID_CORTEXA8:
-                return 0;
+                return 2;
            default:
                goto bad_reg;
            }
--

1.6.1.3

--
"rm -rf" only sounds scary if you don't have backups