Skip to contentSkip to conversation

experimental patch for toshiba_acpi

DISCUSSION Andrey Borzenkov 2 participants 6 messages Feb 27, 2009 – Mar 1, 2009 ACPI

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines

This patch comes from http://memebeam.org/free-software/toshiba_acpi/.
With this patch, the module conflicts with the toshiba module (which works only on non-acpi-enabled kernels).

Could you please elaborate? Because (Portege 4000):

{pts/2}% lsmod | grep tosh

toshiba                 4012  0
toshiba_acpi            7540  0
rfkill                 10480  1 toshiba_acpi
backlight               4560  2 toshiba_acpi,video
input_polldev           4012  1 toshiba_acpi

{pts/2}% sudo fan
Fan is on.

So I have ACPI enabled kernel and toshiba seems to work in parallel with toshiba_acpi.

Are there specific models for which this does not work?

#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Andrey--

Quoted 6 lines
Quoted 3 lines

This patch comes from http://memebeam.org/free-software/toshiba_acpi/.
With this patch, the module conflicts with the toshiba module (which works only on non-acpi-enabled kernels).

Could you please elaborate? Because (Portege 4000):

Quoted 9 lines

{pts/2}% lsmod | grep tosh

toshiba                 4012  0
toshiba_acpi            7540  0
rfkill                 10480  1 toshiba_acpi
backlight               4560  2 toshiba_acpi,video
input_polldev           4012  1 toshiba_acpi

{pts/2}% sudo fan
Fan is on.

My understanding is that with the experimental patch, both toshiba and toshiba_acpi use /dev/toshiba. Do you have the experimental patch applied? Does fan work if you remove the toshiba module?

Charles
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ <http://mailcrypt.sourceforge.net/>

iD8DBQFJqFvPPK2zrJwS/lYRApaPAJwK7jbkxT070MBKm+TyWI9/gEO89wCfS4sy iukYMH2E2g9UiQ2EB+YIaAE=
=AFBQ
-----END PGP SIGNATURE-----

#2 lore raw
Quoted 18 lines · On 28 февраля 2009 00:31:59 [email protected] wrote:

Hello Andrey--

Quoted 7 lines
Quoted 4 lines

This patch comes from
http://memebeam.org/free-software/toshiba_acpi/. With this patch, the module conflicts with the toshiba module (which works only on non-acpi-enabled kernels).

Could you please elaborate? Because (Portege 4000):

Quoted 8 lines

{pts/2}% lsmod | grep tosh

toshiba                 4012  0
toshiba_acpi            7540  0
rfkill                 10480  1 toshiba_acpi
backlight               4560  2 toshiba_acpi,video
input_polldev           4012  1 toshiba_acpi

{pts/2}% sudo fan
Fan is on.

Quoted 4 lines

My understanding is that with the experimental patch, both toshiba and toshiba_acpi use /dev/toshiba. Do you have the experimental patch applied? Does fan work if you remove the toshiba module?

May be I misunderstood you then; do you mean that *if* this patch is applied module toshiba works on non-ACPI kernels only? That would be the case then.

But then I do not understand why you need this in toshiba_acpi in the first place. We already have in-kernel module (toshiba) that provides raw user space HCI access to those who need it. Why is it necessary to duplicate this functionality in toshiba_acpi in the first place?

#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 19 lines · Andrey Borzenkov
Quoted 18 lines · On 28 ??????? 2009 00:31:59 [email protected] wrote:

Hello Andrey--

Quoted 15 lines
Quoted 4 lines

This patch comes from
http://memebeam.org/free-software/toshiba_acpi/. With this patch, the module conflicts with the toshiba module (which works only on non-acpi-enabled kernels).

Could you please elaborate? Because (Portege 4000):

{pts/2}% lsmod | grep tosh

toshiba                 4012  0
toshiba_acpi            7540  0
rfkill                 10480  1 toshiba_acpi
backlight               4560  2 toshiba_acpi,video
input_polldev           4012  1 toshiba_acpi

{pts/2}% sudo fan
Fan is on.

Quoted 8 lines
Quoted 4 lines

My understanding is that with the experimental patch, both toshiba and toshiba_acpi use /dev/toshiba. Do you have the experimental patch applied? Does fan work if you remove the toshiba module?

May be I misunderstood you then; do you mean that *if* this patch is applied module toshiba works on non-ACPI kernels only? That would be the case then.

that's right.

Quoted 5 lines

But then I do not understand why you need this in toshiba_acpi in the first place. We already have in-kernel module (toshiba) that provides raw user space HCI access to those who need it. Why is it necessary to duplicate this functionality in toshiba_acpi in the first place?

I did have reports of some machines like yours. This is the result on a portege r100 (with unpatched toshiba_acpi:

% lsmod | grep tosh

toshiba_acpi            5336  0 
toshiba                 4152  0 

% fan
fan: laptop does not have cooling fan or kernel module not installed.

Behavior on most machines (and all three of mine) seems to be the same.

Charles
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ <http://mailcrypt.sourceforge.net/>

iD8DBQFJqXu6PK2zrJwS/lYRArFkAJ4mUzyCekXST4fIKn3Uhw2srNdcdACZAVSo Pis83ewju56RXMqPUdv+A0M=
=KU7l
-----END PGP SIGNATURE-----

#4 lore raw
Quoted 10 lines · On 28 февраля 2009 21:00:26 [email protected] wrote:
Quoted 6 lines

But then I do not understand why you need this in toshiba_acpi in the first place. We already have in-kernel module (toshiba) that provides raw user space HCI access to those who need it. Why is it necessary to duplicate this functionality in toshiba_acpi in the first place?

I did have reports of some machines like yours. This is the result on a portege r100 (with unpatched toshiba_acpi:

Quoted 9 lines

% lsmod | grep tosh

toshiba_acpi            5336  0
toshiba                 4152  0

% fan
fan: laptop does not have cooling fan or kernel module not installed.

Behavior on most machines (and all three of mine) seems to be the same.

Sorry for dumb question but are you doing it as root?

#5 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 17 lines · Andrey Borzenkov
Quoted 16 lines · On 28 ??????? 2009 21:00:26 [email protected] wrote:
Quoted 6 lines

But then I do not understand why you need this in toshiba_acpi in the first place. We already have in-kernel module (toshiba) that provides raw user space HCI access to those who need it. Why is it necessary to duplicate this functionality in toshiba_acpi in the first place?

I did have reports of some machines like yours. This is the result on a portege r100 (with unpatched toshiba_acpi:

% lsmod | grep tosh

toshiba_acpi            5336  0
toshiba                 4152  0

% fan
fan: laptop does not have cooling fan or kernel module not installed.

Quoted 5 lines
Quoted 3 lines

Behavior on most machines (and all three of mine) seems to be the same.

Sorry for dumb question but are you doing it as root?

actually, I get the same result whether running root or not.

Charles
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ <http://mailcrypt.sourceforge.net/>

iD8DBQFJqmPrPK2zrJwS/lYRAu38AJ9+NmkjhTr/AZH7HMZ6wthlPrnVSACcD9TU zVBe/SjEYAZLlRpsoXDrbNA=
=HrY/
-----END PGP SIGNATURE-----