Skip to contentSkip to conversation

tracing: remove unused code

PATCH In review Luis Henriques 4 participants 5 messages Feb 27, 2009 – Feb 28, 2009 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: remove unused code

struct file_operations tracing_lt_fops and tracing_lt_open are not used anywhere. These are legacy from the /debug/tracing/latency_trace, which has been removed in commit 886b5b73d71e4027d7dc6c14f5f7ab102201ea6b

---
 kernel/trace/trace.c |   22 ----------------------
 1 files changed, 0 insertions(+), 22 deletions(-)
kernel/trace/trace.c +0 -22
index 5db7485..04306a1 100644
@@ -1822,21 +1822,6 @@ static int tracing_open(struct inode *inode, struct file *file)
 	return ret;
 }
 
-static int tracing_lt_open(struct inode *inode, struct file *file)
-{
-	struct trace_iterator *iter;
-	int ret = 0;
-
-	iter = __tracing_open(inode, file);
-
-	if (IS_ERR(iter))
-		ret = PTR_ERR(iter);
-	else
-		iter->iter_flags |= TRACE_FILE_LAT_FMT;
-
-	return ret;
-}
-
 
 static void *
 t_next(struct seq_file *m, void *v, loff_t *pos)
@@ -1916,13 +1901,6 @@ static struct file_operations tracing_fops = {
 	.release	= tracing_release,
 };
 
-static struct file_operations tracing_lt_fops = {
-	.open		= tracing_lt_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= tracing_release,
-};
-
 static struct file_operations show_traces_fops = {
 	.open		= show_traces_open,
 	.read		= seq_read,
Signature · 1 line
1.6.1.3
maintainer
#1 lore raw

Thanks Luis,

But before I remove this code, I want to move it to be activated by tracing options. The irqsoff tracer (and other latency tracers) are pretty useless without it.

-- Steve

Quoted 53 lines · Luis Henriques

struct file_operations tracing_lt_fops and tracing_lt_open are not used anywhere. These are legacy from the /debug/tracing/latency_trace, which has been removed in commit 886b5b73d71e4027d7dc6c14f5f7ab102201ea6b

---
 kernel/trace/trace.c |   22 ----------------------
 1 files changed, 0 insertions(+), 22 deletions(-)
kernel/trace/trace.c +0 -22
index 5db7485..04306a1 100644
@@ -1822,21 +1822,6 @@ static int tracing_open(struct inode *inode, struct file *file)
 	return ret;
 }
 
-static int tracing_lt_open(struct inode *inode, struct file *file)
-{
-	struct trace_iterator *iter;
-	int ret = 0;
-
-	iter = __tracing_open(inode, file);
-
-	if (IS_ERR(iter))
-		ret = PTR_ERR(iter);
-	else
-		iter->iter_flags |= TRACE_FILE_LAT_FMT;
-
-	return ret;
-}
-
 
 static void *
 t_next(struct seq_file *m, void *v, loff_t *pos)
@@ -1916,13 +1901,6 @@ static struct file_operations tracing_fops = {
 	.release	= tracing_release,
 };
 
-static struct file_operations tracing_lt_fops = {
-	.open		= tracing_lt_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= tracing_release,
-};
-
 static struct file_operations show_traces_fops = {
 	.open		= show_traces_open,
 	.read		= seq_read,
Signature · 1 line
1.6.1.3
#2 lore raw
Quoted 5 lines · Steven Rostedt

Thanks Luis,

But before I remove this code, I want to move it to be activated by tracing options. The irqsoff tracer (and other latency tracers) are pretty useless without it.

sounds good.

Ingo

#3 lore raw
Quoted 10 lines · Ingo Molnar
Quoted 5 lines · Steven Rostedt

Thanks Luis,

But before I remove this code, I want to move it to be activated by tracing options. The irqsoff tracer (and other latency tracers) are pretty useless without it.

sounds good.

Ok, understood. I am sorry for the noise introduced by this patch... I should have got some more context before submitting it -- I am really not that familiar with this code and tried just to remove a compile warning without fully understand the whole picture :-)

Signature · 1 line
Luis Henriques
#4 lore raw
Quoted 10 lines · Luis Henriques
Quoted 9 lines · Ingo Molnar
Quoted 5 lines · Steven Rostedt

Thanks Luis,

But before I remove this code, I want to move it to be activated by tracing options. The irqsoff tracer (and other latency tracers) are pretty useless without it.

Quoted 6 lines
Quoted 1 line

sounds good.

Ok, understood. I am sorry for the noise introduced by this patch... I should have got some more context before submitting it -- I am really not that familiar with this code and tried just to remove a compile warning without fully understand the whole picture :-)

Don't be sorry, the fix was right.
But nobody can be aware of all background history in a subsystem, unless one read all tracing related posts but it is very active these time so it can be a little pain for a newcomer.

Quoted 7 lines
Signature · 6 lines
Luis Henriques
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/