Skip to contentSkip to conversation

: ixgbe: Fix some compiler warnings.

PATCH In review David Miller 2 participants 2 messages Mar 2, 2009

Subsystems (2)
lore
Share & tools
lore

David Miller

author maintainer
#0 lore raw

PATCH 1/1 : ixgbe: Fix some compiler warnings.

[ Commited to net-next-2.6 ]

'pap' is never used in ixgbe_dcb_hw_config_82599() and 'eec' in ixgbe_acquire_eeptom() is only used when status == 0 but GCC has some trouble seeing that.

---
 drivers/net/ixgbe/ixgbe_common.c    |    2 +-
 drivers/net/ixgbe/ixgbe_dcb_82599.c |    2 --
 2 files changed, 1 insertions(+), 3 deletions(-)
drivers/net/ixgbe/ixgbe_common.c +1 -1
index 26ee8a0..245db0e 100644
@@ -661,7 +661,7 @@ static s32 ixgbe_poll_eeprom_eerd_done(struct ixgbe_hw *hw)
 static s32 ixgbe_acquire_eeprom(struct ixgbe_hw *hw)
 {
 	s32 status = 0;
-	u32 eec;
+	u32 eec = 0;
 	u32 i;
 
 	if (ixgbe_acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) != 0)
drivers/net/ixgbe/ixgbe_dcb_82599.c +0 -2
index 1467d56..adcbac4 100644
@@ -457,8 +457,6 @@ s32 ixgbe_dcb_config_82599(struct ixgbe_hw *hw)
 s32 ixgbe_dcb_hw_config_82599(struct ixgbe_hw *hw,
                               struct ixgbe_dcb_config *dcb_config)
 {
-	u32  pap = 0;
-
 	ixgbe_dcb_config_packet_buffers_82599(hw, dcb_config);
 	ixgbe_dcb_config_82599(hw);
 	ixgbe_dcb_config_rx_arbiter_82599(hw, dcb_config);
Signature · 1 line
1.6.1.2.253.ga34a
#1 lore raw
Quoted 14 lines · David Miller
drivers/net/ixgbe/ixgbe_common.c +1 -1
@@ -661,7 +661,7 @@ static s32 ixgbe_poll_eeprom_eerd_done(struct ixgbe_hw *hw)
 static s32 ixgbe_acquire_eeprom(struct ixgbe_hw *hw)
 {
        s32 status = 0;
-       u32 eec;
+       u32 eec = 0;
        u32 i;
 
        if (ixgbe_acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) != 0)
drivers/net/ixgbe/ixgbe_dcb_82599.c +0 -0
index 1467d56..adcbac4 100644

drivers/net/ixgbe/ixgbe_dcb_82599.c s32 ixgbe_dcb_config_82599(struct ixgbe_hw *hw) · line 461

Quoted 5 lines
drivers/net/ixgbe/ixgbe_dcb_82599.c +0 -2
@@ -457,8 +457,6 @@ s32 ixgbe_dcb_config_82599(struct ixgbe_hw *hw)
 s32 ixgbe_dcb_hw_config_82599(struct ixgbe_hw *hw,
                               struct ixgbe_dcb_config *dcb_config)
 {
-       u32  pap = 0;
-

Thanks Dave. We removed the code that used pap since it was used only for silicon validation, but we forgot to pull the variable.

Thanks for cleaning these up!

Cheers,
-PJ Waskiewicz