Skip to contentSkip to conversation

Fix SND_OMAP_SOC_MCBSP=m undefined symbols

RFC PATCH In review George G. Davis 2 participants 3 messages Feb 27, 2009 – Mar 2, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 Fix SND_OMAP_SOC_MCBSP=m undefined symbols

When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based targets, the build fails because omap_ctrl_{read,write}l lack exports. So add the missing exports for omap_ctrl_{read,write}[bwl] to allow building these ASoC (and other) drivers as modules.

arch/arm/mach-omap2/control.c +6 -0
index 5f3aad9..6b14639 100644
@@ -36,29 +36,35 @@ u8 omap_ctrl_readb(u16 offset)
 {
 	return __raw_readb(OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_readb);
 
 u16 omap_ctrl_readw(u16 offset)
 {
 	return __raw_readw(OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_readw);
 
 u32 omap_ctrl_readl(u16 offset)
 {
 	return __raw_readl(OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_readl);
 
 void omap_ctrl_writeb(u8 val, u16 offset)
 {
 	__raw_writeb(val, OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_writeb);
 
 void omap_ctrl_writew(u16 val, u16 offset)
 {
 	__raw_writew(val, OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_writew);
 
 void omap_ctrl_writel(u32 val, u16 offset)
 {
 	__raw_writel(val, OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_writel);
 
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Fri, 27 Feb 2009 18:33:39 +0100 "ext George G. Davis" <[email protected]>…

When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based targets, the build fails because omap_ctrl_{read,write}l lack exports. So add the missing exports for omap_ctrl_{read,write}[bwl] to allow building these ASoC (and other) drivers as modules.

Thanks! CONFIG_SND_OMAP_SOC_N810=m works fine. And which indicates that I haven't tested to compile them as modules...

I would use "ARM: OMAP2: Fix missing system control module exports" or something as a subject. But otherwise fine to me.

#2 lore raw

Hi,

Quoted 9 lines · Jarkko Nikula
Quoted 6 lines · On Fri, 27 Feb 2009 18:33:39 +0100 "ext George G. Davis" <[email protected]>…

When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based targets, the build fails because omap_ctrl_{read,write}l lack exports. So add the missing exports for omap_ctrl_{read,write}[bwl] to allow building these ASoC (and other) drivers as modules.

Quoted 7 lines
Quoted 2 lines

Thanks! CONFIG_SND_OMAP_SOC_N810=m works fine. And which indicates that I haven't tested to compile them as modules...

I would use "ARM: OMAP2: Fix missing system control module exports" or something as a subject. But otherwise fine to me.

Ok, thanks!

Quoted 2 lines

Added, thanks!

--
Regards,
George