Skip to contentSkip to conversation

: Get cob-webs out of sparc64-ieee1275.rmk

PATCH In review David Miller 3 participants 5 messages Mar 4, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 7/7 : Get cob-webs out of sparc64-ieee1275.rmk

There is no way anyone tried to build the sparc target in years :-) This updates sparc64-ieee1275.rmk with modern times and regenerates sparc64-ieee1275.mk as well as DISTLIST.

2009-03-03 David S. Miller <[email protected]>

* conf/sparc64-ieee1275.rmk: Update.
* conf/sparc64-ieee1275.mk: Rebuilt.
* DISTLIST: Rebuilt.

---
 DISTLIST                  |    8 +-
 conf/sparc64-ieee1275.mk  | 1927 +++++++++------------------------------------
 conf/sparc64-ieee1275.rmk |  295 ++-----
 3 files changed, 451 insertions(+), 1779 deletions(-)
DISTLIST +6 -2
index 3c8bd34..4acbc01 100644
@@ -61,7 +61,6 @@ commands/read.c
 commands/reboot.c
 commands/search.c
 commands/sleep.c
-commands/terminal.c
 commands/test.c
 commands/usbtest.c
 commands/videotest.c
@@ -284,6 +283,7 @@ include/grub/powerpc/ieee1275/machine.h
 include/grub/powerpc/ieee1275/memory.h
 include/grub/powerpc/ieee1275/time.h
 include/grub/powerpc/ieee1275/util/biosdisk.h
+include/grub/sparc64/kernel.h
 include/grub/sparc64/libgcc.h
 include/grub/sparc64/setjmp.h
 include/grub/sparc64/time.h
@@ -291,7 +291,9 @@ include/grub/sparc64/types.h
 include/grub/sparc64/ieee1275/console.h
 include/grub/sparc64/ieee1275/ieee1275.h
 include/grub/sparc64/ieee1275/kernel.h
+include/grub/sparc64/ieee1275/loader.h
 include/grub/sparc64/ieee1275/machine.h
+include/grub/sparc64/ieee1275/memory.h
 include/grub/sparc64/ieee1275/time.h
 include/grub/util/getroot.h
 include/grub/util/hostdisk.h
@@ -365,7 +367,7 @@ kern/powerpc/dl.c
 kern/powerpc/ieee1275/startup.S
 kern/sparc64/cache.S
 kern/sparc64/dl.c
-kern/sparc64/ieee1275/init.c
+kern/sparc64/ieee1275/crt0.S
 kern/sparc64/ieee1275/openfw.c
 kern/x86_64/dl.c
 kern/x86_64/efi/callwrap.S
@@ -402,6 +404,8 @@ loader/i386/pc/multiboot_normal.c
 loader/ieee1275/multiboot2.c
 loader/powerpc/ieee1275/linux.c
 loader/powerpc/ieee1275/linux_normal.c
+loader/sparc64/ieee1275/linux.c
+loader/sparc64/ieee1275/linux_normal.c
 normal/arg.c
 normal/cmdline.c
 normal/color.c
conf/sparc64-ieee1275.mk +359 -1568

2,133 lines not on this page · raw message

conf/sparc64-ieee1275.rmk +86 -209

335 lines not on this page · raw message

Signature · 1 line
1.6.1.2.253.ga34a
#1 lore raw
Quoted 10 lines · David Miller

There is no way anyone tried to build the sparc target in years :-) This updates sparc64-ieee1275.rmk with modern times and regenerates sparc64-ieee1275.mk as well as DISTLIST.

2009-03-03 David S. Miller <[email protected]>

* conf/sparc64-ieee1275.rmk: Update.
* conf/sparc64-ieee1275.mk: Rebuilt.
* DISTLIST: Rebuilt.

There is no need to include .mk files in patches. They just make it a bit chaotic.

Please make sure to sync in example normal.mod to be exactly how x86 is. This way that is much easier to maintain.

Please compare those to each other and look that they match as much as possible. If you see it sensible to differentiate common arch stuff to own file like in:

i386-pc.rmk
i386.rmk
common.rmk

Then please do so.

#2 lore raw

From: Vesa Jääskeläinen <[email protected]>
Date: Wed, 04 Mar 2009 13:50:37 +0200

Quoted 6 lines
Quoted 5 lines · David Miller

There is no way anyone tried to build the sparc target in years :-) This updates sparc64-ieee1275.rmk with modern times and regenerates sparc64-ieee1275.mk as well as DISTLIST.

Quoted 8 lines
Quoted 5 lines

2009-03-03 David S. Miller <[email protected]>

* conf/sparc64-ieee1275.rmk: Update.
* conf/sparc64-ieee1275.mk: Rebuilt.
* DISTLIST: Rebuilt.

There is no need to include .mk files in patches. They just make it a bit chaotic.

Ok, I won't include them in the future.

Quoted 7 lines

Please make sure to sync in example normal.mod to be exactly how x86 is. This way that is much easier to maintain.

Please compare those to each other and look that they match as much as possible. If you see it sensible to differentiate common arch stuff to own file like in:

Quoted 5 lines

i386-pc.rmk
i386.rmk
common.rmk

Then please do so.

I will work on commonization as much as possible as I do more sparc grub work.

Are you going to apply my patches or do I have to rewrite everything?

#3 lore raw
Quoted 2 lines · David Miller

Are you going to apply my patches or do I have to rewrite everything?

Personally I have nothing against resurrecting sparc support :)

Lets see what kind of other comments they generate...

#4 lore raw
In reply to David Miller

Le Wednesday 04 March 2009 03:15:39 David Miller, vous avez écrit :

Quoted 2 lines

There is no way anyone tried to build the sparc target in years :-)

Literaly years. More than 3 I think.
I gave it a try ~2 1/2 years ago, and started writing a patch... And gave up. Thanks a lot for taking care of this. I had a very fun time discovering sparc64 as I wrote it, and I stopped before making anything usable. I hope you won't find too much bad code (sorry about that cache flush).

I guess I'll fire up my good ol' ultra 10 to celebrate this :) .

Signature · 1 line
Vincent Pelletier