Skip to contentSkip to conversation

Fix for nfs-utils tools build

PATCH In review Khem Raj 3 participants 3 messages Mar 4, 2009

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 Fix for nfs-utils tools build

Hi

Currently nfs-utils 1.1.2 does not build correctly. The reason is that there are certain tools which are passed in CFLAGS in their makefiles even though they are to be build using host compiler for them to be run on host machine.

Current builds use target headers to build them due to CFLAGS funkiness where we have alters system include dirs. This goes ok with arm and x86 but on mips you see errors.

This patch fixes the issue

OK for .dev

Thx

-Khem

tools/Makefile.am +4 -1
Index: nfs-utils-1.1.2/tools/Makefile.am
===================================================================
@@ -5,7 +5,10 @@
 if CONFIG_RPCGEN
 OPTDIRS += rpcgen
 endif
-
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 SUBDIRS = locktest rpcdebug nlmtest $(OPTDIRS)
 
 MAINTAINERCLEANFILES = Makefile.in
tools/locktest/Makefile.am +4 -3
Index: nfs-utils-1.1.2/tools/locktest/Makefile.am
===================================================================
@@ -1,12 +1,13 @@
 ## Process this file with automake to produce Makefile.in
 
 CC=$(CC_FOR_BUILD)
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 LIBTOOL = @LIBTOOL@ --tag=CC
 
 noinst_PROGRAMS = testlk
 testlk_SOURCES = testlk.c
-testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
-testlk_CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
-testlk_LDFLAGS=$(LDFLAGS_FOR_BUILD)
 
 MAINTAINERCLEANFILES = Makefile.in
tools/nlmtest/Makefile.am +4 -1
Index: nfs-utils-1.1.2/tools/nlmtest/Makefile.am
===================================================================
@@ -1,5 +1,8 @@
 ## Process this file with automake to produce Makefile.in
-
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 EXTRA_DIST = \
 	README \
 	host.h \
tools/rpcgen/Makefile.am +4 -4
Index: nfs-utils-1.1.2/tools/rpcgen/Makefile.am
===================================================================
@@ -1,6 +1,10 @@
 ## Process this file with automake to produce Makefile.in
 
 CC=$(CC_FOR_BUILD)
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 LIBTOOL = @LIBTOOL@ --tag=CC
 
 noinst_PROGRAMS = rpcgen
@@ -9,10 +13,6 @@
 		 rpc_util.c rpc_sample.c rpc_output.h rpc_parse.h \
 		 rpc_scan.h rpc_util.h
 
-rpcgen_CFLAGS=$(CFLAGS_FOR_BUILD)
-rpcgen_CPPLAGS=$(CPPFLAGS_FOR_BUILD)
-rpcgen_LDFLAGS=$(LDFLAGS_FOR_BUILD)
-
 MAINTAINERCLEANFILES = Makefile.in
 
 EXTRA_DIST = rpcgen.new.1
tools/rpcdebug/Makefile.am +4 -0
Index: nfs-utils-1.1.2/tools/rpcdebug/Makefile.am
===================================================================
@@ -1,6 +1,10 @@
 ## Process this file with automake to produce Makefile.in
 
 CC=$(CC_FOR_BUILD)
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 LIBTOOL = @LIBTOOL@ --tag=CC
 
 man8_MANS = rpcdebug.man
#1 lore raw
Quoted 10 lines · Khem Raj

Hi

Currently nfs-utils 1.1.2 does not build correctly. The reason is that there are certain tools which are passed in CFLAGS in their makefiles even though they are to be build using host compiler for them to be run on host machine.

Current builds use target headers to build them due to CFLAGS funkiness where we have alters system include dirs. This goes ok with arm and x86 but on mips you see errors.

I can trigger this on arm as well, FWIW.

Quoted 3 lines

This patch fixes the issue

OK for .dev

Yes :)

regards,

Koen

#2 lore raw
In reply to Khem Raj

That's what I was going to send to ML now. Voting for this patch.

Quoted 27 lines · Khem Raj

Hi

Currently nfs-utils 1.1.2 does not build correctly. The reason is that there are certain tools which are passed in CFLAGS in their makefiles even though they are to be build using host compiler for them to be run on host machine.

Current builds use target headers to build them due to CFLAGS funkiness where we have alters system include dirs. This goes ok with arm and x86 but on mips you see errors.

This patch fixes the issue

OK for .dev

Thx

-Khem

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel