Skip to contentSkip to conversation

Typo in lnbp21.c / changeset: 10800:ba740eb2348e

PATCH In review Matthias Schwarzott 3 participants 4 messages Mar 4, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Typo in lnbp21.c / changeset: 10800:ba740eb2348e

Hi there!

lnbp21 does show strange messages at depmod.

WARNING: Loop detected: /lib/modules/2.6.28-tuxonice-r1/v4l/lnbp21.ko which needs lnbp21.ko again!
WARNING: Module /lib/modules/2.6.28-tuxonice-r1/v4l/lnbp21.ko ignored, due to loop

So I had a look at latest change and noticed there was a typo in the function name, it should be lnbh24_attach, and not lnbp24_attach I guess. The attached patch fixes this.

Regards
Matthias

linux/drivers/media/dvb/frontends/lnbp21.c +1 -1
diff -r 8ebe62795b47 linux/drivers/media/dvb/frontends/lnbp21.c
@@ -138,7 +138,7 @@
 	return fe;
 }
 
-struct dvb_frontend *lnbp24_attach(struct dvb_frontend *fe,
+struct dvb_frontend *lnbh24_attach(struct dvb_frontend *fe,
 				struct i2c_adapter *i2c, u8 override_set,
 				u8 override_clear, u8 i2c_addr)
 {
#1 lore raw
Quoted 9 lines · On 4 марта 2009, [email protected] wrote:

Hi there!

lnbp21 does show strange messages at depmod.

WARNING: Loop detected: /lib/modules/2.6.28-tuxonice-r1/v4l/lnbp21.ko which needs lnbp21.ko again!
WARNING: Module /lib/modules/2.6.28-tuxonice-r1/v4l/lnbp21.ko ignored, due to loop

Quoted 6 lines

So I had a look at latest change and noticed there was a typo in the function name, it should be lnbh24_attach, and not lnbp24_attach I guess. The attached patch fixes this.

Regards
Matthias

Hi Matthias
Yes, You are right.
What an unfortunate misprint and lack of attention from my side :( I confirm your patch.

Mauro, please apply this patch.

Best Regards
Igor

#2 lore raw
Quoted 14 lines · On Wed, 4 Mar 2009 14:40:33 +0200 "Igor M. Liplianin" <[email protected]> wrote:
Quoted 13 lines · On 4 марта 2009, [email protected] wrote:

Hi there!

lnbp21 does show strange messages at depmod.

WARNING: Loop detected: /lib/modules/2.6.28-tuxonice-r1/v4l/lnbp21.ko which needs lnbp21.ko again!
WARNING: Module /lib/modules/2.6.28-tuxonice-r1/v4l/lnbp21.ko ignored, due to loop

So I had a look at latest change and noticed there was a typo in the function name, it should be lnbh24_attach, and not lnbp24_attach I guess. The attached patch fixes this.

Quoted 8 lines
Quoted 2 lines

Regards
Matthias

Hi Matthias
Yes, You are right.
What an unfortunate misprint and lack of attention from my side :( I confirm your patch.

Mauro, please apply this patch.

You forgot to attach the patch.

Quoted 3 lines

Best Regards
Igor

Cheers,
Mauro

#3 lore raw

В сообщении от 4 March 2009 15:02:44 Mauro Carvalho Chehab написал(а):

Quoted 32 lines

On Wed, 4 Mar 2009 14:40:33 +0200

Quoted 17 lines · Igor M. Liplianin
Quoted 9 lines · On 4 п╪п╟я─я┌п╟ 2009, [email protected] wrote:

Hi there!

lnbp21 does show strange messages at depmod.

WARNING: Loop detected: /lib/modules/2.6.28-tuxonice-r1/v4l/lnbp21.ko which needs lnbp21.ko again!
WARNING: Module /lib/modules/2.6.28-tuxonice-r1/v4l/lnbp21.ko ignored, due to loop

Quoted 6 lines

So I had a look at latest change and noticed there was a typo in the function name, it should be lnbh24_attach, and not lnbp24_attach I guess. The attached patch fixes this.

Regards
Matthias

Quoted 6 lines

Hi Matthias
Yes, You are right.
What an unfortunate misprint and lack of attention from my side :( I confirm your patch.

Mauro, please apply this patch.

You forgot to attach the patch.

Quoted 2 lines

Best Regards
Igor

Quoted 6 lines

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Mauro,

That was correct pull request to fix typo.

Please pull from http://udev.netup.ru/hg/v4l-dvb-netup

for the following changeset:

01/01: Fix typo in lnbp21.c
http://udev.netup.ru/hg/v4l-dvb-netup?cmd=changeset;node=19f5b50ab3d6

 lnbp21.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Igor