Skip to contentSkip to conversation

sfc: modify allocation error message

PATCH In review [email protected] 2 participants 2 messages Mar 4, 2009 – Mar 5, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sfc: modify allocation error message

From: Mike Travis <[email protected]>

Change error message when alloc_cpumask_var fails.

---

 drivers/net/sfc/efx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/sfc/efx.c renamed from drivers/net/sfc/efx.c~sfc-modify-allocation-error-message +2 -2
diff -puN drivers/net/sfc/efx.c~sfc-modify-allocation-error-message drivers/net/sfc/efx.c
@@ -857,9 +857,9 @@ static int efx_wanted_rx_queues(void)
 	int count;
 	int cpu;
 
-	if (!alloc_cpumask_var(&core_mask, GFP_KERNEL)) {
+	if (unlikely(!alloc_cpumask_var(&core_mask, GFP_KERNEL))) {
 		printk(KERN_WARNING
-		       "efx.c: allocation failure, irq balancing hobbled\n");
+		       "sfc: RSS disabled due to allocation failure\n");
 		return 1;
 	}
 

_

maintainer
#1 lore raw

From: [email protected]
Date: Wed, 04 Mar 2009 12:03:10 -0800

Quoted 8 lines

From: Mike Travis <[email protected]>

Change error message when alloc_cpumask_var fails.

Yes, please get this into the tree where it applies and is necessary, which as a reminder is not the networking tree :-)