Skip to contentSkip to conversation

libata: add CFA specific identify data words

PATCH In review Jeff Garzik 2 participants 2 messages Mar 5, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libata: add CFA specific identify data words

From: Sergei Shtylyov <[email protected]>

Declare and use constants for CFA specific identify data words 162 and 163.

---
Sergei said:
This patch is against the current pata-2.6 series. I'd prefer that Bart merged it thru his tree as my next patch adding CF mode support to IDE depends on it.

jgarzik adds:
I didn't see this in your latest submission, Bart. It is simple and harmless and might as well go ahead upstream, to eliminate the cross-tree dependency that Sergei speaks of (his patch also touched drivers/ata/libata-core.c, but I excluded that from below).

 include/linux/ata.h       |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/ata.h +2 -0
Index: linux-2.6/include/linux/ata.h
===================================================================
@@ -89,6 +89,8 @@ enum {
 	ATA_ID_DLF		= 128,
 	ATA_ID_CSFO		= 129,
 	ATA_ID_CFA_POWER	= 160,
+	ATA_ID_CFA_KEY_MGMT	= 162,
+	ATA_ID_CFA_MODES	= 163,
 	ATA_ID_ROT_SPEED	= 217,
 	ATA_ID_PIO4		= (1 << 1),
 
#1 lore raw
Quoted 7 lines · Jeff Garzik

From: Sergei Shtylyov <[email protected]>

Declare and use constants for CFA specific identify data words 162 and 163.

Quoted 7 lines

---
Sergei said:
This patch is against the current pata-2.6 series. I'd prefer that Bart merged it thru his tree as my next patch adding CF mode support to IDE depends on it.

jgarzik adds:
I didn't see this in your latest submission, Bart. It is simple and

Simply because I haven't yet got to those patches + Sergei mentioned that they need to be tested yet.

Quoted 3 lines

harmless and might as well go ahead upstream, to eliminate the cross-tree dependency that Sergei speaks of (his patch also touched drivers/ata/libata-core.c, but I excluded that from below).

Fine with me if this makes things easier for everyone.

I updated git pull request with this patch fixing patch summary (this is not libata specific change) and patch description (constants are not currently unused) while at it.

From: Sergei Shtylyov <[email protected]>
Subject: [PATCH] ata: add CFA specific identify data words

Declare CFA specific identify data words 162 and 163 for future use.

[bart: update patch summary/description]
---
 include/linux/ata.h       |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/ata.h +2 -0
Index: linux-2.6/include/linux/ata.h
===================================================================
@@ -89,6 +89,8 @@ enum {
 	ATA_ID_DLF		= 128,
 	ATA_ID_CSFO		= 129,
 	ATA_ID_CFA_POWER	= 160,
+	ATA_ID_CFA_KEY_MGMT	= 162,
+	ATA_ID_CFA_MODES	= 163,
 	ATA_ID_ROT_SPEED	= 217,
 	ATA_ID_PIO4		= (1 << 1),