Skip to contentSkip to conversation

ide-iops: fix odd-length ATAPI PIO transfers

PATCH Applied Sergei Shtylyov 2 participants 2 messages Mar 5, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide-iops: fix odd-length ATAPI PIO transfers

Commit 9567b349f7e7dd7e2483db99ee8e4a6fe0caca38 (ide: merge ->atapi_*put_bytes and ->ata_*put_data methods) introduced a regression WRT the odd-length ATAPI PIO transfers -- the final word didn't get written (causing command timeouts).

---
This patch is against the recent Linus' tree...

 drivers/ide/ide-iops.c |    2 ++
 1 files changed, 2 insertions(+)
drivers/ide/ide-iops.c +2 -0
Index: linux-2.6/drivers/ide/ide-iops.c
===================================================================
@@ -315,6 +315,8 @@ void ide_output_data(ide_drive_t *drive,
 	u8 io_32bit = drive->io_32bit;
 	u8 mmio = (hwif->host_flags & IDE_HFLAG_MMIO) ? 1 : 0;
 
+	len++;
+
 	if (io_32bit) {
 		unsigned long uninitialized_var(flags);
 
#1 lore raw
Quoted 5 lines · Sergei Shtylyov

Commit 9567b349f7e7dd7e2483db99ee8e4a6fe0caca38 (ide: merge ->atapi_*put_bytes and ->ata_*put_data methods) introduced a regression WRT the odd-length ATAPI PIO transfers -- the final word didn't get written (causing command timeouts).

applied, thanks!