Skip to contentSkip to conversation

p54: completely ignore rx'd frames with bad FCS

PATCH In review Christian Lamparter 1 participant 1 message Mar 5, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/7 p54: completely ignore rx'd frames with bad FCS

Passing frames with a bad FCS to the user is an optional feature. However it doesn't work reliable and strangely not in the native monitor mode?!

---
John, this patch series is > 2.6.31+ material.
There's no hurry.
---

drivers/net/wireless/p54/p54common.c +2 -7
diff -Nurp a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c
@@ -735,10 +735,7 @@ static int p54_rx_data(struct ieee80211_
 		return 0;
 
 	if (!(hdr->flags & cpu_to_le16(P54_HDR_FLAG_DATA_IN_FCS_GOOD))) {
-		if (priv->filter_flags & FIF_FCSFAIL)
-			rx_status.flag |= RX_FLAG_FAILED_FCS_CRC;
-		else
-			return 0;
+		return 0;
 	}
 
 	if (hdr->decrypt_status == P54_DECRYPT_OK)
@@ -2211,9 +2208,7 @@ static void p54_configure_filter(struct 
 	struct p54_common *priv = dev->priv;
 
 	*total_flags &= FIF_PROMISC_IN_BSS |
-			FIF_OTHER_BSS |
-			(*total_flags & FIF_PROMISC_IN_BSS ?
-				FIF_FCSFAIL : 0);
+			FIF_OTHER_BSS;
 
 	priv->filter_flags = *total_flags;