p54: fix iwconfig txpower off
PATCH 5/7 p54: fix iwconfig txpower off
Disabling the receiver logic with P54_FILTER_TYPE_RX_DISABLED is not supported by all firmwares. However we have an alternative: hibernation. And the only side effect - so far - is a bit less power consumption. WIN!
Signed-off-by Christian Lamparter <[email protected]>
---
drivers/net/wireless/p54/p54common.c +2 -2
@@ -1674,7 +1674,7 @@ static int p54_setup_mac(struct ieee8021 mode =P54_FILTER_TYPE_PROMISCUOUS ;break ;default : - mode =P54_FILTER_TYPE_NONE ; + mode =P54_FILTER_TYPE_HIBERNATE ;break ; }
@@ -1687,7 +1687,7 @@ static int p54_setup_mac(struct ieee8021 (mode != P54_FILTER_TYPE_PROMISCUOUS)) mode |=P54_FILTER_TYPE_TRANSPARENT ; }else - mode =P54_FILTER_TYPE_RX_DISABLED ; + mode =P54_FILTER_TYPE_HIBERNATE ; setup->mac_mode =cpu_to_le16 (mode);memcpy (setup->mac_addr, priv->mac_addr,ETH_ALEN );
Quoted 3 lines · Christian Lamparter
Disabling the receiver logic with
P54_FILTER_TYPE_RX_DISABLEDis not supported by all firmwares. However we have an alternative: hibernation. And the only side effect - so far - is a bit less power consumption. WIN!
Some stlc45xx firmware versions had problems in waking up from hibernation, but I think they were fixed at some point. Just a heads up.
Signature · 1 line
Kalle Valo