Skip to contentSkip to conversation

au1xxx-ide: auide_{in|out}sw() should be static

PATCH RESEND Applied Sergei Shtylyov 2 participants 2 messages Mar 6, 2009 – Mar 7, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 au1xxx-ide: auide_{in|out}sw() should be static

Make auide_{insw|outsw}() 'static' and mark them 'inline' as there's only one call site for each: in the driver's {in|out}put_data() methods respectively...

---
Resending with typo in the summary fixed. This patch is against the recent pata-2.6 series...

 drivers/ide/au1xxx-ide.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/ide/au1xxx-ide.c +2 -2
Index: linux-2.6/drivers/ide/au1xxx-ide.c
===================================================================
@@ -50,7 +50,7 @@ static _auide_hwif auide_hwif;
 
 #if defined(CONFIG_BLK_DEV_IDE_AU1XXX_PIO_DBDMA)
 
-void auide_insw(unsigned long port, void *addr, u32 count)
+static inline void auide_insw(unsigned long port, void *addr, u32 count)
 {
 	_auide_hwif *ahwif = &auide_hwif;
 	chan_tab_t *ctp;
@@ -68,7 +68,7 @@ void auide_insw(unsigned long port, void
 	ctp->cur_ptr = au1xxx_ddma_get_nextptr_virt(dp);
 }
 
-void auide_outsw(unsigned long port, void *addr, u32 count)
+static inline void auide_outsw(unsigned long port, void *addr, u32 count)
 {
 	_auide_hwif *ahwif = &auide_hwif;
 	chan_tab_t *ctp;