Skip to contentSkip to conversation

powerpc/5200: remove sysfs debug file from GPT driver

PATCH In review Grant Likely 2 participants 3 messages Mar 6, 2009 – Mar 7, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/5200: remove sysfs debug file from GPT driver

From: Grant Likely <[email protected]>

Remove poorly designed debug sysfs attribute entry from the GPT driver.

---

 arch/powerpc/platforms/52xx/mpc52xx_gpt.c |   39 -----------------------------
 1 files changed, 0 insertions(+), 39 deletions(-)
arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -39
index cb038dc..bfbcd41 100644
@@ -335,44 +335,6 @@ static void
 mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_priv *p, struct device_node *np) { }
 #endif /* defined(CONFIG_GPIOLIB) */
 
-/***********************************************************************
- * SYSFS attributes
- */
-#if defined(CONFIG_SYSFS)
-static ssize_t mpc52xx_gpt_show_regs(struct device *dev,
-				     struct device_attribute *attr, char *buf)
-{
-	struct mpc52xx_gpt_priv *gpt = dev_get_drvdata(dev);
-	int i, len = 0;
-	u32 __iomem *regs = (void __iomem *) gpt->regs;
-
-	for (i = 0; i < 4; i++)
-		len += sprintf(buf + len, "%.8x ", in_be32(regs + i));
-	len += sprintf(buf + len, "\n");
-
-	return len;
-}
-
-static struct device_attribute mpc52xx_gpt_attrib[] = {
-	__ATTR(regs, S_IRUGO | S_IWUSR, mpc52xx_gpt_show_regs, NULL),
-};
-
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt)
-{
-	int i, err = 0;
-
-	for (i = 0; i < ARRAY_SIZE(mpc52xx_gpt_attrib); i++) {
-		err = device_create_file(gpt->dev, &mpc52xx_gpt_attrib[i]);
-		if (err)
-			dev_err(gpt->dev, "error creating attribute %i\n", i);
-	}
-
-}
-
-#else /* defined(CONFIG_SYSFS) */
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *) { return 0; }
-#endif /* defined(CONFIG_SYSFS) */
-
 /* ---------------------------------------------------------------------
  * of_platform bus binding code
  */
@@ -395,7 +357,6 @@ static int __devinit mpc52xx_gpt_probe(struct of_device *ofdev,
 
 	dev_set_drvdata(&ofdev->dev, gpt);
 
-	mpc52xx_gpt_create_attribs(gpt);
 	mpc52xx_gpt_gpio_setup(gpt, ofdev->node);
 	mpc52xx_gpt_irq_setup(gpt, ofdev->node);
 
#1 lore raw

Wolfram, you were right. This was a bad idea. I just took me a bit longer to clue into it.

g.

On Fri, Mar 6, 2009 at 1:30 PM, Grant Likely <[email protected]> wr= ote:

Quoted 8 lines

From: Grant Likely <[email protected]>

Remove poorly designed debug sysfs attribute entry from the GPT driver.

---

=A0arch/powerpc/platforms/52xx/mpc52xx_gpt.c | =A0 39 -------------------=

----------

arch/powerpc/pla=

Quoted 4 lines

=A01 files changed, 0 insertions(+), 39 deletions(-)

arch/powerpc/pla= renamed from arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -0

tforms/52xx/mpc52xx_gpt.c

Quoted 5 lines

index cb038dc..bfbcd41 100644

arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -0
@@ -335,44 +335,6 @@ static void

=A0mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_priv *p, struct device_node =

*np) { }

arch/powerpc/platforms/52xx/mpc52xx_gpt.c static void

Quoted 8 lines

=A0#endif /* defined(CONFIG_GPIOLIB) */

arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -6
-/***********************************************************************
- * SYSFS attributes
- */
-#if defined(CONFIG_SYSFS)
-static ssize_t mpc52xx_gpt_show_regs(struct device *dev,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=

struct device_attribute *attr, char *buf)

arch/powerpc/platforms/52xx/mpc52xx_gpt.c

Quoted 7 lines
arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -7
-{
- =A0 =A0 =A0 struct mpc52xx_gpt_priv *gpt =3D dev_get_drvdata(dev);
- =A0 =A0 =A0 int i, len =3D 0;
- =A0 =A0 =A0 u32 __iomem *regs =3D (void __iomem *) gpt->regs;
-
- =A0 =A0 =A0 for (i =3D 0; i < 4; i++)
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 len +=3D sprintf(buf + len, "%.8x ", in_be3=

2(regs + i));

arch/powerpc/platforms/52xx/mpc52xx_gpt.c static void

Quoted 7 lines

- =A0 =A0 =A0 len +=3D sprintf(buf + len, "\n");

arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -6
-
- =A0 =A0 =A0 return len;
-}
-
-static struct device_attribute mpc52xx_gpt_attrib[] =3D {
- =A0 =A0 =A0 __ATTR(regs, S_IRUGO | S_IWUSR, mpc52xx_gpt_show_regs, NULL=

),

arch/powerpc/platforms/52xx/mpc52xx_gpt.c static void

Quoted 8 lines
arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -8
-};
-
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt)
-{
- =A0 =A0 =A0 int i, err =3D 0;
-
- =A0 =A0 =A0 for (i =3D 0; i < ARRAY_SIZE(mpc52xx_gpt_attrib); i++) {
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 err =3D device_create_file(gpt->dev, &mpc52=

xx_gpt_attrib[i]);

Quoted 2 lines

- =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (err)
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 dev_err(gpt->dev, "error cr=

eating attribute %i\n", i);

arch/powerpc/platforms/52xx/mpc52xx_gpt.c static void

Quoted 6 lines

- =A0 =A0 =A0 }

arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -5
-
-}
-
-#else /* defined(CONFIG_SYSFS) */
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *) { retu=

rn 0; }

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -2
-#endif /* defined(CONFIG_SYSFS) */
-

=A0/* -------------------------------------------------------------------=

--

arch/powerpc/platforms/52xx/mpc52xx_gpt.c static int __devinit mpc52xx_gpt_probe(struct of_devi=

Quoted 3 lines

=A0* of_platform bus binding code
=A0*/

arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -0
@@ -395,7 +357,6 @@ static int __devinit mpc52xx_gpt_probe(struct of_devi=

ce *ofdev,

arch/powerpc/platforms/52xx/mpc52xx_gpt.c static int __devinit mpc52xx_gpt_probe(struct of_devi= · line 362

Quoted 9 lines
arch/powerpc/platforms/52xx/mpc52xx_gpt.c +0 -1
 =A0 =A0 =A0 =A0dev_set_drvdata(&ofdev->dev, gpt);
 
- =A0 =A0 =A0 mpc52xx_gpt_create_attribs(gpt);
 =A0 =A0 =A0 =A0mpc52xx_gpt_gpio_setup(gpt, ofdev->node);
 =A0 =A0 =A0 =A0mpc52xx_gpt_irq_setup(gpt, ofdev->node);
 
 

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Acked-by
#2 lore raw
Quoted 2 lines · Grant Likely

Wolfram, you were right. This was a bad idea. I just took me a bit longer to clue into it.

Instant ACK :D Thanks!

Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |