generic debug pagealloc (-v2)
Subsystems (8)
PATCH 1/1 generic debug pagealloc (-v2)
CONFIG_DEBUG_PAGEALLOC is now supported by x86, powerpc, sparc (64bit), and s390. This patch implements it for the rest of the architectures by filling the pages with poison byte patterns after free_pages() and verifying the poison patterns before alloc_pages().
This generic one cannot detect invalid read accesses and it can only detect invalid write accesses after a long delay. But it is a feasible way for nommu architectures.
* v2
- Skip poisoning for highmem pages
- Romove duplidate poison pattern checking
--- arch/avr32/mm/fault.c | 18 ---------- arch/powerpc/Kconfig | 3 + arch/powerpc/Kconfig.debug | 1 arch/s390/Kconfig | 3 + arch/s390/Kconfig.debug | 1 arch/sparc/Kconfig | 3 + arch/sparc/Kconfig.debug | 3 + arch/x86/Kconfig | 3 + arch/x86/Kconfig.debug | 1 include/linux/mm_types.h | 4 ++ include/linux/poison.h | 3 + lib/Kconfig.debug | 1 mm/Kconfig.debug | 8 ++++ mm/Makefile | 1 mm/debug-pagealloc.c | 74 +++++++++++++++++++++++++++++++++++++++++++++ 15 files changed, 108 insertions(+), 19 deletions(-)
include/linux/poison.h +3 -0
@@ -17,6 +17,9 @@*/ #define TIMER_ENTRY_STATIC ((void *) 0x74737461) +/********** mm/debug-pagealloc.c **********/ +#define PAGE_POISON 0xaa +/********** mm/slab.c **********/ /* * Magic nums for obj red zoning.
mm/debug-pagealloc.c new file +74 -0
74 lines not on this page · raw message
mm/Kconfig.debug new file +8 -0
@@ -0,0 +1,8 @@ +config PAGE_POISONING + bool "Debug page memory allocations" + depends on !ARCH_SUPPORTS_DEBUG_PAGEALLOC + select DEBUG_PAGEALLOC + help + Fill the pages with poison patterns after free_pages() and verify + the patterns before alloc_pages(). This results in a large slowdown, + but helps to find certain types of memory corruptions.
mm/Makefile +1 -0
@@ -33,3 +33,4 @@ obj-$(CONFIG_MIGRATION) += migrate.o obj-$(CONFIG_SMP) += allocpercpu.o obj-$(CONFIG_QUICKLIST) += quicklist.o obj-$(CONFIG_CGROUP_MEM_RES_CTLR) += memcontrol.o page_cgroup.o +obj-$(CONFIG_PAGE_POISONING) += debug-pagealloc.o
lib/Kconfig.debug +1 -0
@@ -796,6 +796,7 @@ config SYSCTL_SYSCALL_CHECK to properly maintain and use. This enables checks that help you to keep things correct. +source mm/Kconfig.debug source kernel/trace/Kconfig config PROVIDE_OHCI1394_DMA_INIT
arch/powerpc/Kconfig.debug +1 -0
@@ -30,6 +30,7 @@ config DEBUG_STACK_USAGE config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL && !HIBERNATION + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/s390/Kconfig.debug +1 -0
@@ -9,6 +9,7 @@ source "lib/Kconfig.debug" config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a slowdown, but helps to find certain types of
arch/sparc/Kconfig.debug +2 -1
@@ -24,7 +24,8 @@ config STACK_DEBUG config DEBUG_PAGEALLOC bool "Debug page memory allocations" - depends on SPARC64 && DEBUG_KERNEL && !HIBERNATION + depends on DEBUG_KERNEL && !HIBERNATION + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/x86/Kconfig +3 -0
@@ -160,6 +160,9 @@ config AUDIT_ARCH config ARCH_SUPPORTS_OPTIMIZED_INLINING def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + # Use the generic interrupt handling code in kernel/irq/: config GENERIC_HARDIRQS bool
arch/x86/Kconfig.debug +1 -0
@@ -75,6 +75,7 @@ config DEBUG_STACK_USAGE config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/powerpc/Kconfig +3 -0
@@ -227,6 +227,9 @@ config PPC_OF_PLATFORM_PCI depends on PPC64 # not supported on 32 bits yet default n +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + source "init/Kconfig" source "kernel/Kconfig.freezer"
arch/sparc/Kconfig +3 -0
@@ -124,6 +124,9 @@ config ARCH_NO_VIRT_TO_BUS config OF def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y if SPARC64 + source "init/Kconfig" source "kernel/Kconfig.freezer"
arch/avr32/mm/fault.c +0 -18
@@ -250,21 +250,3 @@ asmlinkage void do_bus_error(unsigned lodump_dtlb ();die ("Bus Error" , regs,SIGKILL ); } - -/* -* This functionality is currently not possible to implement because -* we're using segmentation to ensure a fixed mapping of the kernel -* virtual address space. -* -* It would be possible to implement this, but it would require us to -* disable segmentation at startup and load the kernel mappings into -* the TLB like any other pages. There will be lots of trickery to -* avoid recursive invocation of the TLB miss handler, though... -*/ -#ifdef CONFIG_DEBUG_PAGEALLOC -void kernel_map_pages (struct page *page,int numpages,int enable) -{ - -} -EXPORT_SYMBOL (kernel_map_pages); -#endif
arch/s390/Kconfig +3 -0
@@ -72,6 +72,9 @@ config PGSTE config VIRT_CPU_ACCOUNTING def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + mainmenu "Linux Kernel Configuration" config S390
include/linux/mm_types.h +4 -0
@@ -94,6 +94,10 @@ struct page {void *virtual;/* Kernel virtual address (NULL if not kmapped, ie. highmem) */ #endif /* WANT_PAGE_VIRTUAL */ + +#ifdef CONFIG_PAGE_POISONING +bool poison; +#endif /* CONFIG_PAGE_POISONING */ };/*
Andrew Morton
maintainerQuoted 11 lines · On Thu, 5 Mar 2009 23:59:27 +0900 Akinobu Mita <[email protected]> wrote:
CONFIG_DEBUG_PAGEALLOCis now supported by x86, powerpc, sparc (64bit), and s390. This patch implements it for the rest of the architectures by filling the pages with poison byte patterns afterfree_pages()and verifying the poison patterns beforealloc_pages().This generic one cannot detect invalid read accesses and it can only detect invalid write accesses after a long delay. But it is a feasible way for nommu architectures.
...
mm/debug-pagealloc.c line 9
Quoted 9 lines
mm/debug-pagealloc.c new file +9
-0+#include <linux/kernel.h> +#include <linux/mm.h> + +static void poison_page (struct page *page) +{ +void *addr; + +if (PageHighMem (page)) +return ;/* i goofed */
heh. A more complete comment would be needed here.
Also, as this is a kernel bug, perhaps some sort of runtime warning?
Quoted 28 lines
mm/debug-pagealloc.c new file +28
-0+ page->poison = true; + addr =page_address (page); +memset (addr,PAGE_POISON ,PAGE_SIZE ); +} + +static void poison_pages (struct page *page,int n) +{ +int i; + +for (i =0 ; i < n; i++) +poison_page (page + i); +} + +static void check_poison_mem (unsigned char *mem,size_t bytes) +{ +unsigned char *start; +unsigned char *end; + +for (start = mem; start < mem + bytes; start++) { +if (*start !=PAGE_POISON ) +break ; + } +if (start == mem + bytes) +return ; + +for (end = mem + bytes -1 ; end > start; end--) { +if (*end !=PAGE_POISON ) +break ;
mm/debug-pagealloc.c line 48
Quoted 10 lines
mm/debug-pagealloc.c new file +10
-0+ } +printk (KERN_ERR "Page corruption: %p-%p\n" , start, end); +print_hex_dump (KERN_ERR ,"" ,DUMP_PREFIX_ADDRESS ,16 ,1 , start, + end - start +1 ,1 ); +} + +static void unpoison_page (struct page *page) +{ +void *addr; +
Shouldn't we check PageHighmem() here also?
mm/debug-pagealloc.c line 56
Quoted 8 lines
mm/debug-pagealloc.c new file +8
-0+if (!page->poison) +return ; + + addr =page_address (page); +check_poison_mem (addr,PAGE_SIZE ); + page->poison = false; +} +
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 12 lines · Andrew Morton
mm/debug-pagealloc.c line 9
Quoted 9 lines
mm/debug-pagealloc.c new file +9
-0+#include <linux/kernel.h> +#include <linux/mm.h> + +static void poison_page (struct page *page) +{ +void *addr; + +if (PageHighMem (page)) +return ;/* i goofed */ heh. A more complete comment would be needed here.
Quoted 1 line
Also, as this is a kernel bug, perhaps some sort of runtime warning?
It just skips the poisoning for highmem pages.
Any page poisoning can be skipped safely if it doesn't set the page->poison flag. So I'm going to put
/*
* skipping the page poisoning for highmem pages
*/
Quoted 4 lines
Quoted 4 lines
mm/debug-pagealloc.c new file +4
-0+ page->poison = true; + addr =page_address (page); +memset (addr,PAGE_POISON ,PAGE_SIZE ); +}
...
Quoted 6 lines
mm/debug-pagealloc.c line 48
Quoted 4 lines
mm/debug-pagealloc.c new file +4
-0+static void unpoison_page (struct page *page) +{ +void *addr; +Shouldn't we check
PageHighmem()here also?
It should not happen because page->poison flag is not set for highmem pages. But it's good for sanity checking. So I'll have a BUG_ON here.
Quoted 3 lines
mm/debug-pagealloc.c line 51
Quoted 3 lines
mm/debug-pagealloc.c new file +3
-0+if (!page->poison) +return ; +
BUG_ON(PageHighMem(page));
Quoted 4 lines
Quoted 4 lines
mm/debug-pagealloc.c new file +4
-0+ addr =page_address (page); +check_poison_mem (addr,PAGE_SIZE ); + page->poison = false; +}
PATCH 1/1 generic debug pagealloc (-v3)
CONFIG_DEBUG_PAGEALLOC is now supported by x86, powerpc, sparc64, and s390. This patch implements it for the rest of the architectures by filling the pages with poison byte patterns after free_pages() and verifying the poison patterns before alloc_pages().
This generic one cannot detect invalid page accesses immediately but invalid read access may cause invalid dereference by poisoned memory and invalid write access can be detected after a long delay.
* v3
- Comments for poisoning highmem pages
- Sanity check for highmem pages
- Detect single bit error
* v2
- Skip poisoning for highmem pages
- Romove duplidate poison pattern checking
--- arch/avr32/mm/fault.c | 18 -------- arch/powerpc/Kconfig | 3 + arch/powerpc/Kconfig.debug | 1 arch/s390/Kconfig | 3 + arch/s390/Kconfig.debug | 1 arch/sparc/Kconfig | 3 + arch/sparc/Kconfig.debug | 3 - arch/x86/Kconfig | 3 + arch/x86/Kconfig.debug | 1 include/linux/mm_types.h | 4 + include/linux/poison.h | 3 + lib/Kconfig.debug | 1 mm/Kconfig.debug | 8 +++ mm/Makefile | 1 mm/debug-pagealloc.c | 91 +++++++++++++++++++++++++++++++++++++++++++++ 15 files changed, 125 insertions(+), 19 deletions(-)
include/linux/poison.h +3 -0
@@ -17,6 +17,9 @@*/ #define TIMER_ENTRY_STATIC ((void *) 0x74737461) +/********** mm/debug-pagealloc.c **********/ +#define PAGE_POISON 0xaa +/********** mm/slab.c **********/ /* * Magic nums for obj red zoning.
mm/debug-pagealloc.c new file +91 -0
91 lines not on this page · raw message
mm/Kconfig.debug new file +8 -0
@@ -0,0 +1,8 @@ +config PAGE_POISONING + bool "Debug page memory allocations" + depends on !ARCH_SUPPORTS_DEBUG_PAGEALLOC + select DEBUG_PAGEALLOC + help + Fill the pages with poison patterns after free_pages() and verify + the patterns before alloc_pages(). This results in a large slowdown, + but helps to find certain types of memory corruptions.
mm/Makefile +1 -0
@@ -33,3 +33,4 @@ obj-$(CONFIG_MIGRATION) += migrate.o obj-$(CONFIG_SMP) += allocpercpu.o obj-$(CONFIG_QUICKLIST) += quicklist.o obj-$(CONFIG_CGROUP_MEM_RES_CTLR) += memcontrol.o page_cgroup.o +obj-$(CONFIG_PAGE_POISONING) += debug-pagealloc.o
lib/Kconfig.debug +1 -0
@@ -796,6 +796,7 @@ config SYSCTL_SYSCALL_CHECK to properly maintain and use. This enables checks that help you to keep things correct. +source mm/Kconfig.debug source kernel/trace/Kconfig config PROVIDE_OHCI1394_DMA_INIT
arch/powerpc/Kconfig.debug +1 -0
@@ -30,6 +30,7 @@ config DEBUG_STACK_USAGE config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL && !HIBERNATION + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/s390/Kconfig.debug +1 -0
@@ -9,6 +9,7 @@ source "lib/Kconfig.debug" config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a slowdown, but helps to find certain types of
arch/sparc/Kconfig.debug +2 -1
@@ -24,7 +24,8 @@ config STACK_DEBUG config DEBUG_PAGEALLOC bool "Debug page memory allocations" - depends on SPARC64 && DEBUG_KERNEL && !HIBERNATION + depends on DEBUG_KERNEL && !HIBERNATION + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/x86/Kconfig +3 -0
@@ -160,6 +160,9 @@ config AUDIT_ARCH config ARCH_SUPPORTS_OPTIMIZED_INLINING def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + # Use the generic interrupt handling code in kernel/irq/: config GENERIC_HARDIRQS bool
arch/x86/Kconfig.debug +1 -0
@@ -75,6 +75,7 @@ config DEBUG_STACK_USAGE config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/powerpc/Kconfig +3 -0
@@ -227,6 +227,9 @@ config PPC_OF_PLATFORM_PCI depends on PPC64 # not supported on 32 bits yet default n +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + source "init/Kconfig" source "kernel/Kconfig.freezer"
arch/sparc/Kconfig +3 -0
@@ -124,6 +124,9 @@ config ARCH_NO_VIRT_TO_BUS config OF def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y if SPARC64 + source "init/Kconfig" source "kernel/Kconfig.freezer"
arch/avr32/mm/fault.c +0 -18
@@ -250,21 +250,3 @@ asmlinkage void do_bus_error(unsigned lodump_dtlb ();die ("Bus Error" , regs,SIGKILL ); } - -/* -* This functionality is currently not possible to implement because -* we're using segmentation to ensure a fixed mapping of the kernel -* virtual address space. -* -* It would be possible to implement this, but it would require us to -* disable segmentation at startup and load the kernel mappings into -* the TLB like any other pages. There will be lots of trickery to -* avoid recursive invocation of the TLB miss handler, though... -*/ -#ifdef CONFIG_DEBUG_PAGEALLOC -void kernel_map_pages (struct page *page,int numpages,int enable) -{ - -} -EXPORT_SYMBOL (kernel_map_pages); -#endif
arch/s390/Kconfig +3 -0
@@ -72,6 +72,9 @@ config PGSTE config VIRT_CPU_ACCOUNTING def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + mainmenu "Linux Kernel Configuration" config S390
include/linux/mm_types.h +4 -0
@@ -94,6 +94,10 @@ struct page {void *virtual;/* Kernel virtual address (NULL if not kmapped, ie. highmem) */ #endif /* WANT_PAGE_VIRTUAL */ + +#ifdef CONFIG_PAGE_POISONING +bool poison; +#endif /* CONFIG_PAGE_POISONING */ };/*
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Andrew Morton
maintainerRe: [PATCH] generic debug pagealloc (-v3)
Quoted 11 lines · On Sat, 7 Mar 2009 00:39:45 +0900 Akinobu Mita <[email protected]> wrote:
CONFIG_DEBUG_PAGEALLOCis now supported by x86, powerpc, sparc64, and s390. This patch implements it for the rest of the architectures by filling the pages with poison byte patterns afterfree_pages()and verifying the poison patterns beforealloc_pages().This generic one cannot detect invalid page accesses immediately but invalid read access may cause invalid dereference by poisoned memory and invalid write access can be detected after a long delay.
...
mm/debug-pagealloc.c line 11
Quoted 8 lines
mm/debug-pagealloc.c new file +8
-0+static void poison_page (struct page *page) +{ +void *addr; + +if (PageHighMem (page)) { +/* +* Skip poisoning for highmem pages +*/
This isn't a good comment - what it tells us is already utterly obvious from the code, and the reader is left with no clue as to _why_ the code does this.
Quoted 35 lines
mm/debug-pagealloc.c new file +35
-0+return ; + } + page->poison = true; + addr =page_address (page); +memset (addr,PAGE_POISON ,PAGE_SIZE ); +} + +static void poison_pages (struct page *page,int n) +{ +int i; + +for (i =0 ; i < n; i++) +poison_page (page + i); +} + +static bool single_bit_flip (unsigned char a,unsigned char b) +{ +unsigned char error = a ^ b; + +return error && !(error & (error -1 )); +} + +static void check_poison_mem (unsigned char *mem,size_t bytes) +{ +unsigned char *start; +unsigned char *end; + +for (start = mem; start < mem + bytes; start++) { +if (*start !=PAGE_POISON ) +break ; + } +if (start == mem + bytes) +return ; + +for (end = mem + bytes -1 ; end > start; end--) {
mm/debug-pagealloc.c line 56
Quoted 10 lines
mm/debug-pagealloc.c new file +10
-0+if (*end !=PAGE_POISON ) +break ; + } +if (start == end &&single_bit_flip (*start,PAGE_POISON )) +printk (KERN_ERR "Single bit error: %p\n" , start); +else +printk (KERN_ERR "Page corruption: %p-%p\n" , start, end); + +print_hex_dump (KERN_ERR ,"" ,DUMP_PREFIX_ADDRESS ,16 ,1 , start, + end - start +1 ,1 );
These messages should be self-identifying in some fashion. A message like "Single bit error" could come from almost any part of the kernel. Something like "pagealloc: single bit error", perhaps?
There's a decent chance that if this warning triggers once, it will trigger a thousand times, depending upon the nature of the fault. So it would be sensible to put some constraint upon the reporting. That could be time-based (include/linux/ratelimit.h) or perhaps just stop at ten or whatever.
If this message ever comes out, the chances are high that we'll really really want to know which kernel subsystem owned that page. Because if it's a software fault, this will help us find the bug. A suitable way of doing this is to run dump_stack(). This will also cause the reports to be tracked by kerneloops.org.
include/linux/mm_types.h struct page { · line 102
Quoted 12 lines
include/linux/mm_types.h +4
-0@@ -94,6 +94,10 @@ struct page {void *virtual;/* Kernel virtual address (NULL if not kmapped, ie. highmem) */ #endif /* WANT_PAGE_VIRTUAL */ + +#ifdef CONFIG_PAGE_POISONING +bool poison; +#endif /* CONFIG_PAGE_POISONING */ };
Adding 32 bits to the pageframe for a single feature which needs one bit is rather sad. Sure, this is a super-slow feature and nobody will be turning it on in production. But I wonder if we can do better.
#ifdef CONFIG_WANT_PAGE_DEBUG_FLAGS
unsigned long debug_flags; /* Use atomic bitops on this */
#endif
};
#define PAGE_DEBUG_FLAG_PAGEALLOC 0
#define PAGE_DEBUG_SOMETHING_ELSE 1
etc
Now, your feature needs to turn on CONFIG_WANT_PAGE_DEBUG_FLAGS. Other debug features can do so as well.
But we do need to ensure that CONFIG_WANT_PAGE_DEBUG_FLAGS reliably gets turned off when no debug features are enabling it! It would be sad if a developer were to enable your feature, then disable it, then run `oldconfig', then have a pageframe which contains an extra unused long. I don't trust the Kconfig system ;)
Maybe this is all a bit overdesigned, dunno. If someone else later comes along wanting to add more debug stuff then they'll need to do this, might as well do it now?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 generic debug pagealloc (-v4)
Quoted 4 lines · Andrew Morton
Quoted 4 lines
(quoted diff) +4
-0+static void poison_page(struct page *page) +{ + void *addr; +
Quoted 8 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+ if (PageHighMem(page)) { + /* + * Skip poisoning for highmem pages + */This isn't a good comment - what it tells us is already utterly obvious from the code, and the reader is left with no clue as to _why_ the code does this.
OK. I made the poison_highpage()/unpoison_highpage() for poisoning highmem pages. They are not implemented yet and just have a comment quoted from your earlier email for someone who want to implement it.
Quoted 15 lines
Adding 32 bits to the pageframe for a single feature which needs one bit is rather sad. Sure, this is a super-slow feature and nobody will be turning it on in production. But I wonder if we can do better.
#ifdef
CONFIG_WANT_PAGE_DEBUG_FLAGS
unsigned longdebug_flags; /* Use atomic bitops on this */
#endif
};#define
PAGE_DEBUG_FLAG_PAGEALLOC0
#definePAGE_DEBUG_SOMETHING_ELSE1
etc
Quoted 8 lines
Now, your feature needs to turn on
CONFIG_WANT_PAGE_DEBUG_FLAGS. Other debug features can do so as well.But we do need to ensure that
CONFIG_WANT_PAGE_DEBUG_FLAGSreliably gets turned off when no debug features are enabling it! It would be sad if a developer were to enable your feature, then disable it, then run `oldconfig', then have a pageframe which contains an extra unused long. I don't trust theKconfigsystem ;)
I've done it. Please see include/linux/page-debug-flags.h
From: Akinobu Mita <[email protected]>
Subject: [PATCH] generic debug pagealloc (-v4)
CONFIG_DEBUG_PAGEALLOC is now supported by x86, powerpc, sparc64, and s390. This patch implements it for the rest of the architectures by filling the pages with poison byte patterns after free_pages() and verifying the poison patterns before alloc_pages().
This generic one cannot detect invalid page accesses immediately but invalid read access may cause invalid dereference by poisoned memory and invalid write access can be detected after a long delay.
* v4
- Introduce empty poison_highpage() and unpoison_highpage()
- Improve error messages for page corruption and dump_stack()
- Error messages ratelimiting
- Introduce debug_flage in struct page instead of bool poison
* v3
- Comments for poisoning highmem pages
- Sanity check for highmem pages
- Detect single bit error
* v2
- Skip poisoning for highmem pages
- Romove duplidate poison pattern checking
--- arch/avr32/mm/fault.c | 18 ----- arch/powerpc/Kconfig | 3 arch/powerpc/Kconfig.debug | 1 arch/s390/Kconfig | 3 arch/s390/Kconfig.debug | 1 arch/sparc/Kconfig | 3 arch/sparc/Kconfig.debug | 3 arch/x86/Kconfig | 3 arch/x86/Kconfig.debug | 1 include/linux/mm_types.h | 5 + include/linux/page-debug-flags.h | 30 +++++++++ include/linux/poison.h | 3 lib/Kconfig.debug | 1 mm/Kconfig.debug | 12 +++ mm/Makefile | 1 mm/debug-pagealloc.c | 129 +++++++++++++++++++++++++++++++++++++++ 16 files changed, 198 insertions(+), 19 deletions(-)
include/linux/poison.h +3 -0
@@ -17,6 +17,9 @@*/ #define TIMER_ENTRY_STATIC ((void *) 0x74737461) +/********** mm/debug-pagealloc.c **********/ +#define PAGE_POISON 0xaa +/********** mm/slab.c **********/ /* * Magic nums for obj red zoning.
mm/debug-pagealloc.c new file +129 -0
129 lines not on this page · raw message
mm/Kconfig.debug new file +12 -0
@@ -0,0 +1,12 @@ +config WANT_PAGE_DEBUG_FLAGS + bool + +config PAGE_POISONING + bool "Debug page memory allocations" + depends on !ARCH_SUPPORTS_DEBUG_PAGEALLOC + select DEBUG_PAGEALLOC + select WANT_PAGE_DEBUG_FLAGS + help + Fill the pages with poison patterns after free_pages() and verify + the patterns before alloc_pages(). This results in a large slowdown, + but helps to find certain types of memory corruptions.
mm/Makefile +1 -0
@@ -33,3 +33,4 @@ obj-$(CONFIG_MIGRATION) += migrate.o obj-$(CONFIG_SMP) += allocpercpu.o obj-$(CONFIG_QUICKLIST) += quicklist.o obj-$(CONFIG_CGROUP_MEM_RES_CTLR) += memcontrol.o page_cgroup.o +obj-$(CONFIG_PAGE_POISONING) += debug-pagealloc.o
lib/Kconfig.debug +1 -0
@@ -796,6 +796,7 @@ config SYSCTL_SYSCALL_CHECK to properly maintain and use. This enables checks that help you to keep things correct. +source mm/Kconfig.debug source kernel/trace/Kconfig config PROVIDE_OHCI1394_DMA_INIT
arch/powerpc/Kconfig.debug +1 -0
@@ -30,6 +30,7 @@ config DEBUG_STACK_USAGE config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL && !HIBERNATION + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/s390/Kconfig.debug +1 -0
@@ -9,6 +9,7 @@ source "lib/Kconfig.debug" config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a slowdown, but helps to find certain types of
arch/sparc/Kconfig.debug +2 -1
@@ -24,7 +24,8 @@ config STACK_DEBUG config DEBUG_PAGEALLOC bool "Debug page memory allocations" - depends on SPARC64 && DEBUG_KERNEL && !HIBERNATION + depends on DEBUG_KERNEL && !HIBERNATION + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/x86/Kconfig +3 -0
@@ -160,6 +160,9 @@ config AUDIT_ARCH config ARCH_SUPPORTS_OPTIMIZED_INLINING def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + # Use the generic interrupt handling code in kernel/irq/: config GENERIC_HARDIRQS bool
arch/x86/Kconfig.debug +1 -0
@@ -75,6 +75,7 @@ config DEBUG_STACK_USAGE config DEBUG_PAGEALLOC bool "Debug page memory allocations" depends on DEBUG_KERNEL + depends on ARCH_SUPPORTS_DEBUG_PAGEALLOC help Unmap pages from the kernel linear mapping after free_pages(). This results in a large slowdown, but helps to find certain types
arch/powerpc/Kconfig +3 -0
@@ -227,6 +227,9 @@ config PPC_OF_PLATFORM_PCI depends on PPC64 # not supported on 32 bits yet default n +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + source "init/Kconfig" source "kernel/Kconfig.freezer"
arch/sparc/Kconfig +3 -0
@@ -124,6 +124,9 @@ config ARCH_NO_VIRT_TO_BUS config OF def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y if SPARC64 + source "init/Kconfig" source "kernel/Kconfig.freezer"
arch/avr32/mm/fault.c +0 -18
@@ -250,21 +250,3 @@ asmlinkage void do_bus_error(unsigned lodump_dtlb ();die ("Bus Error" , regs,SIGKILL ); } - -/* -* This functionality is currently not possible to implement because -* we're using segmentation to ensure a fixed mapping of the kernel -* virtual address space. -* -* It would be possible to implement this, but it would require us to -* disable segmentation at startup and load the kernel mappings into -* the TLB like any other pages. There will be lots of trickery to -* avoid recursive invocation of the TLB miss handler, though... -*/ -#ifdef CONFIG_DEBUG_PAGEALLOC -void kernel_map_pages (struct page *page,int numpages,int enable) -{ - -} -EXPORT_SYMBOL (kernel_map_pages); -#endif
arch/s390/Kconfig +3 -0
@@ -72,6 +72,9 @@ config PGSTE config VIRT_CPU_ACCOUNTING def_bool y +config ARCH_SUPPORTS_DEBUG_PAGEALLOC + def_bool y + mainmenu "Linux Kernel Configuration" config S390
include/linux/mm_types.h +5 -0
@@ -11,6 +11,7 @@#include <linux/rwsem.h> #include <linux/completion.h> #include <linux/cpumask.h> +#include <linux/page-debug-flags.h> #include <asm/page.h> #include <asm/mmu.h>
@@ -94,6 +95,10 @@ struct page {void *virtual;/* Kernel virtual address (NULL if not kmapped, ie. highmem) */ #endif /* WANT_PAGE_VIRTUAL */ + +#ifdef CONFIG_WANT_PAGE_DEBUG_FLAGS +unsigned long debug_flags;/* Use atomic bitops on this */ +#endif };/*
include/linux/page-debug-flags.h new file +30 -0
@@ -0,0 +1,30 @@ +#ifndef LINUX_PAGE_DEBUG_FLAGS_H +#define LINUX_PAGE_DEBUG_FLAGS_H + +/* +* page->debug_flags bits: +* +* PAGE_DEBUG_FLAG_POISON is set for poisoned pages. This is used to +* implement generic debug pagealloc feature. The pages are filled with +* poison patterns and set this flag after free_pages(). The poisoned +* pages are verified whether the patterns are not corrupted and clear +* the flag before alloc_pages(). +*/ + +enum page_debug_flags { +PAGE_DEBUG_FLAG_POISON ,/* Page is poisoned */ +}; + +/* +* Ensure that CONFIG_WANT_PAGE_DEBUG_FLAGS reliably +* gets turned off when no debug features are enabling it! +*/ + +#ifdef CONFIG_WANT_PAGE_DEBUG_FLAGS +#if !defined(CONFIG_PAGE_POISONING ) \ +/* && !defined(CONFIG_PAGE_DEBUG_SOMETHING_ELSE) && ... */ +#error WANT_PAGE_DEBUG_FLAGS is turned on with no debug features! +#endif +#endif /* CONFIG_WANT_PAGE_DEBUG_FLAGS */ + +#endif /* LINUX_PAGE_DEBUG_FLAGS_H */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>