Skip to contentSkip to conversation

sensord: Coding style conversion (gnu ->

PATCH In review Andre Prendel 2 participants 4 messages Mar 9, 2009

lore
Share & tools
lore
#0 lore raw

cover sensord: Coding style conversion (gnu ->

This patch series converts the coding style in prog/sensord/ from gnu to kernel style. So we are consistent all over the project.

The conversion have exposed some very deep indentation levels. So it was impossible to not break the 80-characters-per-line rule. Some of them I already fixed, but other ones can only be fixed by restructuring the code. I will do that in further patches.

--

 args.c    |  462 +++++++++++++++++++-------------------
 chips.c   |  547 +++++++++++++++++++++++----------------------
 lib.c     |  119 +++++----
 rrd.c     |  743
 ++++++++++++++++++++++++++++++++------------------------------
 sense.c   |  399 +++++++++++++++++----------------
 sensord.c |  382 ++++++++++++++++---------------
 sensord.h |   61 ++---
 7 files changed, 1395 insertions(+), 1318 deletions(-)

Andre

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Re: [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu

Hallo Andre,

Quoted 9 lines · Andre Prendel

This patch series converts the coding style in prog/sensord/ from gnu to kernel style. So we are consistent all over the project.

The conversion have exposed some very deep indentation levels. So it was impossible to not break the 80-characters-per-line rule. Some of them I already fixed, but other ones can only be fixed by restructuring the code. I will do that in further patches.

--

Quoted 8 lines
 args.c    |  462 +++++++++++++++++++-------------------
 chips.c   |  547 +++++++++++++++++++++++----------------------
 lib.c     |  119 +++++----
 rrd.c     |  743 ++++++++++++++++++++++++++++++++------------------------------
 sense.c   |  399 +++++++++++++++++----------------
 sensord.c |  382 ++++++++++++++++---------------
 sensord.h |   61 ++---
 7 files changed, 1395 insertions(+), 1318 deletions(-)

No objection from me, feel free to apply all these patches.

Thanks,

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw

Re: [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu

In reply to Andre Prendel
Quoted 1 line · Jean Delvare

Hallo Andre,

Salut Jean,

Quoted 20 lines · Andre Prendel
Quoted 9 lines

This patch series converts the coding style in prog/sensord/ from gnu to kernel style. So we are consistent all over the project.

The conversion have exposed some very deep indentation levels. So it was impossible to not break the 80-characters-per-line rule. Some of them I already fixed, but other ones can only be fixed by restructuring the code. I will do that in further patches.

--

Quoted 8 lines
 args.c    |  462 +++++++++++++++++++-------------------
 chips.c   |  547 +++++++++++++++++++++++----------------------
 lib.c     |  119 +++++----
 rrd.c     |  743 ++++++++++++++++++++++++++++++++------------------------------
 sense.c   |  399 +++++++++++++++++----------------
 sensord.c |  382 ++++++++++++++++---------------
 sensord.h |   61 ++---
 7 files changed, 1395 insertions(+), 1318 deletions(-)
Quoted 1 line

No objection from me, feel free to apply all these patches.

Applied with your suggestion to patch 6/7.

BTW, how do you send patch series? I use quilt to handle the patches. The E-Mails I have though written by hand. Maybe I should try quilt mail. Have you any experiences with it?

Andre

Quoted 3 lines

Thanks,

Signature · 1 line
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#3 lore raw

Re: [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu

In reply to Andre Prendel
Quoted 25 lines · Andre Prendel
Quoted 1 line · Jean Delvare

Hallo Andre,

Salut Jean,

Quoted 20 lines · Andre Prendel
Quoted 17 lines

This patch series converts the coding style in prog/sensord/ from gnu to kernel style. So we are consistent all over the project.

The conversion have exposed some very deep indentation levels. So it was impossible to not break the 80-characters-per-line rule. Some of them I already fixed, but other ones can only be fixed by restructuring the code. I will do that in further patches.

--

 args.c    |  462 +++++++++++++++++++-------------------
 chips.c   |  547 +++++++++++++++++++++++----------------------
 lib.c     |  119 +++++----
 rrd.c     |  743 ++++++++++++++++++++++++++++++++------------------------------
 sense.c   |  399 +++++++++++++++++----------------
 sensord.c |  382 ++++++++++++++++---------------
 sensord.h |   61 ++---
 7 files changed, 1395 insertions(+), 1318 deletions(-)
Quoted 3 lines
Quoted 1 line

No objection from me, feel free to apply all these patches.

Applied with your suggestion to patch 6/7.

Thanks!

Quoted 3 lines

BTW, how do you send patch series? I use quilt to handle the patches. The E-Mails I have though written by hand. Maybe I should try quilt mail. Have you any experiences with it?

I've always been too chicken and/or psychorigid to try quilt mail. I always send my patch series manually, sending 0/N first and then all the actual patches as a reply to 0/N. But that's quite some work and error prone, so I'm not sure if I can sanely recommend that.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors