PCIe portdrv: eliminate double kfree in remove path
PATCH 1/1 PCIe portdrv: eliminate double kfree in remove path
Commit 55633af3 (PCIe portdrv: Use driver data to simplify code) added a kfree of the driver private data in pcie_port_device_remove but forgot to remove the old kfree from pcie_portdrv_remove.
---
drivers/pci/pcie/portdrv_pci.c +0 -1
@@ -93,7 +93,6 @@ static int __devinit pcie_portdrv_probe (struct pci_dev *dev,static void pcie_portdrv_remove (struct pci_dev *dev) {pcie_port_device_remove (dev); -kfree (pci_get_drvdata (dev)); }static int error_detected_iter (struct device *device,void *data)
Quoted 3 lines · Alex Chiang
Commit
55633af3(PCIe portdrv: Use driver data to simplify code) added a kfree of the driver private data inpcie_port_device_removebut forgot to remove the old kfree frompcie_portdrv_remove.
Ah, sorry for that, it resulted in quite a lot of debugging work for you. :-(
Quoted 1 line
Signed-off-by Alex Chiang <[email protected]>
Acked-by; Rafael J. Wysocki <[email protected]>
Quoted 14 lines
---
drivers/pci/pcie/portdrv_pci.c +0
-2@@ -93,7 +93,6 @@ static int __devinit pcie_portdrv_probe (struct pci_dev *dev,static void pcie_portdrv_remove (struct pci_dev *dev) {pcie_port_device_remove (dev); -kfree (pci_get_drvdata (dev)); }static int error_detected_iter (struct device *device,void *data) --
Jesse Barnes
AppliedQuoted 5 lines · On Mon, 9 Mar 2009 12:08:15 -0600 Alex Chiang <[email protected]> wrote:
Commit
55633af3(PCIe portdrv: Use driver data to simplify code) added a kfree of the driver private data inpcie_port_device_removebut forgot to remove the old kfree frompcie_portdrv_remove.Signed-off-by Alex Chiang <[email protected]>
Applied, thanks.
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center