Skip to contentSkip to conversation

inotify_unmount_inodes badness?

DISCUSSION Nick Piggin 1 participant 1 message Mar 11, 2009 VFS

lore
Share & tools
lore
#0 lore raw

inotify_unmount_inodes does this hairly looking thing with list_for_each_entry_safe, where it tries to take a reference to the "next" inode as well as the current, before dropping inode_lock. But it doesn't take a reference on inodes without a refcount, or I_CLEAR|I_FREEING|I_WILL_FREE inodes before dropping the lock. Can't these guys just go away at any time?

Why does it need the safe list traveral anyway (which is causing this complexity)? We don't remove the inode from its sb list here, do we??