Fix for NFS boot for OMAP3 EVM
PATCH 1/1 Fix for NFS boot for OMAP3 EVM
The eth_halt() function has been modified to remove the chip reset and instead stop the transmit/receive from the device.
--- drivers/net/smc911x.c | 23 ++++++++++++++++++++++- 1 files changed, 22 insertions(+), 1 deletions(-)
drivers/net/smc911x.c +22 -1
@@ -116,6 +116,27 @@ static int smc911x_phy_reset(void)return 0 ; } +static void smc911x_shutdown (void ) +{ +unsigned cr; + +/* Turn of Rx and TX */ + cr =smc911x_get_mac_csr (MAC_CR ); + cr &= ~(MAC_CR_TXEN |MAC_CR_RXEN |MAC_CR_HBDIS ); +smc911x_set_mac_csr (MAC_CR , cr); + +/* Stop Transmission */ + cr =smc911x_get_mac_csr (TX_CFG ); + cr &= ~(TX_CFG_STOP_TX ); +smc911x_set_mac_csr (TX_CFG , cr); +/* Stop receiving packets */ + cr =smc911x_get_mac_csr (RX_CFG ); + cr &= ~(RX_CFG_RXDOFF ); +smc911x_set_mac_csr (RX_CFG , cr); + +} + +static void smc911x_phy_configure (void ) {int timeout;
@@ -224,7 +245,7 @@ int eth_send(volatile void *packet, int length)void eth_halt (void ) { -smc911x_reset (); +smc911x_shutdown (); }int eth_rx (void )
Signature · 1 line
1.5.6
PATCH 1/1 Fix for NFS boot for OMAP3 EVM
Quoted 2 lines · Manikandan Pillai
The
eth_halt()function has been modified to remove the chip reset and instead stop the transmit/receive from the device.
it's not really a fix of the OMAP3 please use a better commit message
Ben could you take a look
Best Regards,
J.
PATCH 1/1 Fix for NFS boot for OMAP3 EVM
In reply to Manikandan PillaiManikandan,
There's a disconnect between your title and what this patch does. I have no reason to doubt that this fixes NFS boot on your board, BTW.
Quoted 13 lines · Manikandan Pillai
The
eth_halt()function has been modified to remove the chip reset and instead stop the transmit/receive from the device.Signed-off-by Manikandan Pillai <[email protected]>--- drivers/net/smc911x.c | 23 ++++++++++++++++++++++- 1 files changed, 22 insertions(+), 1 deletions(-)drivers/net/smc911x.c +0
-0
drivers/net/smc911x.c static int smc911x_phy_reset(void) · line 122
Quoted 7 lines
drivers/net/smc911x.c +3
-0@@ -116,6 +116,27 @@ static int smc911x_phy_reset(void)return 0 ; } +static void smc911x_shutdown (void ) +{ +unsigned cr;
unsigned int, please
Quoted 23 lines
drivers/net/smc911x.c +18
-0+ +/* Turn of Rx and TX */ + cr =smc911x_get_mac_csr (MAC_CR ); + cr &= ~(MAC_CR_TXEN |MAC_CR_RXEN |MAC_CR_HBDIS ); +smc911x_set_mac_csr (MAC_CR , cr); + +/* Stop Transmission */ + cr =smc911x_get_mac_csr (TX_CFG ); + cr &= ~(TX_CFG_STOP_TX ); +smc911x_set_mac_csr (TX_CFG , cr); +/* Stop receiving packets */ + cr =smc911x_get_mac_csr (RX_CFG ); + cr &= ~(RX_CFG_RXDOFF ); +smc911x_set_mac_csr (RX_CFG , cr); + +} + +static void smc911x_phy_configure (void ) {drivers/net/smc911x.c +0
-0int timeout;
drivers/net/smc911x.c int eth_send(volatile void *packet, int length) · line 251
Quoted 8 lines
drivers/net/smc911x.c +1
-1@@ -224,7 +245,7 @@ int eth_send(volatile void *packet, int length)void eth_halt (void ) { -smc911x_reset (); +smc911x_shutdown (); }int eth_rx (void )
Other than that, no issues.
regards,
Ben
Pillai
PATCH 1/1 Fix for NFS boot for OMAP3 EVM
In reply to Manikandan PillaiHi,
What is the status of this patch ?
Any comments.
regards
Quoted 58 lines
-----Original Message-----
From: Pillai, Manikandan
Sent: Tuesday, March 03, 2009 9:10 AM
To: u-boot at lists.denx.de; dirk.behme at googlemail.com
Cc: Pillai, Manikandan
Subject: [PATCH 1/1] Fix for NFS boot for OMAP3 EVMThe
eth_halt()function has been modified to remove the chip reset and instead stop the transmit/receive from the device.Signed-off-by Manikandan Pillai <[email protected]>--- drivers/net/smc911x.c | 23 ++++++++++++++++++++++- 1 files changed, 22 insertions(+), 1 deletions(-)drivers/net/smc911x.c +22
-2@@ -116,6 +116,27 @@ static int smc911x_phy_reset(void)return 0 ; } +static void smc911x_shutdown (void ) +{ +unsigned cr; + +/* Turn of Rx and TX */ + cr =smc911x_get_mac_csr (MAC_CR ); + cr &= ~(MAC_CR_TXEN |MAC_CR_RXEN |MAC_CR_HBDIS ); +smc911x_set_mac_csr (MAC_CR , cr); + +/* Stop Transmission */ + cr =smc911x_get_mac_csr (TX_CFG ); + cr &= ~(TX_CFG_STOP_TX ); +smc911x_set_mac_csr (TX_CFG , cr); +/* Stop receiving packets */ + cr =smc911x_get_mac_csr (RX_CFG ); + cr &= ~(RX_CFG_RXDOFF ); +smc911x_set_mac_csr (RX_CFG , cr); + +} + +static void smc911x_phy_configure (void ) {int timeout;@@ -224,7 +245,7 @@ int eth_send(volatile void *packet, int length)void eth_halt (void ) { -smc911x_reset (); +smc911x_shutdown (); }int eth_rx (void ) --1.5.6
PATCH 1/1 Fix for NFS boot for OMAP3 EVM
Quoted 6 lines · Manikandan
Hi,
What is the status of this patch ?
Any comments.
Did you fix the things I mentioned and re-submit?
regards,
Ben
Pillai
PATCH 1/1 Fix for NFS boot for OMAP3 EVM
Hi Ben,
I believe your comments were on the timeout setting of 1ms for u-boot timer. I am not sure whether I received any comments from you on the NFS boot patch.
Regards
Mani
________________________________
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: Tuesday, April 07, 2009 11:38 AM
To: Pillai, Manikandan
Cc: u-boot at lists.denx.de; dirk.behme at googlemail.com
Subject: Re: [U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM
On Mon, Apr 6, 2009 at 10:34 PM, Pillai, Manikandan <mani.pillai at ti.com<mailto:[email protected]>> wrote:
Hi,
What is the status of this patch ?
Any comments.
Did you fix the things I mentioned and re-submit?
regards,
Ben
PATCH 1/1 Fix for NFS boot for OMAP3 EVM
Quoted 4 lines · Manikandan
Hi Ben,
Quoted 8 lines
I believe your comments were on the timeout setting of 1ms for u-boot timer.
I am not sure whether I received any comments from you on the NFS boot patch.
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/55784/
Please don't top-post.
regards,
Ben
Quoted 34 lines
Regards
Mani
------------------------------
*From:* Ben Warren [mailto:biggerbadderben at gmail.com] *Sent:* Tuesday, April 07, 2009 11:38 AM
*To:* Pillai, Manikandan
*Cc:* u-boot at lists.denx.de; dirk.behme at googlemail.com *Subject:* Re: [U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVMOn Mon, Apr 6, 2009 at 10:34 PM, Pillai, Manikandan <[email protected]> wrote:
Hi,
What is the status of this patch ?
Any comments.Did you fix the things I mentioned and re-submit?
regards,
Ben
PATCH 1/1 Fix for NFS boot for OMAP3 EVM
In reply to PillaiHi Mani,
Quoted 4 lines · Manikandan
Hi Ben,
I believe your comments were on the timeout setting of 1ms for u-boot timer. I am not sure whether I received any comments from you on the NFS boot patch.
Looking at [1] and [2], it seems to me that they want
- a better patch subject which matches what the patch does
- an unsigned int
Best regards
Dirk
[1] http://lists.denx.de/pipermail/u-boot/2009-March/048889.html
[2] http://lists.denx.de/pipermail/u-boot/2009-March/048899.html
Quoted 19 lines
________________________________
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: Tuesday, April 07, 2009 11:38 AM
To: Pillai, Manikandan
Cc: u-boot at lists.denx.de; dirk.behme at googlemail.com
Subject: Re: [U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVMOn Mon, Apr 6, 2009 at 10:34 PM, Pillai, Manikandan <mani.pillai at ti.com<mailto:[email protected]>> wrote:
Hi,
What is the status of this patch ?
Any comments.
Did you fix the things I mentioned and re-submit?regards,
Ben