ocfs2: Fix a bug found by sparse check.
PATCH 1/1 ocfs2: Fix a bug found by sparse check.
We need to use le32_to_cpu to test rec->e_cpos inocfs2_dinode_insert_check.
Signed-off-by Tao Ma <[email protected]>
--- fs/ocfs2/alloc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
fs/ocfs2/alloc.c +2 -1
@@ -176,7 +176,8 @@ static int ocfs2_dinode_insert_check(struct inode *inode,BUG_ON (OCFS2_I (inode)->ip_dyn_features &OCFS2_INLINE_DATA_FL ); mlog_bug_on_msg(!ocfs2_sparse_alloc(osb) && - (OCFS2_I(inode)->ip_clusters != rec->e_cpos), + (OCFS2_I(inode)->ip_clusters != + le32_to_cpu(rec->e_cpos)), "Device %s, asking for sparse allocation: inode %llu, " "cpos %u, clusters %u\n", osb->dev_str,
Signature · 1 line
1.6.2.rc2.16.gf474c
PATCH 1/1 ocfs2: Fix a bug found by sparse check.
Quoted 4 lines · Tao Ma
We need to use
le32_to_cputo testrec->e_cposinocfs2_dinode_insert_check.Signed-off-by Tao Ma <[email protected]>
Acked-by Joel Becker <[email protected]>
Quoted 26 lines
--- fs/ocfs2/alloc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)fs/ocfs2/alloc.c +2
-1@@ -176,7 +176,8 @@ static int ocfs2_dinode_insert_check(struct inode *inode,BUG_ON (OCFS2_I (inode)->ip_dyn_features &OCFS2_INLINE_DATA_FL ); mlog_bug_on_msg(!ocfs2_sparse_alloc(osb) && - (OCFS2_I(inode)->ip_clusters != rec->e_cpos), + (OCFS2_I(inode)->ip_clusters != + le32_to_cpu(rec->e_cpos)), "Device %s, asking for sparse allocation: inode %llu, " "cpos %u, clusters %u\n", osb->dev_str,Signature · 7 lines
1.6.2.rc2.16.gf474c _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel at oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel
Signature · 9 lines
"The doctrine of human equality reposes on this: that there is no man really clever who has not found that he is stupid." - Gilbert K. Chesterson Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127