Skip to contentSkip to conversation

ixgbe: fix multiple unicast address support

PATCH In review Jeff Kirsher 2 participants 3 messages Mar 11, 2009 – Mar 13, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: fix multiple unicast address support

From: Chris Leech <[email protected]>

Multiple unicast address support appears to have been broken with the change to support net_device_ops. This a regression from 2.6.28 to 2.6.29.

I'm not 100% on whether ndo_set_multicast_list can be NULL after this or not. If ndo_set_rx_mode is set everything _should_ be using it.

---

 drivers/net/ixgbe/ixgbe_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +1 -0
index d0b9870..8e7a51b 100644
@@ -4341,6 +4341,7 @@ static const struct net_device_ops ixgbe_netdev_ops = {
 	.ndo_stop		= ixgbe_close,
 	.ndo_start_xmit		= ixgbe_xmit_frame,
 	.ndo_get_stats		= ixgbe_get_stats,
+	.ndo_set_rx_mode        = ixgbe_set_rx_mode,
 	.ndo_set_multicast_list	= ixgbe_set_rx_mode,
 	.ndo_validate_addr	= eth_validate_addr,
 	.ndo_set_mac_address	= ixgbe_set_mac,
#1 lore raw
Quoted 21 lines · Jeff Kirsher

From: Chris Leech <[email protected]>

Multiple unicast address support appears to have been broken with the change to support net_device_ops.  This a regression from 2.6.28 to 2.6.29.

I'm not 100% on whether ndo_set_multicast_list can be NULL after this or not.  If ndo_set_rx_mode is set everything _should_ be using it.

---

 drivers/net/ixgbe/ixgbe_main.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +0 -0
index d0b9870..8e7a51b 100644

drivers/net/ixgbe/ixgbe_main.c static const struct net_device_ops ixgbe_netdev_ops = {

Quoted 9 lines
drivers/net/ixgbe/ixgbe_main.c +1 -1
@@ -4341,6 +4341,7 @@ static const struct net_device_ops ixgbe_netdev_ops = {
        .ndo_stop               = ixgbe_close,
        .ndo_start_xmit         = ixgbe_xmit_frame,
        .ndo_get_stats          = ixgbe_get_stats,
+       .ndo_set_rx_mode        = ixgbe_set_rx_mode,
        .ndo_set_multicast_list = ixgbe_set_rx_mode,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_set_mac_address    = ixgbe_set_mac,
 
--

Dave,
I know that it is very late in the rc cycle, so I understand if
this change cannot make it into 2.6.29. If it is possible, we would like to see this 1 line change make 2.6.29.

Signature · 2 lines
Cheers,
Jeff
maintainer
#2 lore raw

From: Jeff Kirsher <[email protected]>
Date: Tue, 10 Mar 2009 20:35:28 -0700

Quoted 13 lines
Quoted 11 lines · Jeff Kirsher

From: Chris Leech <[email protected]>

Multiple unicast address support appears to have been broken with the change to support net_device_ops.  This a regression from 2.6.28 to 2.6.29.

I'm not 100% on whether ndo_set_multicast_list can be NULL after this or not.  If ndo_set_rx_mode is set everything _should_ be using it.

..

Quoted 3 lines

I know that it is very late in the rc cycle, so I understand if
this change cannot make it into 2.6.29. If it is possible, we would like to see this 1 line change make 2.6.29.

Ok, since you asked nicely :-)