Skip to contentSkip to conversation

disable C1E for HVM guest

PATCH In review Christoph Egger 2 participants 3 messages Mar 12, 2009 – Mar 13, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 disable C1E for HVM guest

Hi,

attached patch disables C1E in HVM guests.
This also fixes a guest crash via #GP
on cross-vendor migration.

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
xen/arch/x86/hvm/hvm.c +9 -0
diff -r c9a35fb19e75 xen/arch/x86/hvm/hvm.c
@@ -1776,6 +1776,15 @@ int hvm_msr_read_intercept(struct cpu_us
         msr_content = var_range_base[index];
         break;
 
+    case MSR_K8_ENABLE_C1E:
+         /* There's no point in letting the guest see C-States.
+          * Further, this AMD-only register may be accessed if this HVM guest
+          * has been migrated to an Intel host. This fixes a guest crash
+          * in this case.
+          */
+         msr_content = 0;
+         break;
+
     default:
         return hvm_funcs.msr_read_intercept(regs);
     }

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 5 lines · Christoph Egger

attached patch disables C1E in HVM guests.
This also fixes a guest crash via #GP
on cross-vendor migration.

Belongs in the SVM-specific MSR read intercept hook in svm.c?

-- Keir

#2 lore raw
Quoted 10 lines · On Thursday 12 March 2009 16:57:11 Keir Fraser wrote:
Quoted 7 lines · Christoph Egger

attached patch disables C1E in HVM guests.

This also fixes a guest crash via #GP
on cross-vendor migration.

Belongs in the SVM-specific MSR read intercept hook in svm.c?

No, because this MSR doesn't exist on Intel.

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632