patch sdhci-add-no_busy_irq-quirk-for-marvell-cafe-host-chip.patch added to 2.6.28-stable tree
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi
Quoted 19 lines · On Freitag, 13. März 2009, [email protected] wrote:
This is a note to let you know that we have just queued up the patch titled
Subject: sdhci: Add
NO_BUSY_IRQquirk for Marvell CAFE host chipto the 2.6.28-stable tree. Its filename is
sdhci-add-no_busy_irq-quirk-for-marvell-cafe-host-chip.patch
A git repo of this tree can be found at
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summaryFrom
a0874897b1ba106298e4303a25456a473fc40f3dMon Sep 17 00:00:00 2001
From: Andres Salomon <[email protected]>
Date: Mon, 2 Mar 2009 21:48:20 +0100
Subject: sdhci: AddNO_BUSY_IRQquirk for Marvell CAFE host chipFrom: Andres Salomon <[email protected]>
Quoted 7 lines
commit
a0874897b1ba106298e4303a25456a473fc40f3dupstream.As described here: http://lkml.org/lkml/2009/2/20/265
The CAFE chip is broken due to commit
e809517f6fa5803a5a1cd5602. Anton added a quirk here: http://lkml.org/lkml/2009/2/20/279 that fixes CAFE's problem. This adds the quirk for CAFE.
Adding this patch alone breaks compiling the current -stable queue for 2.6.28:
CC [M] drivers/mmc/host/sdhci-pci.odrivers/mmc/host/sdhci-pci.c:110: error: 'SDHCI_QUIRK_NO_BUSY_IRQ' undeclared here (not in a function) make[6]: *** [drivers/mmc/host/sdhci-pci.o] Error 1
make[5]: *** [drivers/mmc/host] Error 2
make[4]: *** [drivers/mmc] Error 2
make[3]: *** [drivers] Error 2
It seems to depend the following patch, wich introduces this particular quirk type:
commit f945405cdecd9e0ae3e58ff84cabd19b4522965e
Author: Ben Dooks <[email protected]> Date: Fri Feb 20 20:33:08 2009 +0300
sdhci: Add quirk for controllers with no end-of-busy IRQ
The Samsung SDHCI (and FSL eSDHC) controller block seems to fail to generate an INT_DATA_END after the transfer has completed and the bus busy state finished.
Changes in e809517f6fa5803a5a1cd56026f0e2190fc13d5c to use the new busy method are the cause of the behaviour change.
Regards
Stefan Lippers-Hollmann
Quoted 28 lines
Signed-off-by Andres Salomon <[email protected]>Signed-off-by Pierre Ossman <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/mmc/host/sdhci-pci.c | 1 + 1 file changed, 1 insertion(+)drivers/mmc/host/sdhci-pci.c +1
-0@@ -107,6 +107,7 @@ static const struct sdhci_pci_fixes sdhcstatic const struct sdhci_pci_fixes sdhci_cafe = { .quirks =SDHCI_QUIRK_NO_SIMULT_VDD_AND_POWER | +SDHCI_QUIRK_NO_BUSY_IRQ |SDHCI_QUIRK_BROKEN_TIMEOUT_VAL , };Patches currently in stable-queue which might be from [email protected] are
queue-2.6.28/sdhci-add-no_busy_irq-quirk-for-marvell-cafe-host-chip.patch--
To unsubscribe from this list: send the line "unsubscribe stable-commits" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 53 lines · Stefan Lippers-Hollmann
Hi
Quoted 19 lines · On Freitag, 13. März 2009, [email protected] wrote:
This is a note to let you know that we have just queued up the patch titled
Subject: sdhci: Add
NO_BUSY_IRQquirk for Marvell CAFE host chipto the 2.6.28-stable tree. Its filename is
sdhci-add-no_busy_irq-quirk-for-marvell-cafe-host-chip.patch
A git repo of this tree can be found at
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summaryFrom
a0874897b1ba106298e4303a25456a473fc40f3dMon Sep 17 00:00:00 2001
From: Andres Salomon <[email protected]>
Date: Mon, 2 Mar 2009 21:48:20 +0100
Subject: sdhci: AddNO_BUSY_IRQquirk for Marvell CAFE host chipFrom: Andres Salomon <[email protected]>
Quoted 7 lines
commit
a0874897b1ba106298e4303a25456a473fc40f3dupstream.As described here: http://lkml.org/lkml/2009/2/20/265
The CAFE chip is broken due to commit
e809517f6fa5803a5a1cd5602. Anton added a quirk here: http://lkml.org/lkml/2009/2/20/279 that fixes CAFE's problem. This adds the quirk for CAFE.Adding this patch alone breaks compiling the current -stable queue for 2.6.28:
CC [M]
drivers/mmc/host/sdhci-pci.odrivers/mmc/host/sdhci-pci.c:110: error: 'SDHCI_QUIRK_NO_BUSY_IRQ' undeclared here (not in a function) make[6]: *** [drivers/mmc/host/sdhci-pci.o] Error 1
make[5]: *** [drivers/mmc/host] Error 2
make[4]: *** [drivers/mmc] Error 2
make[3]: *** [drivers] Error 2It seems to depend the following patch, wich introduces this particular quirk type:
commit
f945405cdecd9e0ae3e58ff84cabd19b4522965eAuthor: Ben Dooks <[email protected]> Date: Fri Feb 20 20:33:08 2009 +0300sdhci: Add quirk for controllers with no end-of-busy IRQ
The Samsung SDHCI (and FSL eSDHC) controller block seems to fail to generate an
INT_DATA_ENDafter the transfer has completed and the bus busy state finished.
Quoted 6 lines
Changes in
e809517f6fa5803a5a1cd56026f0e2190fc13d5cto use the new busy method are the cause of the behaviour change.Signed-off-by Ben Dooks <[email protected]>Signed-off-by Anton Vorontsov <[email protected]>Signed-off-by Pierre Ossman <[email protected]>
Ah, good catch, thanks, I'll go add that patch as well.
greg k-h