Make virtio_net support carrier detection
Subsystems (3)
PATCH 1/1 Make virtio_net support carrier detection
Impact: Make NetworkManager work with virtio_net
For now the semantics are simple: There is always carrier.
This allows a seamless experience with e.g., qemu/kvm where NetworkManager just configures and sets up everything automagically.
If/when a generally agreed-upon way to control carrier on/off in the emulator/hypervisor level emerges, it will be trivial to extend the driver to support that too, but for now even this 2-liner makes user experience that much better.
--- drivers/net/virtio_net.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/net/virtio_net.c +3 -0
@@ -612,6 +612,7 @@ static struct ethtool_ops virtnet_ethtool_ops = { .set_tx_csum = virtnet_set_tx_csum, .set_sg = ethtool_op_set_sg, .set_tso = ethtool_op_set_tso, + .get_link = ethtool_op_get_link, };#define MIN_MTU 68
@@ -739,6 +740,8 @@ static int virtnet_probe(struct virtio_device *vdev) goto unregister; } +netif_carrier_on (dev); +pr_debug ("virtnet: registered device %s\n" , dev->name);return 0 ;
Signature · 1 line
1.5.6.3
From: Rusty Russell <[email protected]>
Date: Sat, 14 Mar 2009 10:53:51 +1030
Quoted 8 lines
Impact: Make NetworkManager work with
virtio_netFor now the semantics are simple: There is always carrier.
This allows a seamless experience with e.g., qemu/kvm where NetworkManager just configures and sets up everything automagically.
Quoted 8 lines
If/when a generally agreed-upon way to control carrier on/off in the emulator/hypervisor level emerges, it will be trivial to extend the driver to support that too, but for now even this 2-liner makes user experience that much better.
Signed-off-by Pantelis Koukousoulas <[email protected]>Signed-off-by Rusty Russell <[email protected]>
Applied, thanks Rusty.