iproute2 and regressing "ipv6: convert tunnels to net_device_ops"
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
(Cc'ed netdev ml)
Quoted 40 lines · Rafael J. Wysocki
Hi,
Quoted 26 lines · Jan Engelhardt
Hi,
commit
1326c3d5a4b792a2b15877feb7fb691f8945d203(v2.6.28-rc6-461-g23a12b1) broke the display of local and remote addresses of an SIT tunnel in iproute2. Instead of the addresses assigned, it only displays 0.0.0.0. The version of iproute2 is 2.6.25, as shipped with openSUSE 11.1.Before:
# ip t a sit7 mode sit remote 1.2.3.4 local 5.6.7.8 # ip a 7: sit7@NONE: <POINTOPOINT,NOARP> mtu 1480 qdisc noop stat DOWN link/sit 5.6.7.8 peer 1.2.3.4After:
7: sit7@NONE: <POINTOPOINT,NOARP> mtu 1480 qdisc noop stat DOWNlink/sit 0.0.0.0 brd 0.0.0.0---->
commit23a12b14715e2dcd34dc8002927263ad3437344cAuthor: Stephen Hemminger <[email protected]> Date: Thu Nov 20 20:33:56 2008 -0800ipv6: convert tunnels to
net_device_opsQuoted 8 lines
Like IPV4, convert the tunnel virtual devices to use
net_device_ops.Signed-off-by Stephen Hemminger <[email protected]>Signed-off-by David S. Miller <[email protected]>:040000 040000
23483d156e517904d31dd7e2276a0ff8a25f2ecc395574b3a80869307a5e936a02598476f7e1c49bM net
<----If you want me to track this, please send a copy to a mailing list with archives to which I can link or file a bugzilla report (with CC to me).
Quoted 2 lines · Jan Engelhardt
(Cc'ed netdev ml)
Tracked as http://bugzilla.kernel.org/show_bug.cgi?id=12868 .
Quoted 36 lines · Rafael J. Wysocki
Quoted 35 lines
Hi,
Quoted 31 lines · Jan Engelhardt
Hi,
commit
1326c3d5a4b792a2b15877feb7fb691f8945d203(v2.6.28-rc6-461-g23a12b1) broke the display of local and remote addresses of an SIT tunnel in iproute2. Instead of the addresses assigned, it only displays 0.0.0.0. The version of iproute2 is 2.6.25, as shipped with openSUSE 11.1.Before:
# ip t a sit7 mode sit remote 1.2.3.4 local 5.6.7.8 # ip a 7: sit7@NONE: <POINTOPOINT,NOARP> mtu 1480 qdisc noop stat DOWN link/sit 5.6.7.8 peer 1.2.3.4After:
7: sit7@NONE: <POINTOPOINT,NOARP> mtu 1480 qdisc noop stat DOWNlink/sit 0.0.0.0 brd 0.0.0.0---->
commit23a12b14715e2dcd34dc8002927263ad3437344cAuthor: Stephen Hemminger <[email protected]> Date: Thu Nov 20 20:33:56 2008 -0800ipv6: convert tunnels to
net_device_opsLike IPV4, convert the tunnel virtual devices to use
net_device_ops.Signed-off-by Stephen Hemminger <[email protected]>Signed-off-by David S. Miller <[email protected]>
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
:040000 040000
23483d156e517904d31dd7e2276a0ff8a25f2ecc395574b3a80869307a5e936a02598476f7e1c49bM net
<----If you want me to track this, please send a copy to a mailing list with archives to which I can link or file a bugzilla report (with CC to me).
Thanks,
Rafael
PATCH 1/1 ipv6: fix display of local and remote sit endpoints
ipv6: fix display of local and remote sit endpoints
This fixes the regressions cause by
commit 1326c3d5a4b792a2b15877feb7fb691f8945d203 (v2.6.28-rc6-461-g23a12b1) broke the display of local and remote addresses of an SIT tunnel in iproute2.
nt->parms is used by ipip6_tunnel_init() and therefore need to be initialized first.
Tracked as http://bugzilla.kernel.org/show_bug.cgi?id=12868
--- net/ipv6/sit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv6/sit.c +1 -1
@@ -188,9 +188,9 @@ static struct ip_tunnel * ipip6_tunnel_locate(struct net *net, } nt =netdev_priv (dev); -ipip6_tunnel_init (dev); nt->parms = *parms; +ipip6_tunnel_init (dev);if (parms->i_flags &SIT_ISATAP ) dev->priv_flags |=IFF_ISATAP ;
Signature · 1 line
1.5.6.5
Re: [PATCH] ipv6: fix display of local and remote sit endpoints
From: Bjørn Mork <[email protected]>
Date: Mon, 16 Mar 2009 14:47:24 +0100
Quoted 7 lines
ipv6: fix display of local and remote sit endpoints
This fixes the regressions cause by
commit1326c3d5a4b792a2b15877feb7fb691f8945d203(v2.6.28-rc6-461-g23a12b1) broke the display of local and remote addresses of an SIT tunnel in iproute2.
Quoted 7 lines
nt->parmsis used byipip6_tunnel_init()and therefore need to be initialized first.Tracked as http://bugzilla.kernel.org/show_bug.cgi?id=12868
Reported-by Jan Engelhardt <[email protected]>Signed-off-by Bjørn Mork <[email protected]>
Applied, thanks.