Skip to contentSkip to conversation

fix regression from "vsprintf: unify the format decoding layer for its 3 users"

tip:core/printk Frederic Weisbecker 1 participant 1 message Mar 15, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 33 lines · Vegard Nossum
Commit-ID:  adf26f84a62b492e002d3b75af671f23ddd3be0a
Gitweb:     http://git.kernel.org/tip/adf26f84a62b492e002d3b75af671f23ddd3be0a
Author:     Vegard Nossum <[email protected]>
AuthorDate: Sat, 14 Mar 2009 12:08:50 +0100
Commit:     Ingo Molnar <[email protected]>
CommitDate: Sat, 14 Mar 2009 12:37:08 +0100

fix regression from "vsprintf: unify the format decoding layer for its 3 users"

Jeremy Fitzhardinge reported:

Quoted 4 lines

Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf:
unify the format decoding layer for its 3 users", causes a regression in xenbus which results in no devices getting attached to a new domain.

%.*s is broken - fix it.

---
 lib/vsprintf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
lib/vsprintf.c +0 -0
index dc16743..708e505 100644

lib/vsprintf.c precision: · line 849

Quoted 8 lines
lib/vsprintf.c +1 -1
@@ -843,7 +843,7 @@ precision:
 				spec->precision = 0;
 		} else if (*fmt == '*') {
 			/* it's the next argument */
-			spec->type = FORMAT_TYPE_WITDH;
+			spec->type = FORMAT_TYPE_PRECISION;
 			return ++fmt - start;
 		}
 	}

Thanks a lot for this patch!

Frederic.