example: introduce EXAMPLE_LOAD_ADDR
PATCH 1/1 example: introduce EXAMPLE_LOAD_ADDR
that could be overwrite in followaing order
ARCH
CPU
SOC
BOARD
via the corresponding config.mk
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
--- arm_config.mk | 2 + avr32_config.mk | 2 + blackfin_config.mk | 2 + board/omap2420h4/config.mk | 2 + cpu/arm_cortexa8/omap3/config.mk | 2 + examples/Makefile | 47 +++++--------------------------------- i386_config.mk | 2 + m68k_config.mk | 2 + microblaze_config.mk | 2 + mips_config.mk | 2 + nios2_config.mk | 2 + nios_config.mk | 2 + ppc_config.mk | 2 + sh_config.mk | 2 + sparc_config.mk | 2 + 15 files changed, 34 insertions(+), 41 deletions(-)
arm_config.mk +2 -0
@@ -22,3 +22,5 @@ # PLATFORM_CPPFLAGS += -DCONFIG_ARM -D__ARM__ + +EXAMPLE_LOAD_ADDR = 0xc100000
avr32_config.mk +2 -0
@@ -23,3 +23,5 @@ PLATFORM_RELFLAGS += -ffixed-r5 -fPIC -mno-init-got -mrelax PLATFORM_LDFLAGS += --relax + +EXAMPLE_LOAD_ADDR = 0x00000000
blackfin_config.mk +2 -0
@@ -44,3 +44,5 @@ endif ifneq (,$(findstring s,$(MAKEFLAGS))) LDR_FLAGS += --quiet endif + +EXAMPLE_LOAD_ADDR = 0x1000
board/omap2420h4/config.mk +2 -0
@@ -26,3 +26,5 @@ TEXT_BASE = 0x80e80000 #TEXT_BASE = 0x0 #TEXT_BASE = 0x08000000 #TEXT_BASE = 0x04000000 + +EXAMPLE_LOAD_ADDR = 0x80300000
cpu/arm_cortexa8/omap3/config.mk +2 -0
@@ -34,3 +34,5 @@ PLATFORM_CPPFLAGS +=$(call cc-option) PLATFORM_CPPFLAGS +=$(call cc-option,-mno-thumb-interwork,) PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,\ $(call cc-option,-malignment-traps,)) + +EXAMPLE_LOAD_ADDR = 0x80300000
examples/Makefile +6 -41
76 lines not on this page · raw message
i386_config.mk +2 -0
@@ -22,3 +22,5 @@ # PLATFORM_CPPFLAGS += -DCONFIG_I386 -D__I386__ + +EXAMPLE_LOAD_ADDR = 0x40000
m68k_config.mk +2 -0
@@ -23,3 +23,5 @@ PLATFORM_CPPFLAGS += -DCONFIG_M68K -D__M68K__ PLATFORM_LDFLAGS += -n + +EXAMPLE_LOAD_ADDR = 0x20000
microblaze_config.mk +2 -0
@@ -25,3 +25,5 @@ # PLATFORM_CPPFLAGS += -ffixed-r31 -D__microblaze__ + +EXAMPLE_LOAD_ADDR = 0x80F00000
mips_config.mk +2 -0
@@ -46,3 +46,5 @@ PLATFORM_CPPFLAGS += -DCONFIG_MIPS -D__MIPS__ PLATFORM_CPPFLAGS += -G 0 -mabicalls -fpic PLATFORM_CPPFLAGS += -msoft-float PLATFORM_LDFLAGS += -G 0 -static -n -nostdlib + +EXAMPLE_LOAD_ADDR = 0x80200000
nios2_config.mk +2 -0
@@ -24,3 +24,5 @@ PLATFORM_CPPFLAGS += -DCONFIG_NIOS2 -D__NIOS2__ PLATFORM_CPPFLAGS += -ffixed-r15 -G0 + +EXAMPLE_LOAD_ADDR = 0x02000000
nios_config.mk +2 -0
@@ -23,3 +23,5 @@ # PLATFORM_CPPFLAGS += -m32 -DCONFIG_NIOS -D__NIOS__ -ffixed-g7 -gstabs + +EXAMPLE_LOAD_ADDR = 0x00800000
ppc_config.mk +2 -0
@@ -37,3 +37,5 @@ endif ifeq ($(CROSS_COMPILE),powerpc-openbsd-) PLATFORM_CPPFLAGS+= -D__PPC__ endif + +EXAMPLE_LOAD_ADDR = 0x40000
sh_config.mk +2 -0
@@ -22,3 +22,5 @@ # PLATFORM_CPPFLAGS += -DCONFIG_SH -D__SH__ + +EXAMPLE_LOAD_ADDR = 0x8C000000
sparc_config.mk +2 -0
@@ -22,3 +22,5 @@ # PLATFORM_CPPFLAGS += -DCONFIG_SPARC -D__sparc__ + +EXAMPLE_LOAD_ADDR = 0x00000000
Signature · 1 line
1.5.6.5
PATCH 1/1 example: introduce EXAMPLE_LOAD_ADDR
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 1 line · In message <[email protected]> you wrote:
that could be overwrite in followaing order
-----------------------------^^^^^^^^^^
Please fix spelling.
Quoted 9 lines
ARCH
CPU
SOC
BOARDvia the corresponding config.mk
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
And please rename EXAMPLE_LOAD_ADDR into STANDALONE_LOAD_ADDR or similar.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is clear that the individual who persecutes a man, his brother, because he is not of the same opinion, is a monster. - Voltaire
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
that could be overwrite in following order
ARCH
CPU
SOC
BOARD
via the corresponding config.mk
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
---
V2:
fix a typo on the comment
and rename EXAMPLE_LOAD_ADRR to STANDALONE_LOAD_ADDR
Best Regards,
J.
arm_config.mk | 2 + avr32_config.mk | 2 + blackfin_config.mk | 2 + board/omap2420h4/config.mk | 2 + cpu/arm_cortexa8/omap3/config.mk | 2 + examples/Makefile | 47 +++++--------------------------------- i386_config.mk | 2 + m68k_config.mk | 2 + microblaze_config.mk | 2 + mips_config.mk | 2 + nios2_config.mk | 2 + nios_config.mk | 2 + ppc_config.mk | 2 + sh_config.mk | 2 + sparc_config.mk | 2 + 15 files changed, 34 insertions(+), 41 deletions(-)
arm_config.mk +2 -0
@@ -22,3 +22,5 @@ # PLATFORM_CPPFLAGS += -DCONFIG_ARM -D__ARM__ + +STANDALONE_LOAD_ADDR = 0xc100000
avr32_config.mk +2 -0
@@ -23,3 +23,5 @@ PLATFORM_RELFLAGS += -ffixed-r5 -fPIC -mno-init-got -mrelax PLATFORM_LDFLAGS += --relax + +STANDALONE_LOAD_ADDR = 0x00000000
blackfin_config.mk +2 -0
@@ -44,3 +44,5 @@ endif ifneq (,$(findstring s,$(MAKEFLAGS))) LDR_FLAGS += --quiet endif + +STANDALONE_LOAD_ADDR = 0x1000
board/omap2420h4/config.mk +2 -0
@@ -26,3 +26,5 @@ TEXT_BASE = 0x80e80000 #TEXT_BASE = 0x0 #TEXT_BASE = 0x08000000 #TEXT_BASE = 0x04000000 + +STANDALONE_LOAD_ADDR = 0x80300000
cpu/arm_cortexa8/omap3/config.mk +2 -0
@@ -34,3 +34,5 @@ PLATFORM_CPPFLAGS +=$(call cc-option) PLATFORM_CPPFLAGS +=$(call cc-option,-mno-thumb-interwork,) PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,\ $(call cc-option,-malignment-traps,)) + +STANDALONE_LOAD_ADDR = 0x80300000
examples/Makefile +6 -41
76 lines not on this page · raw message
i386_config.mk +2 -0
@@ -22,3 +22,5 @@ # PLATFORM_CPPFLAGS += -DCONFIG_I386 -D__I386__ + +STANDALONE_LOAD_ADDR = 0x40000
m68k_config.mk +2 -0
@@ -23,3 +23,5 @@ PLATFORM_CPPFLAGS += -DCONFIG_M68K -D__M68K__ PLATFORM_LDFLAGS += -n + +STANDALONE_LOAD_ADDR = 0x20000
microblaze_config.mk +2 -0
@@ -25,3 +25,5 @@ # PLATFORM_CPPFLAGS += -ffixed-r31 -D__microblaze__ + +STANDALONE_LOAD_ADDR = 0x80F00000
mips_config.mk +2 -0
@@ -46,3 +46,5 @@ PLATFORM_CPPFLAGS += -DCONFIG_MIPS -D__MIPS__ PLATFORM_CPPFLAGS += -G 0 -mabicalls -fpic PLATFORM_CPPFLAGS += -msoft-float PLATFORM_LDFLAGS += -G 0 -static -n -nostdlib + +STANDALONE_LOAD_ADDR = 0x80200000
nios2_config.mk +2 -0
@@ -24,3 +24,5 @@ PLATFORM_CPPFLAGS += -DCONFIG_NIOS2 -D__NIOS2__ PLATFORM_CPPFLAGS += -ffixed-r15 -G0 + +STANDALONE_LOAD_ADDR = 0x02000000
nios_config.mk +2 -0
@@ -23,3 +23,5 @@ # PLATFORM_CPPFLAGS += -m32 -DCONFIG_NIOS -D__NIOS__ -ffixed-g7 -gstabs + +STANDALONE_LOAD_ADDR = 0x00800000
ppc_config.mk +2 -0
@@ -37,3 +37,5 @@ endif ifeq ($(CROSS_COMPILE),powerpc-openbsd-) PLATFORM_CPPFLAGS+= -D__PPC__ endif + +STANDALONE_LOAD_ADDR = 0x40000
sh_config.mk +2 -0
@@ -22,3 +22,5 @@ # PLATFORM_CPPFLAGS += -DCONFIG_SH -D__SH__ + +STANDALONE_LOAD_ADDR = 0x8C000000
sparc_config.mk +2 -0
@@ -22,3 +22,5 @@ # PLATFORM_CPPFLAGS += -DCONFIG_SPARC -D__sparc__ + +STANDALONE_LOAD_ADDR = 0x00000000
Signature · 1 line
1.5.6.5
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Quoted 7 lines · On Saturday 14 March 2009 07:13:02 Jean-Christophe PLAGNIOL-VILLARD wrote:
that could be overwrite in following order
ARCH
CPU
SOC
BOARDvia the corresponding config.mk
the idea sounds fine to me ...
Quoted 2 lines
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
i dont really understand what you're trying to say here. could you elaborate so we can fix up the changelog ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090314/6f580d1e/attachment.pgp
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Quoted 9 lines · Mike Frysinger
Quoted 7 lines · On Saturday 14 March 2009 07:13:02 Jean-Christophe PLAGNIOL-VILLARD wrote:
that could be overwrite in following order
ARCH
CPU
SOC
BOARDvia the corresponding config.mk
Quoted 7 lines
the idea sounds fine to me ...
Quoted 2 lines
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
i dont really understand what you're trying to say here. could you elaborate so we can fix up the changelog ?
as example generate via the config.h a env var name standalone_load_addr automaticly so the end user will just have to built it, load it and run it
Best Regards,
J.
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Quoted 12 lines · On Saturday 14 March 2009 08:45:56 Jean-Christophe PLAGNIOL-VILLARD wrote:
Quoted 11 lines · Mike Frysinger
Quoted 7 lines · On Saturday 14 March 2009 07:13:02 Jean-Christophe PLAGNIOL-VILLARD wrote:
that could be overwrite in following order
ARCH
CPU
SOC
BOARDvia the corresponding config.mk
the idea sounds fine to me ...
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
i dont really understand what you're trying to say here. could you elaborate so we can fix up the changelog ?
as example generate via the
config.ha env var namestandalone_load_addrautomaticly so the end user will just have to built it, load it and run it
i still dont get it. config.h is the shortcut header to get at the board config.h. defines do not randomly get exported from there into the environment. the autoconf.mk mechanism only exports CONFIG_* stuff.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090314/1bb30a1c/attachment.pgp
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Quoted 19 lines · Mike Frysinger
Quoted 18 lines · On Saturday 14 March 2009 08:45:56 Jean-Christophe PLAGNIOL-VILLARD wrote:
Quoted 16 lines · Mike Frysinger
Quoted 7 lines · On Saturday 14 March 2009 07:13:02 Jean-Christophe PLAGNIOL-VILLARD wrote:
that could be overwrite in following order
ARCH
CPU
SOC
BOARDvia the corresponding config.mk
the idea sounds fine to me ...
Quoted 2 lines
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
i dont really understand what you're trying to say here. could you elaborate so we can fix up the changelog ?
Quoted 6 lines
Quoted 2 lines
as example generate via the
config.ha env var namestandalone_load_addrautomaticly so the end user will just have to built it, load it and run iti still dont get it.
config.his the shortcut header to get at the boardconfig.h. defines do not randomly get exported from there into the environment. the autoconf.mk mechanism only exports CONFIG_* stuff.
via the board config.h you could add default extra env settings by doing this as example
#define CONFIG_EXTRA_ENV_SETTINGS "standalone_load_addr="xstr(STANDALONE_LOAD_ADDR)
Best Regards,
J.
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Quoted 28 lines · On Saturday 14 March 2009 09:19:01 Jean-Christophe PLAGNIOL-VILLARD wrote:
Quoted 19 lines · Mike Frysinger
Quoted 18 lines · On Saturday 14 March 2009 08:45:56 Jean-Christophe PLAGNIOL-VILLARD wrote:
Quoted 16 lines · Mike Frysinger
Quoted 7 lines · On Saturday 14 March 2009 07:13:02 Jean-Christophe wrote:
that could be overwrite in following order
ARCH
CPU
SOC
BOARDvia the corresponding config.mk
the idea sounds fine to me ...
Quoted 2 lines
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
i dont really understand what you're trying to say here. could you elaborate so we can fix up the changelog ?
Quoted 7 lines
Quoted 3 lines
as example generate via the
config.ha env var namestandalone_load_addrautomaticly so the end user will just have to built it, load it and run iti still dont get it.
config.his the shortcut header to get at the boardconfig.h. defines do not randomly get exported from there into the environment. the autoconf.mk mechanism only exports CONFIG_* stuff.
Quoted 5 lines
via the board
config.hyou could add default extra env settings by doing this as example#define
CONFIG_EXTRA_ENV_SETTINGS
"standalone_load_addr="xstr(STANDALONE_LOAD_ADDR)
so you're talking about the u-boot runtime environment, not the u-boot build environment.
i dont think your example here is the whole story. nothing moves the u-boot make var STANDALONE_LOAD_ADDR from the env into CPPFLAGS / define. so you would also need to add to some .mk somewhere:
CPPFLAGS += -DSTANDALONE_LOAD_ADDR=$(STANDALONE_LOAD_ADDR)
probably best if you just deleted that last paragraph from the commit message since it's too vague to be useful imo.
-mike
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
In reply to Jean-Christophe PLAGNIOL-VILLARDDear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 6 lines
Quoted 3 lines
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
i dont really understand what you're trying to say here. could you elaborate so we can fix up the changelog ?
as example generate via the
config.ha env var namestandalone_load_addrautomaticly so the end user will just have to built it, load it and run it
This is error prone. NAK.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I object to intellect without discipline; I object to power without constructive purpose. -- Spock, "The Squire of Gothos", stardate 2124.5
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Quoted 7 lines · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Quoted 3 lines
the value could be exported to the environment to reduce the user mistake when they try to use example's standalone application
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
i dont really understand what you're trying to say here. could you elaborate so we can fix up the changelog ?
as example generate via the
config.ha env var namestandalone_load_addrautomaticly so the end user will just have to built it, load it and run itThis is error prone. NAK.
which error?
Best Regards,
J.
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 5 lines
Quoted 3 lines
as example generate via the
config.ha env var namestandalone_load_addrautomaticly so the end user will just have to built it, load it and run itThis is error prone. NAK.
which error?
The load address of a standalone application cannot be known at compile time of the U-Boot image.
Please don't assume that the code / Makefiles etc. of that application is even part of the U-Boot source tree or build system.
Please don't assume that everybody uses the same load addresses.
Please don't asume that all standalone applications running on a system use the same load addresses - there are cases, where several SA apps are simultaneously loaded, etc.
Don't try to be clever when this cannot work.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A meeting is an event at which the minutes are kept and the hours are lost.
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Quoted 10 lines · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 5 lines
Quoted 3 lines
as example generate via the
config.ha env var namestandalone_load_addrautomaticly so the end user will just have to built it, load it and run itThis is error prone. NAK.
which error?
Quoted 7 lines
The load address of a standalone application cannot be known at compile time of the U-Boot image.
Please don't assume that the code / Makefiles etc. of that application is even part of the U-Boot source tree or build system.
Please don't assume that everybody uses the same load addresses.
I do not assume it that's why I've call it at the first version EXAMPLE_LOAD_ADDR because it was only for the example
Quoted 4 lines
Please don't asume that all standalone applications running on a system use the same load addresses - there are cases, where several SA apps are simultaneously loaded, etc.
I known I just want to cleanup the example
As you describe we can run multiple app at the same time and I've done it on some of my board
Best Regards,
J.
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
In reply to Wolfgang DenkQuoted 15 lines · On Sunday 15 March 2009 14:29:59 Wolfgang Denk wrote:
Quoted 7 lines · In message Jean-Christophe PLAGNIOL-VILLARD you
Quoted 5 lines
Quoted 3 lines
as example generate via the
config.ha env var namestandalone_load_addrautomaticly so the end user will just have to built it, load it and run itThis is error prone. NAK.
which error?
The load address of a standalone application cannot be known at compile time of the U-Boot image.
Please don't assume that the code / Makefiles etc. of that application is even part of the U-Boot source tree or build system.
Quoted 8 lines
Please don't assume that everybody uses the same load addresses.
Please don't asume that all standalone applications running on a system use the same load addresses - there are cases, where several SA apps are simultaneously loaded, etc.
Don't try to be clever when this cannot work.
i dont really see the value in moving the load addr from the u-boot build env to the board env automatically, but moving the definitions from examples/Makefile to the top level $arch_config.mk sounds sane to me. -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090315/88522392/attachment.pgp
PATCH v2 1/1 example/standalone: introduce STANDALONE_LOAD_ADDR
Dear Mike Frysinger,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Don't try to be clever when this cannot work.
i dont really see the value in moving the load addr from the u-boot build env to the board env automatically, but moving the definitions from examples/Makefile to the top level $arch_config.mk sounds sane to me.
Right. Thanks for making this clear.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Nobody will ever need more than 640k RAM!" -- Bill Gates, 1981 "Windows 95 needs at least 8 MB RAM." -- Bill Gates, 1996 "Nobody will ever need Windows 95." -- logical conclusion