Skip to contentSkip to conversation

ath5k: Choose the right initvals for RF2425

PATCH In review Nick Kossifidis 2 participants 2 messages Mar 15, 2009 – Mar 16, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ath5k: Choose the right initvals for RF2425

* Fix a typo in initvals.c so that we use the RF2425 array for RF2425 and not RF2413

Note: This also fixes incorect pd gain overlap since RF2425 has different pd gain overlap from RF2413

---
 drivers/net/wireless/ath5k/initvals.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath5k/initvals.c +2 -2
index 4488643..61fb621 100644
@@ -1510,8 +1510,8 @@ int ath5k_hw_write_initvals(struct ath5k_hw *ah, u8 mode, bool change_channel)
 					rf2425_ini_mode_end, mode);
 
 			ath5k_hw_ini_registers(ah,
-					ARRAY_SIZE(rf2413_ini_common_end),
-					rf2413_ini_common_end, change_channel);
+					ARRAY_SIZE(rf2425_ini_common_end),
+					rf2425_ini_common_end, change_channel);
 
 			ath5k_hw_ini_registers(ah,
 					ARRAY_SIZE(rf5112_ini_bbgain),
Acked-by on v1 1/3
#1 lore raw
Quoted 5 lines · Nick Kossifidis

* Fix a typo in initvals.c so that we use the RF2425 array for RF2425 and not RF2413

Note: This also fixes incorect pd gain overlap since RF2425 has different pd gain overlap from RF2413

Nice work, series:

If you do a follow-up cleanup patch, one quick thought I had is that ee_pwr_cal_[abg] could be an array indexed by mode which might save a few switch statements - I didn't look at it that hard though.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com